From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F70CC4167B for ; Mon, 27 Nov 2023 02:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fbwCmLnTKk0m9vJVDkEmXYmPikIe2JJyVpYKtvlm/R4=; b=yT6NSxDjUvgqDY QsQ2qv1zYVB9HOMmBgYGNgdzz9JL45vJoQ04WtffJgPwm3WR7oMpAGNO77LtZWo/Vl3VXWcsWdt3f Z3fZ3SXCmrU+7dWqsUlDGGXC1ZZMDT6ABd+RBhLDuUsbFhxV5aKrhZRNdus7mk31E4YRmN1FgBZJn iehchddKLlWIaRm8RO67KgN9N+JFg4KN2JOI8+pQODj6yuhHc/ir9u4peM2A9tZT5OUnSJaV2pjkh hlafeTU2ImIs8nFsebcHIY11iLBTokyIro4eD7A8F9mDzaF1gOwoMpaWYlTp5PB9zKTV7qJBYVj9T N/IXkyPA69+3RjPOyhWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r7RoI-0011VZ-2C; Mon, 27 Nov 2023 02:57:22 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7RoE-0011MM-1Z for linux-arm-kernel@lists.infradead.org; Mon, 27 Nov 2023 02:57:20 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 4159DB8109A; Mon, 27 Nov 2023 02:57:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57B52C433C8; Mon, 27 Nov 2023 02:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701053831; bh=1JsYrnaKOXBSSBmst8jDG0Y0RikUhacklEL+uSp9B2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=scoiiHyk96Mxd3J3gNIGvbvCMGknLnXXH/B99NhwRHMlmi9aUw76f4n++Z+TL8S5A thdYdwiqlUtGTNnGtzxJLBktq9rh6IFk92aoZ7p6Uq/qCWg3zGNk4Y7fkJhWti3Z8I h1duZuFN5wz/rbqXvCRfXnrd7HOxMnQ32ucTRifzL4M0fodc7a4M8lRJNL1jFVLoJ1 geKiuGFQZnji647J2upsd/7RApNWWg6zH6ZX0NPiRW7qSWGNadwakeFMcBx0x4f9Em 2ng9hRIeI20zM6CEWb3ZT8zBsI2Ovm5Y9uHirQsT0gRMHOIica9X0C3s1h+wsYBSeJ O1upfkedU5q/A== Date: Mon, 27 Nov 2023 10:57:06 +0800 From: Shawn Guo To: Kieran Bingham Cc: devicetree@vger.kernel.org, Marco Felsch , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , open list Subject: Re: [PATCH v2] arm64: dts: freescale: debix-som-a-bmb-08: Add CSI Power Regulators Message-ID: <20231127025706.GT87953@dragon> References: <20231101104614.2209986-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231101104614.2209986-1-kieran.bingham@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231126_185718_946876_1A59C830 X-CRM114-Status: GOOD ( 15.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 01, 2023 at 10:46:11AM +0000, Kieran Bingham wrote: > Provide the 1.8 and 3.3 volt regulators that are utilised on the Debix > SOM BMB-08 base board. > > Facilitate this by also supplying the pin control used to enable the > regulators on the second MIPI CSI port. > > Reviewed-by: Marco Felsch > Signed-off-by: Kieran Bingham > > --- > v2: > - Remove _SW post fixes from regulators. > > .../freescale/imx8mp-debix-som-a-bmb-08.dts | 56 +++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts > index 0b0c95432bdc..386177c66c6d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts > @@ -63,6 +63,50 @@ regulator-som-vdd3v3 { > regulator-always-on; > }; > > + reg_csi1_1v8: regulator-csi1-vdd1v8 { > + compatible = "regulator-fixed"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "CSI1_VDD1V8"; > + gpio = <&expander0 13 GPIO_ACTIVE_HIGH>; > + vin-supply = <®_baseboard_vdd3v3>; > + enable-active-high; Could you move it one line above, so that it appears right after GPIO_ACTIVE_HIGH polarity? Shawn > + }; > + > + reg_csi1_3v3: regulator-csi1-vdd3v3 { > + compatible = "regulator-fixed"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "CSI1_VDD3V3"; > + gpio = <&expander0 14 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + vin-supply = <®_vdd5v0>; > + }; > + > + reg_csi2_1v8: regulator-csi2-vdd1v8 { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_reg_csi2_1v8>; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-name = "CSI2_VDD1V8"; > + gpio = <&gpio3 21 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + vin-supply = <®_baseboard_vdd3v3>; > + }; > + > + reg_csi2_3v3: regulator-csi2-vdd3v3 { > + compatible = "regulator-fixed"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_reg_csi2_3v3>; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-name = "CSI2_VDD3V3"; > + gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + vin-supply = <®_vdd5v0>; > + }; > + > regulator-vbus-usb20 { > compatible = "regulator-fixed"; > regulator-min-microvolt = <5000000>; > @@ -413,6 +457,18 @@ MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03 0x41 > >; > }; > > + pinctrl_reg_csi2_1v8: regcsi21v8grp { > + fsl,pins = < > + MX8MP_IOMUXC_SAI5_RXD0__GPIO3_IO21 0x19 > + >; > + }; > + > + pinctrl_reg_csi2_3v3: regcsi23v3grp { > + fsl,pins = < > + MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 0x19 > + >; > + }; > + > pinctrl_uart2: uart2grp { > fsl,pins = < > MX8MP_IOMUXC_UART2_RXD__UART2_DCE_RX 0x14f > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel