From: Jason Gunthorpe <jgg@nvidia.com>
To: Eric Auger <eauger@redhat.com>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>,
Michael Shavit <mshavit@google.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Subject: Re: [PATCH v2 01/19] iommu/arm-smmu-v3: Add a type for the STE
Date: Mon, 27 Nov 2023 14:21:43 -0400 [thread overview]
Message-ID: <20231127182143.GD1165737@nvidia.com> (raw)
In-Reply-To: <5ebcbd88-bd2a-4853-a0c7-1c2f0f7dc592@redhat.com>
On Mon, Nov 27, 2023 at 06:51:21PM +0100, Eric Auger wrote:
> Hi Jason,
>
> On 11/27/23 18:42, Jason Gunthorpe wrote:
> > On Mon, Nov 27, 2023 at 05:03:36PM +0100, Eric Auger wrote:
> >
> >>> -static __le64 *arm_smmu_get_step_for_sid(struct arm_smmu_device *smmu, u32 sid)
> >>> +static struct arm_smmu_ste *
> >>> +arm_smmu_get_step_for_sid(struct arm_smmu_device *smmu, u32 sid)
> >>> {
> >>> - __le64 *step;
> >>> struct arm_smmu_strtab_cfg *cfg = &smmu->strtab_cfg;
> >>>
> >>> if (smmu->features & ARM_SMMU_FEAT_2_LVL_STRTAB) {
> >>> - struct arm_smmu_strtab_l1_desc *l1_desc;
> >>> int idx;
> >>>
> >>> /* Two-level walk */
> >>> idx = (sid >> STRTAB_SPLIT) * STRTAB_L1_DESC_DWORDS;
> >>> - l1_desc = &cfg->l1_desc[idx];
> >>> - idx = (sid & ((1 << STRTAB_SPLIT) - 1)) * STRTAB_STE_DWORDS;
> >>> - step = &l1_desc->l2ptr[idx];
> >>> + return &cfg->l1_desc[idx].l2ptr[sid & ((1 << STRTAB_SPLIT) - 1)];
> >> This looks less readable to me than it was before.
> >
> > You would like the idx calculation outside?
> >
> > idx1 = (sid >> STRTAB_SPLIT) * STRTAB_L1_DESC_DWORDS;
> > idx2 = sid & ((1 << STRTAB_SPLIT) - 1);
> > return &cfg->l1_desc[idx].l2ptr[idx2];
> Yes this looks more readable to me
done
Jason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-27 18:22 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 17:53 [PATCH v2 00/19] Update SMMUv3 to the modern iommu API (part 1/3) Jason Gunthorpe
2023-11-13 17:53 ` [PATCH v2 01/19] iommu/arm-smmu-v3: Add a type for the STE Jason Gunthorpe
2023-11-14 15:06 ` Moritz Fischer
2023-11-15 11:52 ` Michael Shavit
2023-11-15 13:35 ` Jason Gunthorpe
2023-11-27 16:03 ` Eric Auger
2023-11-27 17:42 ` Jason Gunthorpe
2023-11-27 17:51 ` Eric Auger
2023-11-27 18:21 ` Jason Gunthorpe [this message]
2023-12-05 0:44 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 02/19] iommu/arm-smmu-v3: Master cannot be NULL in arm_smmu_write_strtab_ent() Jason Gunthorpe
2023-11-14 15:17 ` Moritz Fischer
2023-11-15 11:55 ` Michael Shavit
2023-11-27 15:41 ` Eric Auger
2023-12-05 0:45 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 03/19] iommu/arm-smmu-v3: Remove ARM_SMMU_DOMAIN_NESTED Jason Gunthorpe
2023-11-14 15:18 ` Moritz Fischer
2023-11-27 16:35 ` Eric Auger
2023-12-05 0:46 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 04/19] iommu/arm-smmu-v3: Make STE programming independent of the callers Jason Gunthorpe
2023-12-05 1:38 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 05/19] iommu/arm-smmu-v3: Consolidate the STE generation for abort/bypass Jason Gunthorpe
2023-11-15 12:17 ` Michael Shavit
2023-12-05 1:43 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 06/19] iommu/arm-smmu-v3: Move arm_smmu_rmr_install_bypass_ste() Jason Gunthorpe
2023-11-15 13:57 ` Michael Shavit
2023-12-05 1:45 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 07/19] iommu/arm-smmu-v3: Move the STE generation for S1 and S2 domains into functions Jason Gunthorpe
2023-11-14 15:24 ` Moritz Fischer
2023-11-15 14:01 ` Michael Shavit
2023-12-05 1:55 ` Nicolin Chen
2023-12-05 14:35 ` Jason Gunthorpe
2023-11-13 17:53 ` [PATCH v2 08/19] iommu/arm-smmu-v3: Build the whole STE in arm_smmu_make_s2_domain_ste() Jason Gunthorpe
2023-11-15 14:04 ` Michael Shavit
2023-12-05 1:58 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 09/19] iommu/arm-smmu-v3: Hold arm_smmu_asid_lock during all of attach_dev Jason Gunthorpe
2023-11-15 14:12 ` Michael Shavit
2023-12-05 2:16 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 10/19] iommu/arm-smmu-v3: Compute the STE only once for each master Jason Gunthorpe
2023-11-15 14:16 ` Michael Shavit
2023-12-05 2:13 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 11/19] iommu/arm-smmu-v3: Do not change the STE twice during arm_smmu_attach_dev() Jason Gunthorpe
2023-11-15 15:15 ` Michael Shavit
2023-11-16 16:28 ` Jason Gunthorpe
2023-12-05 2:46 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 12/19] iommu/arm-smmu-v3: Put writing the context descriptor in the right order Jason Gunthorpe
2023-11-15 15:32 ` Michael Shavit
2023-11-16 16:46 ` Jason Gunthorpe
2023-11-17 4:14 ` Michael Shavit
2023-12-05 3:38 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 13/19] iommu/arm-smmu-v3: Pass smmu_domain to arm_enable/disable_ats() Jason Gunthorpe
2023-12-05 3:56 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 14/19] iommu/arm-smmu-v3: Remove arm_smmu_master->domain Jason Gunthorpe
2023-11-27 17:14 ` Eric Auger
2023-11-30 12:03 ` Jason Gunthorpe
2023-12-05 13:25 ` Eric Auger
2023-12-05 4:47 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 15/19] iommu/arm-smmu-v3: Add a global static IDENTITY domain Jason Gunthorpe
2023-11-15 15:50 ` Michael Shavit
2023-12-05 4:28 ` Nicolin Chen
2023-12-05 14:37 ` Jason Gunthorpe
2023-12-05 17:25 ` Nicolin Chen
2023-12-05 17:42 ` Jason Gunthorpe
2023-12-05 18:21 ` Nicolin Chen
2023-12-05 19:03 ` Jason Gunthorpe
2023-11-13 17:53 ` [PATCH v2 16/19] iommu/arm-smmu-v3: Add a global static BLOCKED domain Jason Gunthorpe
2023-11-15 15:57 ` Michael Shavit
2023-11-16 15:44 ` Jason Gunthorpe
2023-12-05 4:05 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 17/19] iommu/arm-smmu-v3: Use the identity/blocked domain during release Jason Gunthorpe
2023-12-05 4:07 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 18/19] iommu/arm-smmu-v3: Pass arm_smmu_domain and arm_smmu_device to finalize Jason Gunthorpe
2023-11-15 16:02 ` Michael Shavit
2023-12-05 4:42 ` Nicolin Chen
2023-11-13 17:53 ` [PATCH v2 19/19] iommu/arm-smmu-v3: Convert to domain_alloc_paging() Jason Gunthorpe
2023-12-05 4:40 ` Nicolin Chen
2023-11-27 16:10 ` [PATCH v2 00/19] Update SMMUv3 to the modern iommu API (part 1/3) Shameerali Kolothum Thodi
2023-11-27 17:48 ` Jason Gunthorpe
2023-12-05 3:54 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127182143.GD1165737@nvidia.com \
--to=jgg@nvidia.com \
--cc=eauger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).