From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D91BC4167B for ; Tue, 28 Nov 2023 16:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RHsa6JQvNkV7fmbfYZ5qBiGrGvPs+aO8XhAVh69Ud7U=; b=33P6cLhmxc3/Y9 6QW9N8qQ83AeIc84bTSJj0ZHyHlBD0dYNoPT6XTcjDJAYiFNzI2Kohgvrm2msc2HQmcRAlhRdZmih KRhCGb3GF9Sy3HpdPdUPXugKNP0Ro4kFhQh+Qq3qeOANvjUnQxJdM6evZwkoGpOmIIJQoVVh4PoN7 vEPyQ09LBArkfaYQs/9DxiTtdCQw1xl2MCv6NVZAtnWqXnBFKtjp3dXgtx2NHFz4PVjIv/kAR2OmS 4prxZJmciJ9bQ/UhaKC+ygJZx4LTWI/59+SOfFQSq+lv7uk0FNLBKKAfe3Du3N4zZ8Df0JvGWAgmr r3H/k4hEEQHJDXOYRIEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r80kh-005n6k-0T; Tue, 28 Nov 2023 16:15:59 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r7zeA-005cNN-2f; Tue, 28 Nov 2023 15:05:12 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Sflxq0F9pz67Kdt; Tue, 28 Nov 2023 23:00:31 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 2CE41140A9C; Tue, 28 Nov 2023 23:05:03 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 28 Nov 2023 15:05:02 +0000 Date: Tue, 28 Nov 2023 15:05:01 +0000 From: Jonathan Cameron To: Russell King CC: , , , , , , , , , , , , , Salil Mehta , Jean-Philippe Brucker , , , James Morse , Greg Kroah-Hartman , "Rafael J. Wysocki" , Paul Walmsley , "Palmer Dabbelt" , Albert Ou Subject: Re: [PATCH RFC 12/22] drivers: base: Print a warning instead of panic() when register_cpu() fails Message-ID: <20231128150501.000043b3@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231128_070511_005728_784AB32B X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 07 Nov 2023 10:30:20 +0000 Russell King wrote: > From: James Morse > > loongarch, mips, parisc, riscv and sh all print a warning if > register_cpu() returns an error. Architectures that use > GENERIC_CPU_DEVICES call panic() instead. > > Errors in this path indicate something is wrong with the firmware > description of the platform, but the kernel is able to keep running. > > Downgrade this to a warning to make it easier to debug this issue. > > This will allow architectures that switching over to GENERIC_CPU_DEVICES > to drop their warning, but keep the existing behaviour. > > Signed-off-by: James Morse > Reviewed-by: Russell King (Oracle) > Signed-off-by: Russell King (Oracle) I guess there may be paths later that were never exposed because of this panic, but any such should be fixed rather than relying on this big hammer. Reviewed-by: Jonathan Cameron _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel