From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
sukrut bellary <sukrut.bellary@gmail.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-am625-sk: Add support for WL1837 module onboard
Date: Wed, 29 Nov 2023 10:34:33 +0200 [thread overview]
Message-ID: <20231129083433.GT5169@atomide.com> (raw)
In-Reply-To: <20231123071015.is4sffvdkunko5ws@radar>
* Nishanth Menon <nm@ti.com> [231123 07:10]:
> On 14:24-20231121, Tony Lindgren wrote:
> > From: Vignesh Raghavendra <vigneshr@ti.com>
> >
> > WL1837 WLAN card is present on the original AM625 SK board. It
> > communicates with the SoC using 4 bit SDIO through the second instance of
> > MMCSD.
> >
> > Starting with SK-AM62B, there is a M.2 WLAN device connector instead of
>
> We support AM62B-SK.
Is that with k3-am62-lp-sk.dts though? Wondering if they should have separate
dts files for the M.2.
> > the integrated WL1837 WLAN. The M.2 connector should be handled separately
> > in the k3-am62a.dtsi and k3-am62b.dtsi files as needed.
>
> Should this rather be an overlay instead of integrated dts fixup? M2
> connector allows for various options including the newer 33xx family[2].
Not sure if an overlay makes sense for an integrated device.. It sure makes
sense for plug in boards though.
> It makes sense for the regulator etc to be on the main dts file, but I
> am not convinced about it being integrated as part of the dts.
Yeah if AM62B-SK is supported with the same dts. My vote would be for
separate dts files for the integrated variant to keep things simple :)
> Should we use mmc-pwrseq ?
Yes probably, I think there was some issue earlier with that but sounds like
it's been solved already.
> Looks like we have run into an issue in BeaglePlay with wlan_en
> being always on for loading firmware. so is there a need to keep the
> wlan on while suspended?
If the wlan irq was on the first gpio bank, wake-up path would work for
the wlan. But I think it's wired to a gpio bank with no wake-up capability,
and the padconf wake related patches are still pending. So no need to keep
the wlan enabled so far AFAIK.
Regards,
Tony
> [1] https://sukrutb.github.io/s2d_TI_am625-BeaglePlay/ (see towards the
> end)
> [2] https://www.ti.com/tool/M2-CC3301
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-29 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 12:24 [PATCH] arm64: dts: ti: k3-am625-sk: Add support for WL1837 module onboard Tony Lindgren
2023-11-23 7:10 ` Nishanth Menon
2023-11-29 8:34 ` Tony Lindgren [this message]
2023-12-03 14:07 ` Nishanth Menon
2023-12-04 8:38 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231129083433.GT5169@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nm@ti.com \
--cc=sukrut.bellary@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).