From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3534C4167B for ; Wed, 29 Nov 2023 21:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vaLFSBA6/bUGD7dLlq+nWPAnAnJFdBJNlAlM4WujN4A=; b=TFCN355TlbNE5Q +QxVpafxuOix9zEjdze2uSAEDud8tBrUEAigLTAoqmkZuGSYNMpKn4B2x0JApwe2a9Bga3u/wAb97 bAp0ujRfFqlvqzeHvhngjiIyJWLuo/Qi2ahFJQbfC31duYFjZfZGPFZmCf42DDiN/OH9s2IwnlAbb S32c9TdMAezYnIPNzyEmZnQqpZsnN0hRlqDnEm5an2v6oimzyACNywwBoBBKTN62NDZOF6CWANifn y2ETD3LGg/Bo9b66vTAld6uqCplq84KIXDdL3xF8UtmsVi9WI2hX84P/0B0oXFh98BNNE9m9sUi2u skYjD0MgdTahFOwvklDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8SNI-009MuJ-0t; Wed, 29 Nov 2023 21:45:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8SNG-009Mty-0A for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:45:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701294335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s3xWVWUZPbk5MGMDQz7HZH6VD2zILEgQvXP9r7AbwIo=; b=BjlOCoalbkn4jGICPqxsb8roiqjhVmlCLbZKEPtnUC1od5fig3mKiIA9djw1ofGrX9scXy Org9HuR6pwwn5vZWDZkrMV+KIwXKeHHlrvUtdhZRECqym1EPQ9h+kXyOVEb6XLsKU83pC7 VCS70UlFhfr/obzUbQjDngQAOkM0d7k= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-371-wbG0OmRFPvOueSqUnZKnng-1; Wed, 29 Nov 2023 16:45:33 -0500 X-MC-Unique: wbG0OmRFPvOueSqUnZKnng-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-58a91cf3f97so336565eaf.0 for ; Wed, 29 Nov 2023 13:45:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701294333; x=1701899133; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s3xWVWUZPbk5MGMDQz7HZH6VD2zILEgQvXP9r7AbwIo=; b=v6DrhzcmxtdOLmNCt4M1R2eNwmOE45y/ruEfBOTEfMdfIT8tnetQpWTXdHLPP1vJR2 sHd2yQZP7z66i6YOCInR+lvIzqWs2hwpgJO0jcEsMk0o+6YqvcwPOOO72tjRksydl0+z k6jCx95UShmaHl/nJL7xcwS0tVuUHep7xyQu7uEzZ/r2MhHB5iAHmfNVnoi2dStsCXfP VP7ix220okwLnfYqp0dT0GIWlWjcWdA092vbw+bRQJFOXWUN5plAwFmjBFT+9aRPN9In T/19JzagtQWqM8fGtJR8NwdcoiQB+NFFJXzWgnBDtj9oYJzKakxdEPrAn0pyF8Sg35ar z/Ug== X-Gm-Message-State: AOJu0Ywj4UqBE/CRZWMS0QcKTzMOZ0Hu4u3NHJSMMzgHs8lFMxGtU9GD PooXZhziSg004XceQALjE9j6nN77RmwuZZTIeipgch2ZVTYtIiTVVFTScNzKs8wD5wGXRd30yIz VnQs7owUlKlTdZ9Gy34gizctxWNuwbHdRAEs= X-Received: by 2002:a05:6820:513:b0:58d:6217:795e with SMTP id m19-20020a056820051300b0058d6217795emr19629085ooj.8.1701294332975; Wed, 29 Nov 2023 13:45:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IFiX/Tvc+toAwd/tY9Rv762mlPV5wQvlo/Dm5/DrBUxi70aCrX/U4468O+1d5CLlBkm80dRJw== X-Received: by 2002:a05:6820:513:b0:58d:6217:795e with SMTP id m19-20020a056820051300b0058d6217795emr19629065ooj.8.1701294332763; Wed, 29 Nov 2023 13:45:32 -0800 (PST) Received: from redhat.com ([38.15.60.12]) by smtp.gmail.com with ESMTPSA id u38-20020a4a8c29000000b0057bb326cad4sm2486047ooj.33.2023.11.29.13.45.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:45:32 -0800 (PST) Date: Wed, 29 Nov 2023 14:45:30 -0700 From: Alex Williamson To: Sean Christopherson Cc: Jason Gunthorpe , Michael Ellerman , Paolo Bonzini , Alexander Gordeev , Christian Borntraeger , Borislav Petkov , Catalin Marinas , Christophe Leroy , Dave Hansen , David Hildenbrand , Janosch Frank , Vasily Gorbik , Heiko Carstens , "H. Peter Anvin" , Claudio Imbrenda , James Morse , kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Marc Zyngier , Ingo Molnar , Nicholas Piggin , Oliver Upton , Suzuki K Poulose , Sven Schnelle , Thomas Gleixner , Will Deacon , x86@kernel.org, Zenghui Yu Subject: Re: Ping? Re: [PATCH rc] kvm: Prevent compiling virt/kvm/vfio.c unless VFIO is selected Message-ID: <20231129144530.16c18552.alex.williamson@redhat.com> In-Reply-To: References: <0-v1-08396538817d+13c5-vfio_kvm_kconfig_jgg@nvidia.com> <87edgy87ig.fsf@mail.lhotse> <20231129124821.GU436702@nvidia.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_134538_198348_8E2E4879 X-CRM114-Status: GOOD ( 20.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 29 Nov 2023 10:31:03 -0800 Sean Christopherson wrote: > On Wed, Nov 29, 2023, Jason Gunthorpe wrote: > > On Tue, Nov 28, 2023 at 06:21:42PM -0800, Sean Christopherson wrote: > > > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > > > index 454e9295970c..a65b2513f8cd 100644 > > > --- a/include/linux/vfio.h > > > +++ b/include/linux/vfio.h > > > @@ -289,16 +289,12 @@ void vfio_combine_iova_ranges(struct rb_root_cached *root, u32 cur_nodes, > > > /* > > > * External user API > > > */ > > > -#if IS_ENABLED(CONFIG_VFIO_GROUP) > > > struct iommu_group *vfio_file_iommu_group(struct file *file); > > > + > > > +#if IS_ENABLED(CONFIG_VFIO_GROUP) > > > bool vfio_file_is_group(struct file *file); > > > bool vfio_file_has_dev(struct file *file, struct vfio_device *device); > > > #else > > > -static inline struct iommu_group *vfio_file_iommu_group(struct file *file) > > > -{ > > > - return NULL; > > > -} > > > - > > > static inline bool vfio_file_is_group(struct file *file) > > > { > > > return false; > > > > > > > So you symbol get on a symbol that can never be defined? Still says to > > me the kconfig needs fixing :| > > Yeah, I completely agree, and if KVM didn't already rely on this horrific > behavior and there wasn't a more complete overhaul in-flight, I wouldn't suggest > this. > > I'll send the KVM Kconfig/Makefile cleanups from my "Hide KVM internals from others" > series separately (which is still the bulk of the series) so as to prioritize > getting the cleanups landed. > Seems we have agreement and confirmation of the fix above as an interim, do you want to post it formally and I can pick it up for v6.7-rc? Thanks, Alex _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel