From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D7CCC4167B for ; Wed, 29 Nov 2023 18:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1sDi5bevuFcIxsKqV23yxKM4phRs+tM+7T+amsMpIlo=; b=Qq8L6k2bhdky1a 2sS/ZWQeXtwpMNcMvIvTQ6mARKLAfFUtbhSKFRK+/J4Uq4q7PogFpYBd0A49MwFpoClD48rdR4VSH YRXWF/24nEw3J3Om3gItBQYGn9HpkVWMOZ7DjP4pl5+m/VgIm0LRjiicto1Otr4bEyAkHBrLrRqJf xFEczm3zFPH/w5XkO4PuxPemWhKQHvHwK4loIM6ZmOU9vYxJ7psCw3KdOG1e3gmHV/ZVvhqh6O6QG 9t8XIBzbfl8kAtLm2NqbsSy4JIW7jXPVt03Q0P13ibgdjrgqjmDfLqA0bjMEMwRAkkk7itPvZPBcw jZW34h2On6Lyg7cQZMAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8P9C-0095EP-0n; Wed, 29 Nov 2023 18:18:54 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8P98-0095Dn-2a for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 18:18:52 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a178e82a445so7580466b.2 for ; Wed, 29 Nov 2023 10:18:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701281927; x=1701886727; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+oxFI2xDlsJXdq2twNcWIhhbiyZKz5nGCnvY004qL9Y=; b=OiE1ry3qTgbOCi5UAQNhBIslmrIjEBtsm4WSg4TTwmQ9mzhdXISbBvRLCBAbsP+6cb klpCmLib0khu/ZMSLMKfGEZZGWr96RcmGg65Laa86e5at4hkNlVuUJft62w+66bVsSst SZ7AYDdAeTHTr5kGFOVc1TzOGEVgsE2G9aV4xKZ2PrFU0Y/O++BJNgiQFVvGttG4+8jl EG+3Mj/tLE0DlTdFlh1Xe/ZQfnmgjtZ4qQ+kj06A4XtWkxKIDWc/zRubsR24cpI/nzop zl9YT8lG14+uomBicFiJAMTN57ONa7pKB3GYoL1QDOpRgrmcNYEcHHSuz5dpE2n8si0s 5bAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701281927; x=1701886727; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+oxFI2xDlsJXdq2twNcWIhhbiyZKz5nGCnvY004qL9Y=; b=hhIeuep5hXd05/ykDSe3SBgS4v10gxpcQ42O3usOx3+YxFY5WW7tpKESts2sYumKVr WKs/sbdQEqlOC9kCMxs4A70rc3onMtfBRFVD4AjzyCtTH12CS/CNhrKI++07A8nPtRLI Bms33XhNfnVAPzESRmjvV6N4NwKeba/ZITJBL5FrzYkS0EFGopn5gI/biztuMouQe4OS rv9Xp6+v0GXQWnwe/gCXgYyZK0db7s+llB/HnV5mSQjLVnD/rbBAmmn2la7JiludbcRk SunJ/LNtOEC1XXk0718Xs2HlFnanXWTDoXrJSRQwuGRzvosXZnVfHFqz8pCulupWultP mZMA== X-Gm-Message-State: AOJu0YztMPTK16tnWhqHLVGyf59ml3T8Gf7h94Jgnvsi7Iv2lvYscjIa me0hAgIgbE6QqLR3n9rm9Rs= X-Google-Smtp-Source: AGHT+IGiIg549aZpIYoA3pve4OmRttOCyYE1U0jSAOSKby4WAR65DFIaa5YMrWhY6o6QqTauDVhqOw== X-Received: by 2002:a17:906:b248:b0:a04:cc0e:ff3b with SMTP id ce8-20020a170906b24800b00a04cc0eff3bmr14594160ejb.27.1701281926915; Wed, 29 Nov 2023 10:18:46 -0800 (PST) Received: from skbuf ([188.26.185.12]) by smtp.gmail.com with ESMTPSA id u25-20020a17090657d900b0098ec690e6d7sm8119082ejr.73.2023.11.29.10.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 10:18:45 -0800 (PST) Date: Wed, 29 Nov 2023 20:18:42 +0200 From: Vladimir Oltean To: Linus Walleij Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Russell King , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek =?utf-8?B?QmVow7pu?= , Christian Marangi , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Florian Fainelli Subject: Re: [PATCH net-next v8 5/9] ARM64: dts: marvell: Fix some common switch mistakes Message-ID: <20231129181842.74zihcd642lx5zgo@skbuf> References: <20231114-marvell-88e6152-wan-led-v8-0-50688741691b@linaro.org> <20231114-marvell-88e6152-wan-led-v8-5-50688741691b@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231114-marvell-88e6152-wan-led-v8-5-50688741691b@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_101850_845180_86F66FCB X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 14, 2023 at 12:36:00AM +0100, Linus Walleij wrote: > diff --git a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > index 9eab2bb22134..66cd98b67744 100644 > --- a/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > +++ b/arch/arm64/boot/dts/marvell/armada-3720-turris-mox.dts > @@ -304,7 +304,13 @@ phy1: ethernet-phy@1 { > reg = <1>; > }; > > - /* switch nodes are enabled by U-Boot if modules are present */ > + /* > + * NOTE: switch nodes are enabled by U-Boot if modules are present > + * DO NOT change this node name (switch0@10) even if it is not following > + * conventions! Deployed U-Boot binaries are explicitly looking for > + * this node in order to augment the device tree! > + * Also do not touch the "ports" or "port@n" nodes. These are also ABI. > + */ > switch0@10 { > compatible = "marvell,mv88e6190"; > reg = <0x10>; > @@ -430,6 +436,7 @@ port-sfp@a { > }; > }; > > + /* NOTE: this node name is ABI, don't change it! */ > switch0@2 { > compatible = "marvell,mv88e6085"; > reg = <0x2>; > @@ -497,6 +504,7 @@ port@5 { > }; > }; > > + /* NOTE: this node name is ABI, don't change it! */ > switch1@11 { > compatible = "marvell,mv88e6190"; > reg = <0x11>; > @@ -622,6 +630,7 @@ port-sfp@a { > }; > }; > > + /* NOTE: this node name is ABI, don't change it! */ > switch1@2 { > compatible = "marvell,mv88e6085"; > reg = <0x2>; > @@ -689,6 +698,7 @@ port@5 { > }; > }; > > + /* NOTE: this node name is ABI, don't change it! */ > switch2@12 { > compatible = "marvell,mv88e6190"; > reg = <0x12>; > @@ -805,6 +815,7 @@ port-sfp@a { > }; > }; > > + /* NOTE: this node name is ABI, don't change it! */ > switch2@2 { > compatible = "marvell,mv88e6085"; > reg = <0x2>; I wouldn't spam the device tree with all these comments; doing so gives a false sense of completeness. Code inspection shows that the "port-sfp@a" node name is also established ABI, but there isn't any explicit comment to point that out. I think a single comment that uses plural to refer to all nodes should be enough. Also, doesn't the comment go better along with the patch that changes the switch compatible strings, rather than with the patch that actually fixes what can be fixed (ethernet-phy node names)? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel