From: Conor Dooley <conor@kernel.org>
To: Thomas Richard <thomas.richard@bootlin.com>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
gregory.clement@bootlin.com, u-kumar1@ti.com
Subject: Re: [PATCH 1/5] dt-bindings: arm: keystone: add ti,j7200-sci compatible
Date: Thu, 30 Nov 2023 15:42:48 +0000 [thread overview]
Message-ID: <20231130-repugnant-aghast-0bc35af8de3c@spud> (raw)
In-Reply-To: <20231129-crawling-gaming-76077ed03c57@spud>
[-- Attachment #1.1: Type: text/plain, Size: 967 bytes --]
On Wed, Nov 29, 2023 at 03:38:04PM +0000, Conor Dooley wrote:
> On Wed, Nov 29, 2023 at 03:34:20PM +0000, Conor Dooley wrote:
> > On Wed, Nov 29, 2023 at 04:31:17PM +0100, Thomas Richard wrote:
> > > On j7200, during suspend to ram the soc is powered-off.
> > > At resume requested irqs shall be restored which is a different behavior
> > > from other platforms.
> > >
> > > Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
> >
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Un-Acked. Your dts patch contradicts this one.
>
> Is the programming model compatible with the existing devices? To be
> compatible, the existing device only need to support a compatible subset
> of behaviours.
> If so, this patch is wrong. If not, then the dts one is.
Given Andrew's response, it looks like the dts patch is the correct one
of the two, and this patch should document the k2g as a fallback for the
jh7200.
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-30 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 15:31 [PATCH 0/5] Add suspend/resume support in ti_sci driver for j7200 Thomas Richard
2023-11-29 15:31 ` [PATCH 1/5] dt-bindings: arm: keystone: add ti,j7200-sci compatible Thomas Richard
2023-11-29 15:34 ` Conor Dooley
2023-11-29 15:38 ` Conor Dooley
2023-11-30 15:42 ` Conor Dooley [this message]
2023-11-29 15:54 ` Andrew Davis
2023-12-01 7:46 ` Nishanth Menon
2023-11-29 15:31 ` [PATCH 2/5] firmware: ti_sci: add suspend/resume support for irqs Thomas Richard
2023-12-01 8:05 ` Nishanth Menon
2023-11-29 15:31 ` [PATCH 3/5] arm64: dts: ti: k3-j7200: use ti,j7200-sci compatible Thomas Richard
2023-11-29 15:35 ` Conor Dooley
2023-11-29 15:31 ` [PATCH 4/5] firmware: ti-sci: for j7200 before suspend check the reserved memory for lpm Thomas Richard
2023-11-29 15:31 ` [PATCH 5/5] arm64: dts: ti: k3-j7200: add reserved memory regions " Thomas Richard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130-repugnant-aghast-0bc35af8de3c@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=thomas.richard@bootlin.com \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox