From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E7E9C4167B for ; Thu, 30 Nov 2023 13:46:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v67/Aeh76CLgYtYseLFEHSCqyyT/lfRquxbeMWwHeqU=; b=BAgTh7v0IYUBYR FpmLCAfZ6LvLHuwtH40J/VnWjIIdor5CPLdoXtbJl5ri6Pglj01st1ChKIJWiIXbx7cAw69P/QlEx s9pRCTzETxO6Vj5PqKgqzj0FRTnRXqvfeMFteBuQljxmOGN3HwpQ+WPX8N45qctwejmD1hPTLmO0u EO+WlG05y3e+eZ/2JPg2aN1hPoFVc2ih8BPXXykIOMU0zcr7A2TI9WhwQ2NIaQ6rJzXgp8sLdyMdL JbeONIqwgUJWfqV1T/Bd42VSh1TOT76kQfqoJgf+M15BzgebRfKKEkknlnQVgnMav796c+Z16aQHy VXWFIG4rEd43gYaF2K5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8hMS-00B0Vc-1O; Thu, 30 Nov 2023 13:45:48 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8hMP-00B0Uq-1l; Thu, 30 Nov 2023 13:45:46 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C80155; Thu, 30 Nov 2023 14:45:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701351907; bh=XHpARKgcvdjeAqbtIxtvOde4zZgRWl+NFysb0Gz1TpI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ox4zOnnGPuQWmJwVUbeyvRZWzI2YNcP8mXjBQ9GlN7B45LOxdmpB75fncpTJzv6X4 bUnOrXo9MY1a/MkSyXx2fijg8PJv1AEHuNurpX+O9OyUP5kVscyupg3kUkZg+ZH2Vr /n+g0BvDG8wle0BfT+1NOcUcdBfw/HkJg85dFsNM= Date: Thu, 30 Nov 2023 15:45:50 +0200 From: Laurent Pinchart To: Paul Elder Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner , "moderated list:ARM/Rockchip SoC support" , open list Subject: Re: [PATCH 1/3] media: rkisp1: regs: Consolidate MI interrupt wrap fields Message-ID: <20231130134550.GN8402@pendragon.ideasonboard.com> References: <20231129092956.250129-1-paul.elder@ideasonboard.com> <20231129092956.250129-2-paul.elder@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231129092956.250129-2-paul.elder@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_054545_722046_011ED388 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, Thank you for the patch. On Wed, Nov 29, 2023 at 06:29:54PM +0900, Paul Elder wrote: > Consolidate the wraparound fields in the memory interface interrupt > status registers, so that it can be more succinctly expressed by taking > the stream ID (main or self) as a parameter. > > Signed-off-by: Paul Elder Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > index 350f452e676f..bea69a0d766a 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > @@ -172,12 +172,9 @@ > #define RKISP1_CIF_MI_FRAME(stream) BIT((stream)->id) > #define RKISP1_CIF_MI_MBLK_LINE BIT(2) > #define RKISP1_CIF_MI_FILL_MP_Y BIT(3) > -#define RKISP1_CIF_MI_WRAP_MP_Y BIT(4) > -#define RKISP1_CIF_MI_WRAP_MP_CB BIT(5) > -#define RKISP1_CIF_MI_WRAP_MP_CR BIT(6) > -#define RKISP1_CIF_MI_WRAP_SP_Y BIT(7) > -#define RKISP1_CIF_MI_WRAP_SP_CB BIT(8) > -#define RKISP1_CIF_MI_WRAP_SP_CR BIT(9) > +#define RKISP1_CIF_MI_WRAP_Y(stream) BIT(4 + (stream)->id * 3) > +#define RKISP1_CIF_MI_WRAP_CB(stream) BIT(5 + (stream)->id * 3) > +#define RKISP1_CIF_MI_WRAP_CR(stream) BIT(6 + (stream)->id * 3) > #define RKISP1_CIF_MI_DMA_READY BIT(11) > > /* MI_STATUS */ -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel