From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37003C4167B for ; Thu, 30 Nov 2023 14:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ITxBL/0/kosY+5kbBLJxScCWj9CoLmk/L8ITRkHuQ28=; b=vh5uhSIHAM1JOO 0Ds91Vr8quS1e5Q/ZXwaRNcte3EwVrregy58K2w4iAcmEfYURA2S43bMeEdLUXgWAzJG0DWmKIT5X FdOzR+BgwuPvMhzK7ZfP/RO5vy943XzRgZE/MMN2sxgW/n+R9ksRTa8jwXKDZmMYAaVkvEt5tqcac dxm2QOAVqTAjUv0wJ5eD4m+vmOoGKBLMtIBmj2ecR2UW9V5nCd2g80VP6RyMOJsMun9t6p8ci5s5K b/itP3aistoUdAH4hyrYVfxKwgWMkSugezPCLfoECw0wqEc3L+J9m/iBVkMYNC7r4AxS6WuGs5OxV AAj1767WZkGtqCjvFObw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8huJ-00B5IE-05; Thu, 30 Nov 2023 14:20:47 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8huG-00B5HH-19 for linux-arm-kernel@lists.infradead.org; Thu, 30 Nov 2023 14:20:46 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 176A3480; Thu, 30 Nov 2023 15:20:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701354006; bh=BDgzRT29bEhfpnn2rL/riElNd5GELCDFCsneSXbwOe0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xg/R7/Hcm7NqCs2l+PYW3KT4jnM9Sa3nEVNzYkdIhrQWW74HqHst56+636/y1dhGp aC9FlY/jZqyP6dGlxY8fZA4BbyrkkSaXGIoUV4SYXWRlce4eNtymsRtsK7ApFReu9Y pGqzwkTfHr9402IJMyrrcgBv7rusdawEsuJUkvew= Date: Thu, 30 Nov 2023 16:20:48 +0200 From: Laurent Pinchart To: Alexander Stein Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Paul Elder , kieran.bingham@ideasonboard.com, tomi.valkeinen@ideasonboard.com, umang.jain@ideasonboard.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Tim Harvey , Philippe Schenker , Marek Vasut , Gregor Herburger , Marcel Ziswiler , open list , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: Add overlays for ISP instances Message-ID: <20231130142048.GR8402@pendragon.ideasonboard.com> References: <20231129093113.255161-1-paul.elder@ideasonboard.com> <7122934.GXAFRqVoOG@steina-w> <20231129151637.GG24293@pendragon.ideasonboard.com> <5734628.DvuYhMxLoT@steina-w> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5734628.DvuYhMxLoT@steina-w> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231130_062044_533640_9FB28261 X-CRM114-Status: GOOD ( 39.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, On Thu, Nov 30, 2023 at 10:51:22AM +0100, Alexander Stein wrote: > Am Mittwoch, 29. November 2023, 16:16:37 CET schrieb Laurent Pinchart: > > On Wed, Nov 29, 2023 at 11:20:07AM +0100, Alexander Stein wrote: > > > Am Mittwoch, 29. November 2023, 10:31:13 CET schrieb Paul Elder: > > > > From: Laurent Pinchart > > > > > > > > Add two overlay to enable each ISP instance. The ISP is wired directly > > > > to the CSIS for now, bypassing the ISI completely. > > > > > > I'm not sure if this is worth adding in a separate overlay. > > > > The trouble is that, at this point, selection between the ISP and the > > ISI can only be performed through DT :-S That's why this is implemented > > as an overlay. > > I feel a better place would be the overlay which actually adds the sensor. > This knows best whether ISI or ISP should be used. Any sensor could be used with either the ISI or the ISP, so I don't think the camera module overlay would be the best place for this. Unless you want to duplicate all camera module overlays, with an ISI version and an ISP version :-) > > > > Signed-off-by: Laurent Pinchart > > > > Signed-off-by: Paul Elder > > > > --- > > > > > > > > arch/arm64/boot/dts/freescale/Makefile | 2 ++ > > > > .../arm64/boot/dts/freescale/imx8mp-isp1.dtso | 36 +++++++++++++++++++ > > > > .../arm64/boot/dts/freescale/imx8mp-isp2.dtso | 36 +++++++++++++++++++ > > > > 3 files changed, 74 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile > > > > b/arch/arm64/boot/dts/freescale/Makefile index > > > > 300049037eb0..f97dfac11189 > > > > 100644 > > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > > @@ -113,6 +113,8 @@ dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk2.dtb > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-dhcom-pdk3.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-evk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-icore-mx8mp-edimm2.2.dtb > > > > > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp1.dtbo > > > > +dtb-$(CONFIG_ARCH_MXC) += imx8mp-isp2.dtbo > > > > > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-msc-sm2s-ep1.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-phyboard-pollux-rdk.dtb > > > > dtb-$(CONFIG_ARCH_MXC) += imx8mp-tqma8mpql-mba8mpxl.dtb > > > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso new file mode 100644 > > > > index 000000000000..cf394ed224ab > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp1.dtso > > > > @@ -0,0 +1,36 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright 2022 Ideas on Board Oy > > > > + */ > > > > + > > > > +/dts-v1/; > > > > +/plugin/; > > > > + > > > > +#include > > > > + > > > > +&isi_0 { > > > > + status = "disabled"; > > > > > > ISI is disabled by default. What is your intention here? > > > > It could be enabled by an overlay for a camera module. Ideally we want > > to be able to enable both the ISI and ISP at runtime, but that's not > > possible yet and will require a very large amount of work. > > Again IMHO this is part of sensor setup, in a very specific overlay. To put it > into different words: I barely see the gain of this small overlay. > > Runtime switching would require a combined media controller including both ISI > and ISP, no? Correct, that's the hard part. > > > > + > > > > + ports { > > > > + port@0 { > > > > + /delete-node/ endpoint; > > > > > > This doesn't work in overlays. See [1]. Otherwise the OF graph connections > > > look fine to me. I'm using the same in my local overlay. > > > > Interesting, I wasn't aware of that. Maybe we should fix it :-) > > > > > [1] https://lore.kernel.org/all/CAMuHMdWu4KZbBkvEofUV2wuA1g2S=XHHM3RUN1cNrcZBkhsPZA@mail.gmail.com/ > > > > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&isp_0 { > > > > + status = "okay"; > > > > + > > > > + ports { > > > > + port@1 { > > > > + isp0_in: endpoint { > > > > + bus-type = ; > > > > + remote-endpoint = <&mipi_csi_0_out>; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&mipi_csi_0_out { > > > > + remote-endpoint = <&isp0_in>; > > > > +}; > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso new file mode 100644 > > > > index 000000000000..14e2e7b2617f > > > > --- /dev/null > > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-isp2.dtso > > > > @@ -0,0 +1,36 @@ > > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > > +/* > > > > + * Copyright 2022 Ideas on Board Oy > > > > + */ > > > > + > > > > +/dts-v1/; > > > > +/plugin/; > > > > + > > > > +#include > > > > + > > > > +&isi_0 { > > > > + status = "disabled"; > > > > + > > > > + ports { > > > > + port@1 { > > > > + /delete-node/ endpoint; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&isp_1 { > > > > + status = "okay"; > > > > + > > > > + ports { > > > > + port@1 { > > > > + isp1_in: endpoint { > > > > + bus-type = ; > > > > + remote-endpoint = <&mipi_csi_1_out>; > > > > + }; > > > > + }; > > > > + }; > > > > +}; > > > > + > > > > +&mipi_csi_1_out { > > > > + remote-endpoint = <&isp1_in>; > > > > +}; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel