From: Sudeep Holla <sudeep.holla@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_mdtipton@quicinc.com, linux-arm-kernel@lists.infradead.org,
quic_asartor@quicinc.com, quic_lingutla@quicinc.com
Subject: Re: [PATCH 2/3] firmware: arm_scmi: Fix freq/power truncation in the perf protocol
Date: Thu, 30 Nov 2023 20:14:54 +0000 [thread overview]
Message-ID: <20231130201454.jhh72rmrf6bumw2x@bogus> (raw)
In-Reply-To: <c8e1adbf-a63e-5a6f-9b4a-e68a2af67779@quicinc.com>
On Fri, Dec 01, 2023 at 01:02:25AM +0530, Sibi Sankar wrote:
>
> On 11/30/23 21:55, Cristian Marussi wrote:
> >
> > Ah right
> >
> > freq *= dom->multi_fact;
> >
> > does the trick..but cannot this by itself (under unplausibl conds)
> > overflow and does not fit into a u32 mult_factor ?
> >
> > dom_info->mult_factor =
> > (dom_info->sustained_freq_khz * 1000UL)
>
> wouldn't having the 1000UL ensure that we don't truncate though?
Correct but the point was mult_factor itself can be >= 2^32
> Anyway will drop the patch when I re-spin the series.
>
Are you re-spining just to change 24 to 32 in PATCH 3/3, if so no need.
I have already applied 1 and 3 here[1]. Just waiting for the builder
results to confirm it
--
Regards,
Sudeep
[1] https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/log/?h=for-next/scmi/updates
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-30 20:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 6:57 [PATCH 0/3] firmware: arm_scmi: Miscellaneous fixes and opp count increase Sibi Sankar
2023-11-29 6:57 ` [PATCH 1/3] firmware: arm_scmi: Fix null pointer dereference during fastchannel init Sibi Sankar
2023-11-30 12:36 ` Cristian Marussi
2023-11-29 6:57 ` [PATCH 2/3] firmware: arm_scmi: Fix freq/power truncation in the perf protocol Sibi Sankar
2023-11-30 12:05 ` Sudeep Holla
2023-11-30 12:49 ` Cristian Marussi
2023-11-30 13:56 ` Sudeep Holla
2023-11-30 16:25 ` Cristian Marussi
2023-11-30 19:32 ` Sibi Sankar
2023-11-30 20:14 ` Sudeep Holla [this message]
2023-11-30 19:51 ` Sudeep Holla
2023-11-29 6:57 ` [PATCH 3/3] firmware: arm_scmi: Increase the maximum opp count Sibi Sankar
2023-11-30 13:00 ` Cristian Marussi
2023-11-30 19:16 ` Sibi Sankar
2023-12-04 13:55 ` (subset) [PATCH 0/3] firmware: arm_scmi: Miscellaneous fixes and opp count increase Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130201454.jhh72rmrf6bumw2x@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_asartor@quicinc.com \
--cc=quic_lingutla@quicinc.com \
--cc=quic_mdtipton@quicinc.com \
--cc=quic_sibis@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox