From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1104AC47077 for ; Tue, 16 Jan 2024 16:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IbBaWWuZ7BusMrL6j9XRjhMVWtIw0mrdLN/qlXOlKAI=; b=24SiEIU1jC/G5A Tjy9/5C3rzTaIs1Pz55rV1nFKgoOKJHwhotOmas9qs5uouiptLCH2OYbtldEmeOBR5OaOnhlOnXx+ ChMhtPu7Z6ObUOLaaKlBPzJF9kArkhWupBBK0R2b+eOJv3Sjda5F8VkqJDaGOZnyMCtN9IoWdo5Ie aw0Bmo8kf0Us0e9MZr+CipOauBM41mrjX5wjSFnlrDMoUgA2hviSTKLPyzkjCMD+pC3uM0bQfxRhN BR2qj3QBCmW7qkCk0/ecQsZf1JYq7RIsnOy7XEDDgjIffaerpX3V2cob/LFAMFBwHdFcnYFJr2yjw 2hJ6RpuMxqlsQ/LovZpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPlrQ-00CWYN-0w; Tue, 16 Jan 2024 16:00:20 +0000 Received: from mx3.securetransport.de ([116.203.31.6]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPlrC-00CWQS-2j for linux-arm-kernel@lists.infradead.org; Tue, 16 Jan 2024 16:00:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dh-electronics.com; s=dhelectronicscom; t=1705420776; bh=EK7VBFYYbMk8kVgMxZTPj1kGRPSKxlDAK/5fbH1kX1c=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=jHJ4XdzEPAClJe0sDxzOefJFMXvpEQASvespCnWnasQdHKgEibs52ExZl0ym+I8Dh ES8VaUMg2zxhJ437cZcLgnbZAkzgVOdjpFGovezFvsy2B/bBXbVQqYypqk7l9Qji8z gvIN+UkMy4fQoq8BQXJn0TUE/WaH79VyQjP2RTUTKnIVrabtF8O5Y5B8NTD45MaLgQ KeWv6bqz0rehkQOE++mUgFGnSxxwlElYd5e/NXOOJ9pPjIfT+DF2Jr7V3qppyyKMgQ NIuQkc+UXOJ+gOQzpN3M64l9+JZ9/u/wxdH+G0sCvNddFpW0xiyFq1uLev8C9vPzRi x/4ahyBohQWCA== From: Christoph Niedermaier To: CC: , , , , , Subject: Re: [PATCH v6 1/2] tty: serial: Cleanup the bit shift with macro Date: Tue, 16 Jan 2024 16:58:29 +0100 Message-ID: <20231201071554.258607-2-crescentcy.hsieh@moxa.com> X-klartext: yes In-Reply-To: <20231201071554.258607-2-crescentcy.hsieh@moxa.com> References: <20231201071554.258607-2-crescentcy.hsieh@moxa.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240116_080007_200108_643CE43F X-CRM114-Status: UNSURE ( 3.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In the old definition (1 << 3) wasn't used. > -#define SER_RS485_RX_DURING_TX (1 << 4) > -#define SER_RS485_TERMINATE_BUS (1 << 5) > -#define SER_RS485_ADDRB (1 << 6) > -#define SER_RS485_ADDR_RECV (1 << 7) > -#define SER_RS485_ADDR_DEST (1 << 8) > +#define SER_RS485_ENABLED _BITUL(0) > +#define SER_RS485_RTS_ON_SEND _BITUL(1) > +#define SER_RS485_RTS_AFTER_SEND _BITUL(2) > +#define SER_RS485_RX_DURING_TX _BITUL(3) Isn't it a break if number 3 isn't skipped here as well? Regards Christoph _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel