From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38589C4167B for ; Fri, 1 Dec 2023 12:37:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KeDckPiPv37ykrwgdZST0TQvdG7waamqBPhHbrNNPb0=; b=bpRFI4qgZT8aQN id3xv506qkEv1b3E0zmrwAjZaP1RxRkNGXMPbZoD67nKRqjE3mdm1bE3QxcfkJiS5xHcRfw6cz33N orGf6vWuib81Hh5DXk+dSE8V5L0NO0Tt70EODrPoXr13dg5EPdF+Modenm/ZjcpvxpQE8PeV1CXZ0 02RoNG34OR6+ur1WsgrLWvGv+6/5mFikDTwFyxZxacjEIFGw2/TfSyI91uLlnZYAb8Ys4rmmBEELU Tkq7JbsDrIhwGqNWxOmRV6QdJHQDhKJ1S/1YsP9/VoR/bnQfi9BIZuv8V0uujdxLLJ2meu/Tio7sd XI2vM+IITpBU4+momCbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r92lr-00Da7K-2d; Fri, 01 Dec 2023 12:37:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r92lo-00Da6Z-2z for linux-arm-kernel@lists.infradead.org; Fri, 01 Dec 2023 12:37:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C0B9A1007; Fri, 1 Dec 2023 04:38:05 -0800 (PST) Received: from bogus (unknown [10.57.42.162]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C17D3F5A1; Fri, 1 Dec 2023 04:37:16 -0800 (PST) Date: Fri, 1 Dec 2023 12:35:15 +0000 From: Sudeep Holla To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, Lorenzo Pieralisi , Sudeep Holla , Mike Leach , James Clark , Maxime Coquelin , Alexandre Torgue , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH V2 1/7] coresight: replicator: Move ACPI support from AMBA driver to platform driver Message-ID: <20231201123515.gntwvhsxd5nzojn7@bogus> References: <20231201062053.1268492-1-anshuman.khandual@arm.com> <20231201062053.1268492-2-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231201062053.1268492-2-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231201_043725_032725_DBB9EE3C X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 01, 2023 at 11:50:47AM +0530, Anshuman Khandual wrote: > Add support for the dynamic replicator device in the platform driver, which > can then be used on ACPI based platforms. This change would now allow > runtime power management for repliacator devices on ACPI based systems. > > The driver would try to enable the APB clock if available. Also, rename the > code to reflect the fact that it now handles both static and dynamic > replicators. > > Cc: Lorenzo Pieralisi > Cc: Sudeep Holla Except the minor nit below which may apply also for few other patches in the series Acked-by: Sudeep Holla # For ACPI related changes Tested-by: Sudeep Holla # Boot and driver probe only [...] > diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c > index b6be73034996..64de0bee02ec 100644 > --- a/drivers/hwtracing/coresight/coresight-replicator.c > +++ b/drivers/hwtracing/coresight/coresight-replicator.c > @@ -38,6 +38,7 @@ DEFINE_CORESIGHT_DEVLIST(replicator_devs, "replicator"); > struct replicator_drvdata { > void __iomem *base; > struct clk *atclk; > + struct clk *pclk; [minor nit] Perhaps can be documented as well ? -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel