From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B6F6C4167B for ; Sun, 3 Dec 2023 11:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZRyaq+0vRUdKZoxKMxF8Nj0flAdKZHLQ1/6OmoXKDCY=; b=eaV4FjesVnG2rPp5Dszcwv+iyJ 8f2X577rBeH15A/jruPHAA64rjsIjYbGkYao/35ljsJ6er7PIbFD2FRCdgyrQ+YTwMe0Ewxd8nMwj 6uW7AWxCSpmo8rrNbEX9eWxGz+zM/1ucIECOm1IpmbqAgIW6TAga96C958Hj+Tp65YBBvbA1w1aoB PVyaLBGYDi2ek+OWr1Rwf4ti0fP8+4mdFxkoxrbQN/oazqYBEnNhgWHPJlLYNrM5S3siVsi8/vN8f vC9O5SvwVHB6LfprgB7JIRpMc+0bX8T7Eug9RqER51BDMEd+H9bL5WvgnLG91UHhMnZVK9fqMaSH8 zOxV9WuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r9kJO-00Gg08-1Z; Sun, 03 Dec 2023 11:06:58 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r9kJL-00GfzM-1r for linux-arm-kernel@lists.infradead.org; Sun, 03 Dec 2023 11:06:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id D8403B80188; Sun, 3 Dec 2023 11:06:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E26BC433C7; Sun, 3 Dec 2023 11:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701601608; bh=/5uq1CQzGZNdHIzMtVGTpLPtK/zkbFq2U4Y9E9SBsWg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rkyYSH6I1TjuHiJ74rtWQsfIJxV0uzfdA6Ob7W7X0plSVkwXYhHzzwjAd84Wrm7Ul VQjoFKEt0z1hJLkEPib7azSBcsq0lxj55L5UQd72OoeVLFD02Xrl4gxJpTFjawVDCo qkG2+w68ViEJveu426U6ni7OUMfZBX6lLunThsHeoYVR2Hqc5cXJpB9S1ZlaTJv8bX ieXDQRZ16QctF8K7P5xlMX+XcmZYoMXYQlx5z/EaKpzC6EWL25U9V1oIWNZCWtLdEe 1/VR/GoB3uv32UPgzovS19xdARxslDhhBjCyWU4mO5HesrKwN1+bVzuyyaQpxpFIpr o0rf6Ro+HWdFw== Date: Sun, 3 Dec 2023 11:06:43 +0000 From: Conor Dooley To: Stefan Wahren Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Mathias Nyman , bcm-kernel-feedback-list@broadcom.com, Cyril Brulebois , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3 1/3] dt-bindings: usb: xhci: add support for BCM2711 Message-ID: <20231203-chair-zen-afb8b280ca2f@spud> References: <20231202232217.89652-1-wahrenst@gmx.net> <20231202232217.89652-2-wahrenst@gmx.net> MIME-Version: 1.0 In-Reply-To: <20231202232217.89652-2-wahrenst@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231203_030655_908505_60EF4827 X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0626151482668496831==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0626151482668496831== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="VQSfyViANYpZgCLE" Content-Disposition: inline --VQSfyViANYpZgCLE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Dec 03, 2023 at 12:22:15AM +0100, Stefan Wahren wrote: > The xHCI IP on the BCM2711 SoC is compatible to "brcm,xhci-brcm-v2", > but also requires a power domain. So introduce a new compatible > and the specific constraints. Since the key allOf can only occur > once, merge the reference below. >=20 > Signed-off-by: Stefan Wahren Reviewed-by: Conor Dooley Cheers, Conor. > --- > .../devicetree/bindings/usb/generic-xhci.yaml | 21 ++++++++++++++++--- > 1 file changed, 18 insertions(+), 3 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/usb/generic-xhci.yaml b/Do= cumentation/devicetree/bindings/usb/generic-xhci.yaml > index 594ebb3ee432..b6e10b0a3c24 100644 > --- a/Documentation/devicetree/bindings/usb/generic-xhci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-xhci.yaml > @@ -9,9 +9,6 @@ title: USB xHCI Controller > maintainers: > - Mathias Nyman >=20 > -allOf: > - - $ref: usb-xhci.yaml# > - > properties: > compatible: > oneOf: > @@ -28,6 +25,7 @@ properties: > - description: Broadcom STB SoCs with xHCI > enum: > - brcm,xhci-brcm-v2 > + - brcm,bcm2711-xhci > - brcm,bcm7445-xhci > - description: Generic xHCI device > const: xhci-platform > @@ -49,6 +47,9 @@ properties: > - const: core > - const: reg >=20 > + power-domains: > + maxItems: 1 > + > unevaluatedProperties: false >=20 > required: > @@ -56,6 +57,20 @@ required: > - reg > - interrupts >=20 > +allOf: > + - $ref: usb-xhci.yaml# > + - if: > + properties: > + compatible: > + contains: > + const: brcm,bcm2711-xhci > + then: > + required: > + - power-domains > + else: > + properties: > + power-domains: false > + > examples: > - | > usb@f0931000 { > -- > 2.34.1 >=20 --VQSfyViANYpZgCLE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZWxhQwAKCRB4tDGHoIJi 0qf6AQCobUSsGXTH1WvP+u6hdLRn2l2UEqDOa6l6put5tg25ngD/dNggWg02qYbT V70cCDru9hnNGqh7AjNRoT99v0Zgdw0= =pn7t -----END PGP SIGNATURE----- --VQSfyViANYpZgCLE-- --===============0626151482668496831== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0626151482668496831==--