From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3ACBEC4167B for ; Mon, 4 Dec 2023 13:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Juk7jZ21yIVGKYctyj+nRFQt4fto8cCMwwcnOuQ6JoA=; b=YVS+Fjzj/FV16l /uWIJzTGAZ0JnvsAC0uFnvN3grchtssoaqFpxEEvlkWTG8+V31nkuAIssLKyXSyR3DK0ILc32P168 cBLFpty97b+DSPqgk9h8YTEEUW6bRe548iJvwq8cOq+QTCBVOJeYgaImuSU5EQQCz4nXteCAtY+lO wvXTFhAEQ39bEoRqwzeLvN5S/7mIdzhmXxRSyEe69Ri6vHeh5kzPtecpLCQILxqAc2M7KUszKWIce 7v2rSzI+n2YSLT4jTu3NcAa4Xk3fUMOaVDe6CYt0gcU3dSQ78hYrj+wOBdZtYcu39jfKvDaaAJl0q VghLfjhdnnEvuWxgBiSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA8st-004XBD-3C; Mon, 04 Dec 2023 13:21:15 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rA8sq-004X74-23 for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 13:21:14 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3B4DL3Jd094902; Mon, 4 Dec 2023 07:21:03 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1701696063; bh=viV7+lwY2a79zTnW1evrf/wrCa3w8/Eku/Dy6wR3OTU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=p3DPy0GvXCdSFjVlSuxf8i3pAs0mdUWa3Wt0hjv/8mX8Xd2/+cv6A3J/CNsotAY2w nS2S/r4bLJAGQW0X4Hzz1hjwd8D9nmMz3Tcf8XsCR728XmtSS9CZnX6GZqsCdLR+f8 rjOJ31jkgE65orrYQKBoxqMNrglPFldnyKeRSFBU= Received: from DLEE108.ent.ti.com (dlee108.ent.ti.com [157.170.170.38]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3B4DL3b3020203 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 4 Dec 2023 07:21:03 -0600 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE108.ent.ti.com (157.170.170.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 4 Dec 2023 07:21:03 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Mon, 4 Dec 2023 07:21:03 -0600 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3B4DL3Fc018616; Mon, 4 Dec 2023 07:21:03 -0600 Date: Mon, 4 Dec 2023 07:21:03 -0600 From: Nishanth Menon To: Siddharth Vadapalli CC: , , , , , , , , , , Subject: Re: [PATCH] arm64: dts: ti: k3-am654-icssg2: Enable PHY interrupts for ICSSG2 Message-ID: <20231204132103.ikkxjz3yxz3ynq6s@demystify> References: <20231120063159.539306-1-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231120063159.539306-1-s-vadapalli@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_052112_763284_9DAA28A2 X-CRM114-Status: GOOD ( 19.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12:01-20231120, Siddharth Vadapalli wrote: > Enable interrupt mode of operation of the DP83867 Ethernet PHY which is > used by ICSSG2. The DP83867 PHY driver already supports interrupt handling > for interrupts generated by the PHY. Thus, add the necessary device-tree > support to enable it. > > Since the GPIO1_87 line is muxed with EXT_REFCLK1 and SYNC1_OUT, update > the pinmux to select GPIO1_87 for routing the interrupt. > > Signed-off-by: Siddharth Vadapalli > --- > > This patch is based on linux-next tagged next-20231120. > > Regards, > Siddharth. > > arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso > index ec8cf20ca3ac..9f723592d0f4 100644 > --- a/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso > +++ b/arch/arm64/boot/dts/ti/k3-am654-icssg2.dtso > @@ -124,21 +124,34 @@ AM65X_IOPAD(0x0088, PIN_INPUT, 2) /* (AG17) PRG2_PRU0_GPO4.PRG2_RGMII1_RX_CTL */ > }; > }; > > +&main_pmx1 { > + /* Select GPIO1_87 for ICSSG2 PHY interrupt */ > + icssg2_phy_irq_pins_default: icssg2-phy-irq-default-pins { > + pinctrl-single,pins = < > + AM65X_IOPAD(0x0014, PIN_INPUT, 7) /* (A22) EXT_REFCLK1.GPIO1_87 */ > + >; > + }; > +}; > + > &icssg2_mdio { > status = "okay"; > - pinctrl-names = "default"; > - pinctrl-0 = <&icssg2_mdio_pins_default>; > + pinctrl-names = "default", "icssg2-phy-irq"; > + pinctrl-0 = <&icssg2_mdio_pins_default>, <&icssg2_phy_irq_pins_default>; why should the pins be part of mdio pinctrl instead of phy? > #address-cells = <1>; > #size-cells = <0>; > > icssg2_phy0: ethernet-phy@0 { > reg = <0>; > + interrupt-parent = <&main_gpio1>; > + interrupts = <87 0x2>; > ti,rx-internal-delay = ; > ti,fifo-depth = ; > }; > > icssg2_phy1: ethernet-phy@3 { > reg = <3>; > + interrupt-parent = <&main_gpio1>; > + interrupts = <87 0x2>; Shouldn't you be using macros for interrupt level like IRQ_TYPE_EDGE_FALLING? > ti,rx-internal-delay = ; > ti,fifo-depth = ; > }; > -- > 2.34.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel