From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A10FEC4167B for ; Mon, 4 Dec 2023 12:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UcqG2zQw1WkSxqY0sPWO6cmEM8du2PSzd/OtyWnodvw=; b=4kmyyOWN6/xDUi qbLTRNYRvfX56ldE8/QoKHNy8SjhCyJBUk6rEUPxJ0hRq4iuZ5Vy06BLgk9mOJUtISCAFIOVHTwYG huHN4x8mMOom2OcVsUL4EHMWSxdJAmDoFeCeG5KCnzv9BbE65YdEVzshdM5UkFSuE6qgkKLyikhUT Rvl/jWUbqUwg34xZOEfLS/oyTOI9GBTV1Ob7m7BBsqSGqaHzX/9NutUVGLL72p7kAWoTCEeGFyd4G QAn1xYA7ZVMnPckmnaudaKNT0Vn0pMN9GlmU4O25jb3euaiBSfqBDnTaeoG/+TwQFIJWEG76K3Etv tYpJ/u8akvvc1oyXzxmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA7xe-003wZO-2u; Mon, 04 Dec 2023 12:22:07 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rA7xa-003wVi-1e; Mon, 04 Dec 2023 12:22:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0D21B61049; Mon, 4 Dec 2023 12:22:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25AA5C433BA; Mon, 4 Dec 2023 12:22:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701692521; bh=NcAANKt1lnRvaxYqIUFqYUMHhA7/3PgO5ncSrMk9pSk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o8PKmUAZKUvlwxeNS4xMomT8R7/MVUYVoiobUamnKqtoUTu3bIb1qEBqes/PdiJNQ J+1FpJZPGSg+STyvpglw8l/ZxtjnXcsgXhTl2JWXseitoxNh0xk2CbwcqPE0zq21Oo jV067nCYDxmqJd/PAaQ7Scu+EJtOshr925tJep1U= Date: Mon, 4 Dec 2023 08:08:27 +0100 From: Greg Kroah-Hartman To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Dave Stevenson , "Ricardo B . Marliere" Subject: Re: [PATCH v2 0/2] staging: vc04_services: Use %p to log pointer Message-ID: <2023120459-irregular-cost-1785@gregkh> References: <20231128202007.489294-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231128202007.489294-1-umang.jain@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_042202_707066_6A6A779D X-CRM114-Status: GOOD ( 11.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 29, 2023 at 01:50:05AM +0530, Umang Jain wrote: > %lx is used to print the unmodified pointer address for debugging. > %p will print the hashed pointer address to avoid leaking information > about kernel memory layout to userspace. But when `no_hash_pointers` > is passed as kernel parameter, unmodified pointer address will be > printed. > > Hence, drop %lx in favour of %p. For debugging purposes, one can > easily depend on `no_hash_pointers`. > > This also solves the following smatch warnings: > service_callback() warn: argument 7 to %lx specifier is cast from pointer > service_callback() warn: argument 11 to %lx specifier is cast from pointer > service_callback() warn: argument 12 to %lx specifier is cast from pointer > service_callback() warn: argument 13 to %lx specifier is cast from pointer > vchiq_release() warn: argument 7 to %lx specifier is cast from pointer > > Changes in v2: > - Built/Rebased on top of: > [PATCH v2 0/5] staging: vc04_services: Drop custom logging > > Umang Jain (2): > staging: vc04_services: Use %p to log pointer address > staging: vc04_services: Use %p to log pointer address You have 2 different patches that do different things, yet have the identical subject lines. That needs to be fixed up before I can take them. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel