* [PATCH v2 1/3] dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles
2023-11-06 15:13 [PATCH v2 0/3] imx8qm/imx8qxp: Support for inverted PWM Alexander Stein
@ 2023-11-06 15:13 ` Alexander Stein
2023-11-06 15:39 ` Uwe Kleine-König
2023-11-06 15:13 ` [PATCH v2 2/3] arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells Alexander Stein
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Alexander Stein @ 2023-11-06 15:13 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
linux-pwm, devicetree, linux-arm-kernel
Use #pwm-cells for all i.MX variants. Only fsl,imx1-pwm does not support
inverted PWM output. Keep it the same for consistency.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
index c01dff3b7f843..a84a240a61dc1 100644
--- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
@@ -14,12 +14,10 @@ allOf:
properties:
"#pwm-cells":
- description: |
- Should be 2 for i.MX1 and 3 for i.MX27 and newer SoCs. See pwm.yaml
- in this directory for a description of the cells format.
- enum:
- - 2
- - 3
+ description:
+ The only third cell flag supported by this binding is
+ PWM_POLARITY_INVERTED. fsl,imx1-pwm does not support this flags.
+ const: 3
compatible:
oneOf:
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles
2023-11-06 15:13 ` [PATCH v2 1/3] dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles Alexander Stein
@ 2023-11-06 15:39 ` Uwe Kleine-König
2023-11-08 12:37 ` Conor Dooley
0 siblings, 1 reply; 9+ messages in thread
From: Uwe Kleine-König @ 2023-11-06 15:39 UTC (permalink / raw)
To: Alexander Stein
Cc: Thierry Reding, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Fabio Estevam, linux-pwm, devicetree,
NXP Linux Team, Pengutronix Kernel Team, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1493 bytes --]
On Mon, Nov 06, 2023 at 04:13:24PM +0100, Alexander Stein wrote:
> Use #pwm-cells for all i.MX variants. Only fsl,imx1-pwm does not support
> inverted PWM output. Keep it the same for consistency.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> index c01dff3b7f843..a84a240a61dc1 100644
> --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> @@ -14,12 +14,10 @@ allOf:
>
> properties:
> "#pwm-cells":
> - description: |
> - Should be 2 for i.MX1 and 3 for i.MX27 and newer SoCs. See pwm.yaml
> - in this directory for a description of the cells format.
> - enum:
> - - 2
> - - 3
> + description:
> + The only third cell flag supported by this binding is
> + PWM_POLARITY_INVERTED. fsl,imx1-pwm does not support this flags.
> + const: 3
You dropped the | from the description line, but with my understanding
of yaml this should be fine.
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles
2023-11-06 15:39 ` Uwe Kleine-König
@ 2023-11-08 12:37 ` Conor Dooley
0 siblings, 0 replies; 9+ messages in thread
From: Conor Dooley @ 2023-11-08 12:37 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Alexander Stein, Thierry Reding, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Fabio Estevam, linux-pwm,
devicetree, NXP Linux Team, Pengutronix Kernel Team,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1507 bytes --]
On Mon, Nov 06, 2023 at 04:39:26PM +0100, Uwe Kleine-König wrote:
> On Mon, Nov 06, 2023 at 04:13:24PM +0100, Alexander Stein wrote:
> > Use #pwm-cells for all i.MX variants. Only fsl,imx1-pwm does not support
> > inverted PWM output. Keep it the same for consistency.
> >
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> > Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 10 ++++------
> > 1 file changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > index c01dff3b7f843..a84a240a61dc1 100644
> > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> > @@ -14,12 +14,10 @@ allOf:
> >
> > properties:
> > "#pwm-cells":
> > - description: |
> > - Should be 2 for i.MX1 and 3 for i.MX27 and newer SoCs. See pwm.yaml
> > - in this directory for a description of the cells format.
> > - enum:
> > - - 2
> > - - 3
> > + description:
> > + The only third cell flag supported by this binding is
> > + PWM_POLARITY_INVERTED. fsl,imx1-pwm does not support this flags.
> > + const: 3
>
> You dropped the | from the description line, but with my understanding
> of yaml this should be fine.
Ya, it was not required there in the first place.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/3] arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells
2023-11-06 15:13 [PATCH v2 0/3] imx8qm/imx8qxp: Support for inverted PWM Alexander Stein
2023-11-06 15:13 ` [PATCH v2 1/3] dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles Alexander Stein
@ 2023-11-06 15:13 ` Alexander Stein
2023-12-05 12:32 ` Shawn Guo
2023-11-06 15:13 ` [PATCH v2 3/3] arm64: dts: freescale: imx8-ss-dma: " Alexander Stein
2023-11-14 11:39 ` [PATCH v2 0/3] imx8qm/imx8qxp: Support for inverted PWM Uwe Kleine-König
3 siblings, 1 reply; 9+ messages in thread
From: Alexander Stein @ 2023-11-06 15:13 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
linux-pwm, devicetree, linux-arm-kernel
i.MX8QM/QXP supports inverted PWM output, thus #pwm-cells needs to be set
to 3.
Fixes: a05c329644d81 ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi
index 49ad3413db948..7e510b21bbac5 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi
@@ -29,7 +29,7 @@ lsio_pwm0: pwm@5d000000 {
<&pwm0_lpcg 1>;
assigned-clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>;
assigned-clock-rates = <24000000>;
- #pwm-cells = <2>;
+ #pwm-cells = <3>;
interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
@@ -42,7 +42,7 @@ lsio_pwm1: pwm@5d010000 {
<&pwm1_lpcg 1>;
assigned-clocks = <&clk IMX_SC_R_PWM_1 IMX_SC_PM_CLK_PER>;
assigned-clock-rates = <24000000>;
- #pwm-cells = <2>;
+ #pwm-cells = <3>;
interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
@@ -55,7 +55,7 @@ lsio_pwm2: pwm@5d020000 {
<&pwm2_lpcg 1>;
assigned-clocks = <&clk IMX_SC_R_PWM_2 IMX_SC_PM_CLK_PER>;
assigned-clock-rates = <24000000>;
- #pwm-cells = <2>;
+ #pwm-cells = <3>;
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
@@ -68,7 +68,7 @@ lsio_pwm3: pwm@5d030000 {
<&pwm3_lpcg 1>;
assigned-clocks = <&clk IMX_SC_R_PWM_3 IMX_SC_PM_CLK_PER>;
assigned-clock-rates = <24000000>;
- #pwm-cells = <2>;
+ #pwm-cells = <3>;
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 2/3] arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells
2023-11-06 15:13 ` [PATCH v2 2/3] arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells Alexander Stein
@ 2023-12-05 12:32 ` Shawn Guo
0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2023-12-05 12:32 UTC (permalink / raw)
To: Alexander Stein
Cc: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Sascha Hauer, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, linux-pwm, devicetree,
linux-arm-kernel
On Mon, Nov 06, 2023 at 04:13:25PM +0100, Alexander Stein wrote:
> i.MX8QM/QXP supports inverted PWM output, thus #pwm-cells needs to be set
> to 3.
>
> Fixes: a05c329644d81 ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] arm64: dts: freescale: imx8-ss-dma: Fix #pwm-cells
2023-11-06 15:13 [PATCH v2 0/3] imx8qm/imx8qxp: Support for inverted PWM Alexander Stein
2023-11-06 15:13 ` [PATCH v2 1/3] dt-bindings: pwm: imx-pwm: Unify #pwm-cells for all compatibles Alexander Stein
2023-11-06 15:13 ` [PATCH v2 2/3] arm64: dts: freescale: imx8-ss-lsio: Fix #pwm-cells Alexander Stein
@ 2023-11-06 15:13 ` Alexander Stein
2023-12-05 12:32 ` Shawn Guo
2023-11-14 11:39 ` [PATCH v2 0/3] imx8qm/imx8qxp: Support for inverted PWM Uwe Kleine-König
3 siblings, 1 reply; 9+ messages in thread
From: Alexander Stein @ 2023-11-06 15:13 UTC (permalink / raw)
To: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Fabio Estevam
Cc: Alexander Stein, Pengutronix Kernel Team, NXP Linux Team,
linux-pwm, devicetree, linux-arm-kernel
i.MX8QXP supports inverted PWM output, thus #pwm-cells needs to be set
to 3.
Fixes: f1d6a6b991ef9 ("arm64: dts: imx8qxp: add adma_pwm in adma")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
index ce66d30a4839b..b0bb77150adcc 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi
@@ -149,7 +149,7 @@ adma_pwm: pwm@5a190000 {
clock-names = "ipg", "per";
assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>;
assigned-clock-rates = <24000000>;
- #pwm-cells = <2>;
+ #pwm-cells = <3>;
power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>;
};
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2 3/3] arm64: dts: freescale: imx8-ss-dma: Fix #pwm-cells
2023-11-06 15:13 ` [PATCH v2 3/3] arm64: dts: freescale: imx8-ss-dma: " Alexander Stein
@ 2023-12-05 12:32 ` Shawn Guo
0 siblings, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2023-12-05 12:32 UTC (permalink / raw)
To: Alexander Stein
Cc: Thierry Reding, Uwe Kleine-König, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Sascha Hauer, Fabio Estevam,
Pengutronix Kernel Team, NXP Linux Team, linux-pwm, devicetree,
linux-arm-kernel
On Mon, Nov 06, 2023 at 04:13:26PM +0100, Alexander Stein wrote:
> i.MX8QXP supports inverted PWM output, thus #pwm-cells needs to be set
> to 3.
>
> Fixes: f1d6a6b991ef9 ("arm64: dts: imx8qxp: add adma_pwm in adma")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 0/3] imx8qm/imx8qxp: Support for inverted PWM
2023-11-06 15:13 [PATCH v2 0/3] imx8qm/imx8qxp: Support for inverted PWM Alexander Stein
` (2 preceding siblings ...)
2023-11-06 15:13 ` [PATCH v2 3/3] arm64: dts: freescale: imx8-ss-dma: " Alexander Stein
@ 2023-11-14 11:39 ` Uwe Kleine-König
3 siblings, 0 replies; 9+ messages in thread
From: Uwe Kleine-König @ 2023-11-14 11:39 UTC (permalink / raw)
To: Alexander Stein, Thierry Reding, Shawn Guo
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Sascha Hauer,
Fabio Estevam, linux-pwm, devicetree, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 898 bytes --]
On Mon, Nov 06, 2023 at 04:13:23PM +0100, Alexander Stein wrote:
> this small series adds support for inverted PWM output i.MX8QM/QXP.
> Driver is already there, but #pwm-cells needs to be adjusted in DT.
> While at it, enforce the same #pwm-cells value for all compatibles.
> [...]
> Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 10 ++++------
> arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 +-
> arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 8 ++++----
> 3 files changed, 9 insertions(+), 11 deletions(-)
What is the merge plan here? pwm or imx? For me both options are fine,
given this only touches bindings and arch/arm64, maybe it's more
suitable to be merged by Shawn?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread