From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFB26C4167B for ; Tue, 5 Dec 2023 15:20:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i5SnBzqHTIrpUW83BjpNLcbKsUY8bgSJYqob0iFV9HA=; b=mQ+CNWCcf70FE+ dOHmIq9vWefDh6FJH9UoMrM2x/l0E8zrS8DQJoGARY+n5GDIEvGOKlUvIxp+EXvCRHN/C1RmCkPfu x9I0iiBRYFnMlrgK1csdTcZU1qD00sz2kg5umZZdMDuXAJAMaCQQGF2HG3DL0BZoDHgxxwQj/e4+4 7lY9lIEUpVakNqjywQEHkFoAvKKAmBrK61Z+TmmxHilk9x5EFFdq24Em9WMF3V4nEOMCUVUNpB05p MPakFhnijiaFN8vqcJ1LySInPYy1tb9UU3HK081+RA54Htss3OD89bxSXi9Y+jx/OctvlOKnDCi2m EwbK7/MxWDSxSgOSeu4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAXCw-007iPi-31; Tue, 05 Dec 2023 15:19:34 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAXCt-007iOP-26 for linux-arm-kernel@lists.infradead.org; Tue, 05 Dec 2023 15:19:33 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 3B5FJL4I111898; Tue, 5 Dec 2023 09:19:21 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1701789561; bh=taSSSLzsFEyMw97vXil/IpA9bfrEDvDHwDlD5KErnEI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=VmSXmc5OWCkNPPwWTjDdF5lholG6w4iBDvKIBIJLlPY7P4IipVPnpzBJ+eB9002aL IOYqeQtCeXYOMmQH/98H/8/9qeXDv+tD5tF67+McXCd8iO8cqYZwY9MuyN13KzLYzv GMsg4VTpkBLBMAsW9KDqNza9TDoZvcjagfcrUSEU= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 3B5FJLGt025895 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 5 Dec 2023 09:19:21 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 5 Dec 2023 09:19:21 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 5 Dec 2023 09:19:21 -0600 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 3B5FJLhj083541; Tue, 5 Dec 2023 09:19:21 -0600 Date: Tue, 5 Dec 2023 09:19:21 -0600 From: Nishanth Menon To: "Sverdlin, Alexander" CC: "linux-arm-kernel@lists.infradead.org" , "donald.robson@imgtec.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "sarah.walker@imgtec.com" , "kristo@kernel.org" , "vigneshr@ti.com" , "conor+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "mripard@kernel.org" , "robh+dt@kernel.org" Subject: Re: [PATCH] arm64: dts: ti: k3-am62-main: Add GPU device node Message-ID: <20231205151921.orba632qpuf2nmxf@wildness> References: <20231204121522.47862-1-donald.robson@imgtec.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231205_071931_768615_549425F0 X-CRM114-Status: GOOD ( 20.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11:15-20231205, Sverdlin, Alexander wrote: > Hi Donald, Sarah et al, > = > thanks for the patch! > = > On Mon, 2023-12-04 at 12:15 +0000, Donald Robson wrote: > > From: Sarah Walker > > = > > Add the Series AXE GPU node to the AM62 device tree. > > = > > Signed-off-by: Sarah Walker > > Signed-off-by: Donald Robson > = > powervr fd00000.gpu: [drm] loaded firmware powervr/rogue_33.15.11.3_v1.fw > powervr fd00000.gpu: [drm] FW version v1.0 (build 6503725 OS) > [drm] Initialized powervr 1.0.0 20230904 for fd00000.gpu on minor 0 > = > In general it allows the driver to be probed on TI AM625 EK, so > Tested-by: Alexander Sverdlin > = > But I'm not sure if you maybe want to disable it by default like > other HW blocks for the (potential) boards which don't have video at all. There is no board level dependency for GPU, so only place we have permitted status =3D "disabled" is when the node has specific board interface level (pinmux...) to be operational completely. So, no, default shouldn't have a status =3D "disabled". > = > > --- > > =A0arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 9 +++++++++ > > =A01 file changed, 9 insertions(+) > > = > > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot= /dts/ti/k3-am62-main.dtsi > > index e5c64c86d1d5..4338fd8ab2d7 100644 > > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi > > @@ -965,4 +965,13 @@ mcasp2: audio-controller@2b20000 { > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0power-domains =3D <&k3_= pds 192 TI_SCI_PD_EXCLUSIVE>; > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0status =3D "disabled"; > > =A0=A0=A0=A0=A0=A0=A0=A0}; > > + > > +=A0=A0=A0=A0=A0=A0=A0gpu: gpu@fd00000 { > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0compatible =3D "ti,am62-g= pu", "img,img-axe"; > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0reg =3D <0x00 0x0fd00000 = 0x00 0x20000>; > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0clocks =3D <&k3_clks 187 = 0>; > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0clock-names =3D "core"; > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0interrupts =3D ; > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0power-domains =3D <&k3_pd= s 187 TI_SCI_PD_EXCLUSIVE>; > > +=A0=A0=A0=A0=A0=A0=A0}; > > =A0}; > = > -- = > Alexander Sverdlin > Siemens AG > www.siemens.com -- = Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5= 849D 1736 249D _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel