From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C10E6C4167B for ; Tue, 5 Dec 2023 17:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7PBxfVwX8kesdna5LUCBFG0MEKN1ltCPDOP5ki3a8NY=; b=l2eMsh2UAvuwHc PaIM5nHhxEbBXwAozpXKraVP8gqQ2UA7td2NqlESJWaa3racTCPvjb0/jZnqWDwy37D5WJYKlSFlr FB9FBZp/+WrFKtPEmb4V+DrAlREVntXAK73YdovKdJAo9r9KBdTgWnT2bhhY+lE/e26GZY5guP3Qf h/r/heyxw3TDPDh8STTJCrvgD3GyJziraLaZpkJIIqhu/4A0S5A1hdMFy1UP8RQp+a0zR8GwhxwD3 Ezs4rqDsf9309Uqkt+5O/r6KozfZC3UM3Z1Ll7e2JQ7aO+LdC21wdQc8gv7oO0ztYsvYGoPqhOtej ZRAhC48TNcwjrTzlkzRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAZY1-0084cs-2x; Tue, 05 Dec 2023 17:49:29 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAZXz-0084cQ-0U for linux-arm-kernel@lists.infradead.org; Tue, 05 Dec 2023 17:49:28 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id C5D87CE19F3; Tue, 5 Dec 2023 17:49:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BFFF7C433C8; Tue, 5 Dec 2023 17:49:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701798562; bh=PK2vCfbXtlwtD+G6evFibgNJ248BLr3rSJX0bTPzSv4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XczyRqP6XKk6NmwbJAiVw8qzZu2d15u9Y09nPMYtc3MduPMmAykmqW3+ZS+qy6Yjx /MYoHPl5JF1ouJeyiIYi706tyo897WWZflqBQ34K+eEdhKmRv2UzRmwb74gsx4JkpV RnINHJ9HbLwdR29PK6kBjm+Bh5DSlfnQF0F7VBDyUJBq8WEKRUs84atW0O8vlN8wTl TLK8zVwi0imtvTiU45lOcaWP1hVr456Z7nuOXMHadBNsBxnbzxqsQWVO2rSApFL4M0 Fofzqb6w6siEK+UXnKqReA+PL90tB4HRZYp3LaTAkkKCQjfpNEAAFElxrdwviZDuxA iSbtZe7XAt5Dw== Date: Tue, 5 Dec 2023 10:49:19 -0700 From: Nathan Chancellor To: sre@kernel.org Subject: Re: [PATCH] power: reset: at91: Drop '__init' from at91_wakeup_status() Message-ID: <20231205174919.GA535965@dev-arch.thelio-3990X> References: <20231120-fix-at91-modpost-warnings-v1-1-813671933863@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231120-fix-at91-modpost-warnings-v1-1-813671933863@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231205_094927_412269_55529723 X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-pm@vger.kernel.org, llvm@lists.linux.dev, claudiu.beznea@tuxon.dev, u.kleine-koenig@pengutronix.de, patches@lists.linux.dev, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Ping? I still see these warnings in next-20231205. On Mon, Nov 20, 2023 at 03:35:32PM -0700, Nathan Chancellor wrote: > When building with clang, there are two section mismatch warnings: > > WARNING: modpost: vmlinux: section mismatch in reference: at91_poweroff_probe+0x7c (section: .text) -> at91_wakeup_status (section: .init.text) > WARNING: modpost: vmlinux: section mismatch in reference: at91_shdwc_probe+0xcc (section: .text) -> at91_wakeup_status (section: .init.text) > > Drop '__init' from at91_wakeup_status() to clear up the mismatch. > > Fixes: dde74a5de817 ("power: reset: at91-sama5d2_shdwc: Stop using module_platform_driver_probe()") > Fixes: 099806de68b7 ("power: reset: at91-poweroff: Stop using module_platform_driver_probe()") > Signed-off-by: Nathan Chancellor > --- > I suspect this is not visible for GCC due to inlining > at91_wakeup_status() but I did not actually check. > --- > drivers/power/reset/at91-poweroff.c | 2 +- > drivers/power/reset/at91-sama5d2_shdwc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c > index 126e774e210c..93eece027865 100644 > --- a/drivers/power/reset/at91-poweroff.c > +++ b/drivers/power/reset/at91-poweroff.c > @@ -57,7 +57,7 @@ static struct shdwc { > void __iomem *mpddrc_base; > } at91_shdwc; > > -static void __init at91_wakeup_status(struct platform_device *pdev) > +static void at91_wakeup_status(struct platform_device *pdev) > { > const char *reason; > u32 reg = readl(at91_shdwc.shdwc_base + AT91_SHDW_SR); > diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c > index af95c7b39cb3..959ce0dbe91d 100644 > --- a/drivers/power/reset/at91-sama5d2_shdwc.c > +++ b/drivers/power/reset/at91-sama5d2_shdwc.c > @@ -107,7 +107,7 @@ static const unsigned long long sdwc_dbc_period[] = { > 0, 3, 32, 512, 4096, 32768, > }; > > -static void __init at91_wakeup_status(struct platform_device *pdev) > +static void at91_wakeup_status(struct platform_device *pdev) > { > struct shdwc *shdw = platform_get_drvdata(pdev); > const struct reg_config *rcfg = shdw->rcfg; > > --- > base-commit: b55d073e6501dc6077edaa945a6dad8ac5c8bbab > change-id: 20231120-fix-at91-modpost-warnings-beabd2bac722 > > Best regards, > -- > Nathan Chancellor > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel