* Re: [PATCH] ARM: dts: imx28-xea: Pass the 'model' property
2023-12-05 13:27 [PATCH] ARM: dts: imx28-xea: Pass the 'model' property Fabio Estevam
@ 2023-12-05 19:03 ` Stefan Wahren
2023-12-06 3:20 ` Shawn Guo
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Stefan Wahren @ 2023-12-05 19:03 UTC (permalink / raw)
To: linux-arm-kernel
Hi Fabio,
Am 05.12.23 um 14:27 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> Per root-node.yaml, 'model' is a required property.
>
> Pass it to fix the following dt-schema warning:
>
> imx28-xea.dtb: /: 'model' is a required property
> from schema $id: http://devicetree.org/schemas/root-node.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
i would consider this as a fix because every board file should have a
model, which is helpful for debugging.
Fixes: 445ae16ac1c5 ("ARM: dts: imx28: Add DTS description of imx28
based XEA board")
> ---
> arch/arm/boot/dts/nxp/mxs/imx28-xea.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> index a400c108f66a..cc54a0390f8c 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> +++ b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> @@ -8,6 +8,7 @@
> #include "imx28-lwe.dtsi"
>
> / {
> + model = "Liebherr Xea board";
s/Xea/XEA
Thanks
> compatible = "lwn,imx28-xea", "fsl,imx28";
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx28-xea: Pass the 'model' property
2023-12-05 13:27 [PATCH] ARM: dts: imx28-xea: Pass the 'model' property Fabio Estevam
2023-12-05 19:03 ` Stefan Wahren
@ 2023-12-06 3:20 ` Shawn Guo
2023-12-06 7:00 ` Stefan Wahren
2023-12-06 9:33 ` Lukasz Majewski
3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2023-12-06 3:20 UTC (permalink / raw)
To: Fabio Estevam; +Cc: lukma, linux-arm-kernel, Fabio Estevam
On Tue, Dec 05, 2023 at 10:27:35AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Per root-node.yaml, 'model' is a required property.
>
> Pass it to fix the following dt-schema warning:
>
> imx28-xea.dtb: /: 'model' is a required property
> from schema $id: http://devicetree.org/schemas/root-node.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx28-xea: Pass the 'model' property
2023-12-05 13:27 [PATCH] ARM: dts: imx28-xea: Pass the 'model' property Fabio Estevam
2023-12-05 19:03 ` Stefan Wahren
2023-12-06 3:20 ` Shawn Guo
@ 2023-12-06 7:00 ` Stefan Wahren
2023-12-06 9:26 ` Shawn Guo
2023-12-06 9:33 ` Lukasz Majewski
3 siblings, 1 reply; 6+ messages in thread
From: Stefan Wahren @ 2023-12-06 7:00 UTC (permalink / raw)
To: Fabio Estevam, shawnguo; +Cc: lukma, linux-arm-kernel, Fabio Estevam
Hi,
sorry i replied just to the list last time :-(
Am 05.12.23 um 14:27 schrieb Fabio Estevam:
> From: Fabio Estevam <festevam@denx.de>
>
> Per root-node.yaml, 'model' is a required property.
>
> Pass it to fix the following dt-schema warning:
>
> imx28-xea.dtb: /: 'model' is a required property
> from schema $id: http://devicetree.org/schemas/root-node.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
i would consider this as a fix because every board file should have a
model, which is helpful for debugging.
Fixes: 445ae16ac1c5 ("ARM: dts: imx28: Add DTS description of imx28
based XEA board")
> ---
> arch/arm/boot/dts/nxp/mxs/imx28-xea.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> index a400c108f66a..cc54a0390f8c 100644
> --- a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> +++ b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> @@ -8,6 +8,7 @@
> #include "imx28-lwe.dtsi"
>
> / {
> + model = "Liebherr Xea board";
s/Xea/XEA
Thanks
> compatible = "lwn,imx28-xea", "fsl,imx28";
> };
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx28-xea: Pass the 'model' property
2023-12-06 7:00 ` Stefan Wahren
@ 2023-12-06 9:26 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2023-12-06 9:26 UTC (permalink / raw)
To: Stefan Wahren; +Cc: Fabio Estevam, lukma, linux-arm-kernel, Fabio Estevam
On Wed, Dec 06, 2023 at 08:00:26AM +0100, Stefan Wahren wrote:
> Hi,
>
> sorry i replied just to the list last time :-(
>
> Am 05.12.23 um 14:27 schrieb Fabio Estevam:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > Per root-node.yaml, 'model' is a required property.
> >
> > Pass it to fix the following dt-schema warning:
> >
> > imx28-xea.dtb: /: 'model' is a required property
> > from schema $id: http://devicetree.org/schemas/root-node.yaml#
> >
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
> i would consider this as a fix because every board file should have a
> model, which is helpful for debugging.
>
> Fixes: 445ae16ac1c5 ("ARM: dts: imx28: Add DTS description of imx28
> based XEA board")
Ok, I added it.
> > ---
> > arch/arm/boot/dts/nxp/mxs/imx28-xea.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> > index a400c108f66a..cc54a0390f8c 100644
> > --- a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> > +++ b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> > @@ -8,6 +8,7 @@
> > #include "imx28-lwe.dtsi"
> >
> > / {
> > + model = "Liebherr Xea board";
> s/Xea/XEA
Fixed it up.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx28-xea: Pass the 'model' property
2023-12-05 13:27 [PATCH] ARM: dts: imx28-xea: Pass the 'model' property Fabio Estevam
` (2 preceding siblings ...)
2023-12-06 7:00 ` Stefan Wahren
@ 2023-12-06 9:33 ` Lukasz Majewski
3 siblings, 0 replies; 6+ messages in thread
From: Lukasz Majewski @ 2023-12-06 9:33 UTC (permalink / raw)
To: Fabio Estevam; +Cc: shawnguo, linux-arm-kernel, Fabio Estevam
[-- Attachment #1.1: Type: text/plain, Size: 1215 bytes --]
On Tue, 5 Dec 2023 10:27:35 -0300
Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Per root-node.yaml, 'model' is a required property.
>
> Pass it to fix the following dt-schema warning:
>
> imx28-xea.dtb: /: 'model' is a required property
> from schema $id: http://devicetree.org/schemas/root-node.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm/boot/dts/nxp/mxs/imx28-xea.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts index
> a400c108f66a..cc54a0390f8c 100644 ---
> a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts +++
> b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts @@ -8,6 +8,7 @@
> #include "imx28-lwe.dtsi"
>
> / {
> + model = "Liebherr Xea board";
> compatible = "lwn,imx28-xea", "fsl,imx28";
> };
>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread