From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Fabio Estevam <festevam@gmail.com>,
lukma@denx.de, linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] ARM: dts: imx28-xea: Pass the 'model' property
Date: Wed, 6 Dec 2023 17:26:00 +0800 [thread overview]
Message-ID: <20231206092600.GD270430@dragon> (raw)
In-Reply-To: <88a045f5-a18d-424a-811e-10f095ca151e@gmx.net>
On Wed, Dec 06, 2023 at 08:00:26AM +0100, Stefan Wahren wrote:
> Hi,
>
> sorry i replied just to the list last time :-(
>
> Am 05.12.23 um 14:27 schrieb Fabio Estevam:
> > From: Fabio Estevam <festevam@denx.de>
> >
> > Per root-node.yaml, 'model' is a required property.
> >
> > Pass it to fix the following dt-schema warning:
> >
> > imx28-xea.dtb: /: 'model' is a required property
> > from schema $id: http://devicetree.org/schemas/root-node.yaml#
> >
> > Signed-off-by: Fabio Estevam <festevam@denx.de>
> i would consider this as a fix because every board file should have a
> model, which is helpful for debugging.
>
> Fixes: 445ae16ac1c5 ("ARM: dts: imx28: Add DTS description of imx28
> based XEA board")
Ok, I added it.
> > ---
> > arch/arm/boot/dts/nxp/mxs/imx28-xea.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> > index a400c108f66a..cc54a0390f8c 100644
> > --- a/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> > +++ b/arch/arm/boot/dts/nxp/mxs/imx28-xea.dts
> > @@ -8,6 +8,7 @@
> > #include "imx28-lwe.dtsi"
> >
> > / {
> > + model = "Liebherr Xea board";
> s/Xea/XEA
Fixed it up.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-06 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 13:27 [PATCH] ARM: dts: imx28-xea: Pass the 'model' property Fabio Estevam
2023-12-05 19:03 ` Stefan Wahren
2023-12-06 3:20 ` Shawn Guo
2023-12-06 7:00 ` Stefan Wahren
2023-12-06 9:26 ` Shawn Guo [this message]
2023-12-06 9:33 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206092600.GD270430@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lukma@denx.de \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).