Re: [PATCH v2 03/12] KVM: arm64: Add latest HFGITR_EL2 FGT entries to nested virt

Mark Brown
2023-12-07T17:15:03Z

[-- Attachment #1.1: Type: text/plain, Size: 928 bytes --]

On Wed, Dec 06, 2023 at 10:04:53AM +0000, Fuad Tabba wrote:

> Add the missing nested virt FGT table entries HFGITR_EL2. Based
> on the 2023-09 Arm Architecture System Registers xml
> specification [*]. Add the missing field definitions as well,
> both to generate the correct RES0 mask and to be able to toggle
> their FGT bits.
>
> Also adds definitions of some of the missing system registers and
> instructions, which can be trapped by the FGT bits.
>
> [*] https://developer.arm.com/downloads/-/exploration-tools

That should be a reference to DDI0602 (for the instruction XML) and
DD0601 (for the system register XML) - it's the same content, just a
more stable name.

> Sysreg HFGITR_EL2 3 4 1 1 6
> -Res0 63:61
> +Res0 63
> +Field 62 ATS1E1A
> +Res0 61
> Field 60 COSPRCTX
> Field 59 nGCSEPP
> Field 58 nGCSSTR_EL1

The sysreg looks good:

Reviewed-by: Mark Brown <broonie@kernel.org>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]