Re: [PATCH v2 01/12] KVM: Add missing HCRX_EL2 field definitions

Mark Brown
2023-12-07T16:58:16Z

[-- Attachment #1.1: Type: text/plain, Size: 1195 bytes --]

On Wed, Dec 06, 2023 at 10:04:51AM +0000, Fuad Tabba wrote:
> Add the latest field definitions to HCRX_EL2 from the 2023-09 Arm
> Architecture System Registers xml specification [*].
>
> These fields aren't used yet. This is done mainly to get the
> correct generated value for the register's RES0 mask.

> ---
> arch/arm64/tools/sysreg | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

This isn't a KVM specific patch, this is an arch patch - I'd have
expected a subject line "arm64/sysreg:" or something...

> Sysreg HCRX_EL2 3 4 1 2 2
> -Res0 63:23
> +Res0 63:25
> +Field 24 PACMEn
> +Field 23 EnFPM
> Field 22 GCSEn
> Field 21 EnIDCP128
> Field 20 EnSDERR

This is the same as my equivalent patch in the 2023 dpISA series:

https://lore.kernel.org/linux-arm-kernel/20231205-arm64-2023-dpisa-v3-7-dbcbcd867a7f@kernel.org/

Reviewed-by: Mark Brown <broonie@kernel.org>

(that series does make use of EnFPM). Given the likelyhood of overlaps
like this I really think we should be merging these sysreg updates even
if the serieses that depend on them are still in flight, it doesn't make
sense for multiple people to end up doing the typing.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]