From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9262C4167B for ; Wed, 6 Dec 2023 16:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=Xr4FA28lL73deKXc5eLS04Qsm1mO3d+0ow5/wov2Gfo=; b=PMI9AAG3FDEDKb LJWEDWg59UiCmGWr3/LyXoMS25ILxw0igOIRhT+ukiJXpzjQnwGVwm9hss35sROQpq09oHg17NqHb bap4lMgKwWdZnOQHf8eCrkDAzPEsR079AYaQTd/fmoTefef8zsLfruFfgmRkvIAoUsozxpYSdSD7F 06Kla4T3v8zzfePhv+aazIyDm/fdfiALqXyf2X/OZSv2oBblT9CzRCBOiq/wT6yq4Zv2Ec8H1pFsA uBzGksymo24aQYgtr1Cri4a8d5uk23AgFvNTd0Pplz4jXdcpUu3cezVQ8FotPQuRkW9MmgNxGUt+V LqeZi9I1KZIpxijePa2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAutT-00AmO3-2N; Wed, 06 Dec 2023 16:37:03 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAutR-00AmNC-0x for linux-arm-kernel@lists.infradead.org; Wed, 06 Dec 2023 16:37:02 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id DB650B822ED; Wed, 6 Dec 2023 16:36:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13909C433C7; Wed, 6 Dec 2023 16:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701880618; bh=PAw5s5SpAWe3wAZR6pYxGYEQ6qttc4q+gC0fJiypNJ8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=j5IdAlbsgiy+9Txp0nN0TqkTvpiW+CTXnI9lNDq++3fi3am94Qs2X/n+KzrkyejEp yDvNGm/oI60UmMVRny3sU/H6xkSt4cIBVj1l8g5W98y7SaAdGoaPRMdMr9UyLBbg7T VW+SLXgIxPyGK67PpZOX8ya4roe4chlVe9T243OyDUPZb+qrSBt5fvq+INI0AR7XQf 7X8zr5NSo44LOxHlEOlyvV0q1JNSRIGCqVNaTb4f2z1tabYGYxBmMXxErw5ChNto9O 4ijFzVuxjeGg8ZQNtgmJo4ysKf/sGsgin0Bm5BIGQ9K9HoF5EdYt8NyG/9C3NApun2 GNhIGKz2TJHNQ== Date: Wed, 6 Dec 2023 10:36:56 -0600 From: Bjorn Helgaas To: Frank Li Cc: imx@lists.linux.dev, Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "open list:PCI DRIVER FOR IMX6" , "moderated list:PCI DRIVER FOR IMX6" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH 4/9] PCI: imx6: Using "linux,pci-domain" as slot ID Message-ID: <20231206163656.GA717052@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231206155903.566194-5-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_083701_502276_8E3C63EA X-CRM114-Status: GOOD ( 18.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In subject, maybe you mean "Use 'linux,pci-domain' as slot ID"? "Using" is the wrong verb form here. On Wed, Dec 06, 2023 at 10:58:58AM -0500, Frank Li wrote: > Avoid use get slot id by compared with register physical address. If there > are more than 2 slots, compared logic will become complex. But this doesn't say anything about "linux,pci-domain", and I don't see anything about a register physical address in the patch. Maybe this commit log was meant for a different patch? I'm confused. > Signed-off-by: Frank Li > --- > drivers/pci/controller/dwc/pci-imx6.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 62d77fabd82a..239ef439ba70 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -33,6 +33,7 @@ > #include > #include > > +#include "../../pci.h" > #include "pcie-designware.h" > > #define IMX8MQ_GPR_PCIE_REF_USE_PAD BIT(9) > @@ -1333,6 +1334,11 @@ static int imx6_pcie_probe(struct platform_device *pdev) > "Failed to get PCIEPHY reset control\n"); > } > > + /* Using linux,pci-domain as PCI slot id */ > + imx6_pcie->controller_id = of_get_pci_domain_nr(node); > + if (imx6_pcie->controller_id) > + imx6_pcie->controller_id = 0; I don't understand what this is doing. It looks the same as just: imx6_pcie->controller_id = 0; Maybe this is a typo? As written, it doesn't look like there's any point in calling of_get_pci_domain_nr(). > switch (imx6_pcie->drvdata->variant) { > case IMX7D: > if (dbi_base->start == IMX8MQ_PCIE2_BASE_ADDR) > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel