From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38A87C4167B for ; Thu, 7 Dec 2023 17:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VrhpWInSQEIj3S0eeB4KnwJkLGjIly1HG7kGR5MqArA=; b=ZuzGnxkzaHVWk0GfI5qsMwPPIc W3zp0nGVs0Uhnm7zl7p253a1Qg376sxUFzDT/SzkgQbsZTlNZ+aE6CZ/mIl/fH+Gnq4lyLnBnLoQh 4cuJ/MqZSIi8RQZYWp3r2K0739dEk0K650UmcBr1J2Ul59dj54+ou7fRc+zlQkix+aLJDfdrIHpOC 2uSppvr3Vw/6AEW9VVZZjI2ed6+bDX/N/w5TUbdYb9Nej4kAr2E9ZkoxPw6kKNhqrHpcX99KDMfj0 aePBeESpxI1XhmbyOyFTMhmiH6DH/Rzvq6c1GB7p/a320g7bfYK5N//Y8uXe0Vw6OkVo3W49/mDnk RDHrrjjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBHvv-00DVU0-1j; Thu, 07 Dec 2023 17:13:07 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBHvs-00DVTS-1s for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2023 17:13:05 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9932C6218D; Thu, 7 Dec 2023 17:13:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D25CC433C7; Thu, 7 Dec 2023 17:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701969182; bh=CWq54dj8Wontm3jMWlBjKGW8W5yeehl6dhE489SUR0k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SIvadOdHqMIfBJnkKTHoWVdlW8stNFjOoGAqwWatdV0l62gCGKrkk3vEGRrcJNNQU CVfXX1kdAwdCkc1H2SpMyvF/yshcbXXRM+Efstw6ONK+jSMbsH1Nbf7ewZ/jDaQOjb o/WQ8wUapc/gl4abDD233akB8mpK5dbASCt1LCu1scD38vczeh0/U0mJEvJv6UA7DF VXklf2x97dLHxLnyILc4UEWw/RODCKbh65qnUvomFD5eGlieWgTy3DHrDfEP0HSA3M NHUAHRCT2S1rgK7gIA+Kt0dII0WpCmAAlhGsEewGzwQoLZPrd6tHUhvlc5Drcf0Lfq v0Yu2s0WNPzCA== Date: Thu, 7 Dec 2023 17:12:57 +0000 From: Conor Dooley To: Elad Nachman Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, pali@kernel.org, mrkiko.rs@gmail.com, chris.packham@alliedtelesis.co.nz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cyuval@marvell.com Subject: Re: [PATCH v7 2/3] dt-bindings: arm64: add Marvell COM Express boards Message-ID: <20231207-dallying-tablet-c5f32f91373c@spud> References: <20231207143248.2439926-1-enachman@marvell.com> <20231207143248.2439926-3-enachman@marvell.com> MIME-Version: 1.0 In-Reply-To: <20231207143248.2439926-3-enachman@marvell.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_091304_727931_815CF35D X-CRM114-Status: GOOD ( 16.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1660125160998121757==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1660125160998121757== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="d2AP0+yTHV6MnsnX" Content-Disposition: inline --d2AP0+yTHV6MnsnX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 07, 2023 at 04:32:47PM +0200, Elad Nachman wrote: > From: Elad Nachman >=20 > Add dt bindings for: > CN9130 COM Express CPU module > CN9131 COM Express CPU module > AC5X RD COM Express Type 7 carrier board. > AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module. >=20 > Signed-off-by: Elad Nachman > --- > .../bindings/arm/marvell/armada-7k-8k.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.y= aml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > index 52d78521e412..d00866aeaa8d 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml > @@ -60,4 +60,28 @@ properties: > - const: marvell,armada-ap807-quad > - const: marvell,armada-ap807 > =20 > + - description: > + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier = plus > + Armada CN9130 COM Express CPU module > + items: > + - enum: > + - marvell,cn9130-ac5x-carrier There's so many compatibles here that it is a bit hard for me to follow, but I am wondering why you have the "enum" here. The description seems to define this as being for one specific carrier and you have two entries here for carriers compatible with the rd-ac5x. It looks like you should either a) combine both of these or b) swap the enum for const. Thanks, Conor. > + - const: marvell,rd-ac5x-carrier > + - const: marvell,cn9130-cpu-module > + - const: marvell,cn9130 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > + - description: > + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier = plus > + Armada CN9131 COM Express CPU module > + items: > + - enum: > + - marvell,cn9131-ac5x-carrier > + - const: marvell,rd-ac5x-carrier > + - const: marvell,cn9131-cpu-module > + - const: marvell,cn9131 > + - const: marvell,armada-ap807-quad > + - const: marvell,armada-ap807 > + > additionalProperties: true > --=20 > 2.25.1 >=20 --d2AP0+yTHV6MnsnX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXH9GQAKCRB4tDGHoIJi 0nN2AQCqThk3YPq4l91eYo/Ek1s5Bu2ydkEspqikzp/UG0MxhAD+JGcDJ2d91XJp b/Zp56LDXRG9MZ7NMtXQKC69ErA4+go= =7TZ9 -----END PGP SIGNATURE----- --d2AP0+yTHV6MnsnX-- --===============1660125160998121757== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1660125160998121757==--