From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A5D2C10DCE for ; Thu, 7 Dec 2023 09:36:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:CC:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TALSV2VTGeZdjwbGhAyk5UQqc19Z/e1XY15nHVeuBYM=; b=caaZtuB3WvITSyzn62wOjYUOYI YH+60CVKtPb8ykiatKUX1L95vSssy50PJ1A0DcQeDBHs7dDtsUkqZXnBGDMDknYKhAaZ4ZGjZuf6v K3Dblfj65FP1xsZQj6XqVYIIeHAGdKy7128qu0/w4dR1ePZoXnVz1nz3XedFvC182/L4h6m3di4pu WHV+NnnazOnPArVAeBNiPVyLepyKYkT2D20RBwv+2wbsAWuz7NF2HUm49zeoFGY7T+UAuyYxf3kTC qhoEQSllDnIPoYAsrnzzdbfXIWkCb6f2IEurbDp5u0fdRlN933GzWW6H0a5dUVWIGDOkKIGdYkb3D ychyknnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBAnb-00CNKX-1R; Thu, 07 Dec 2023 09:36:03 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBAnY-00CNJm-0X; Thu, 07 Dec 2023 09:36:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1701941759; x=1733477759; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zk1dhT6C/KZSArTdzP/p5wqb9G2bfeL3f7SYtKcXyCo=; b=qZpMB9fYLRcErxdfYxXrI5nLXCl+GTOkA/MecYYRk5qPplPFv3uc1Bsc BopKLtN7qLnFi6vvLTEiYs+BwzbYALsOEIApMVFvtrqB+nISWxKqsNNw0 BmtJ7z27hMekTlVh1cjYi1w098eCoNscZ0YX3NSmSoVlHgvGGPQH+2nFZ m6sK9nVokh085iwzsZyDDGi1n59EreA40AVI2R3sd6rGMlOy24/pxXKqX 6DiwQUyChVRL8BrN3qL7MWfNFpH9WkQBiyewtAR02BA8X8mnOZxNSBZQR jYYjsZX/ieZOX2KcklsHr6XvoeLMN2pG274WOtz4FeH1igXnPiALiCQul Q==; X-CSE-ConnectionGUID: l1+X6HrHTViYXQWuY+0knA== X-CSE-MsgGUID: 3jqu90UXQHGGuQa2OlUe8A== X-ThreatScanner-Verdict: Negative X-IronPort-AV: E=Sophos;i="6.04,256,1695711600"; d="asc'?scan'208";a="12923027" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Dec 2023 02:35:57 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 7 Dec 2023 02:35:33 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 7 Dec 2023 02:35:29 -0700 Date: Thu, 7 Dec 2023 09:34:59 +0000 From: Conor Dooley To: Shengyang Chen CC: Conor Dooley , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v1 1/2] dt-bindings: display: panel: raspberrypi: Add compatible property for waveshare 7inch touchscreen panel Message-ID: <20231207-dullness-deprive-ece2d47ff69d@wendy> References: <20231124104451.44271-1-shengyang.chen@starfivetech.com> <20231124104451.44271-2-shengyang.chen@starfivetech.com> <20231124-lesser-sinister-7f9cd7b80e35@spud> <2d48e460-e46e-431f-bd7b-e34ebe73a40c@starfivetech.com> <20231206-isolating-smoked-b490952029d0@spud> <53b992e8-1b36-4540-a993-fde8e550faf9@starfivetech.com> MIME-Version: 1.0 In-Reply-To: <53b992e8-1b36-4540-a993-fde8e550faf9@starfivetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_013600_275797_8272F093 X-CRM114-Status: GOOD ( 31.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2520204597370133820==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2520204597370133820== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LKkffefepue30ywv" Content-Disposition: inline --LKkffefepue30ywv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 07, 2023 at 11:48:56AM +0800, Shengyang Chen wrote: > Hi, Conor >=20 > thanks for comment >=20 > On 2023/12/6 23:40, Conor Dooley wrote: > > On Wed, Dec 06, 2023 at 05:43:48PM +0800, Shengyang Chen wrote: > >> Hi, Conor > >>=20 > >> On 2023/11/24 20:31, Conor Dooley wrote: > >> > On Fri, Nov 24, 2023 at 06:44:50PM +0800, Shengyang Chen wrote: > >> >> The waveshare 7inch touchscreen panel is a kind of raspberrypi pi > >> >> panel > >> >=20 > >> > Can you be more specific about what "is a kind of rpi panel" means? > >> > Are they using identical chips as controllers or something like that? > >> >=20 > >>=20 > >> Wareshare panel has same i2c slave address and registers address with= =20 > >> the original raspberry pi panel. They both use Atmel firmware and they > >> got same reg id. It can be operated by using the driver of raspberry p= i driver > >> after some change of the code. So I suppose it may be a kind of raspbe= rry pi panel=20 > >> and discribe it in this way. It's my own judgement. Sorry about that. > >> Maybe just like Dave said, It cloned the behaviour of the raspberri pi= panel. > >> I will change the discribtion in next version to not make other confus= ed. > >>=20 > >> By the way, we will try Stefan's method before next version.=20 > >> The method we used in this patch may be abandoned if Stefan's method i= s verified in our platform. > >> At that time yaml may also be changed to fit new method. > >=20 > > I don't know what Stefan's approach is, but I do not think that a > > bindings patch should be dropped. The waveshare might be a clone, but it > > is a distinct device. If the same driver can control both, then the > > compatible setups that should be permitted are: > > compatible =3D "raspberrypi,7inch-touchscreen-panel"; > > and > > compatible =3D "waveshare,7inch-touchscreen-panel", "raspberrypi,7inch-= touchscreen-panel"; > If we use Stenfan's method, we can reuse the code of panel-simple.c > we may submit our patch to > /Documentation/devicetree/bindings/display/panel/panel-simple.yaml > /drivers/gpu/drm/panel/panel-simple.c > as a new panel porting. That may less confuse. As long as you provide a specific compatible, and not re-use the rpi one, that's fine. It just sounded like you were intending to reuse that here, but from this message it seems like I misunderstood. Thanks, Conor. --LKkffefepue30ywv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXGRvwAKCRB4tDGHoIJi 0uepAPsFO121yBy+oxhB7OSau+AELQyXEwausDJX8GujOigD2wD+NWi8eCcUWndt 3hUdUUgCa3P8sLTU12m5hwaHq3cJ9Qo= =bdsy -----END PGP SIGNATURE----- --LKkffefepue30ywv-- --===============2520204597370133820== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2520204597370133820==--