From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69939C4167B for ; Thu, 7 Dec 2023 06:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AL4ecy5RcZ431yHbGM7zl5NiTUqmvF/wBqaEDCzaAeg=; b=yK3JAHIdrRadJA 1C02DWM6XVvtIvD6PxEvwqw9k9EDvN+gvckHlzxOmQWfOjThBzAub1XM7FgJuYTusdQfiLaLY3Y+B 2o3omYd6rGq5qPAUuo4KiYNY24h79yaLOGVWAJfrpSHb5lz+yivmlSyq7BIujGYXfoNGt/lYSASdf +sHFRIWOs/t4y7YdwO9jDOuj1p1U+YtNa0XKaojKgMlzk6Bz3zHUE4s5T5KwFDBW4nZma9IzdLSXG RPThtfGH9sqmtO2LL0KIGhwy0eXBFId24JJHYG74s7KB2AmDPowgdXMwVhguj2tsZrGj39OGVFs9x IeraFeJRKIO1YjDseu2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rB7ZW-00BxDR-1h; Thu, 07 Dec 2023 06:09:18 +0000 Received: from mail5.25mail.st ([74.50.62.9]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rB7ZT-00BxCE-1H for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2023 06:09:17 +0000 Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 2574C60354; Thu, 7 Dec 2023 06:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1701929349; bh=TX7qx7q7p/Dxod/eo0LPaHkUCtsgAYBthLNvxSWn/Ik=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qnVxfUyrIOkqzuiXOraH5hxdFJtfpdHfK9CO6B78Qtq+PQZra5kDw3FSEwF/4fMIL YxVeAGaeweYI6vN+/GGZ20mqO/2r1Ga4sYSbKY0QhU4etpC2CL2INBok+Im+VMvFNl 0Lb8NzTUccDkBnl+3zb6DjOrDszc5rhE9CpJ+L3B56cjYM2SRg4B2PNvJSQ8v7Nz2u pBHjoHxIZbf02vZ6XQyxJy+NymCuPxouvF+I33qv6PJLwTMcxToZz0Bvwldd8EQfiZ p1cIiLuQOLeUOhyjHb9GaPSbcbwm8XOESOad9PsHUAy1eP6dBt7cFU5dQRbvX+niGx nkv2+FcXQSBAg== Date: Thu, 7 Dec 2023 08:08:54 +0200 From: Tony Lindgren To: Kevin Hilman Cc: Nishanth Menon , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dhruva Gole Subject: Re: [PATCH v2 1/1] arm64: dts: ti: k3-am62-wakeup: Configure ti-sysc for wkup_uart0 Message-ID: <20231207060854.GQ5169@atomide.com> References: <20231114073209.40756-1-tony@atomide.com> <7h5y1c7c0q.fsf@baylibre.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7h5y1c7c0q.fsf@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_220915_638433_382DCD31 X-CRM114-Status: GOOD ( 13.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Kevin Hilman [231205 18:14]: > I'm a little confused why these power-domain and clocks stay here and > are not moved under the wkup_uart0 node... The resources are also needed by the interconnect target module. It's the wrapper IP for the child device(s). In this case there's one chip 8250 IP instance. In some other devices there can be multiple child IP devices wired to one target module. > > - clock-names = "fclk"; > > - status = "disabled"; > > + clock-names = "fck"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0 0x2b300000 0x100000>; > > + > > + wkup_uart0: serial@2b300000 { > > + compatible = "ti,am64-uart", "ti,am654-uart"; > > + reg = <0 0x100>; > > + interrupts = ; > > + status = "disabled"; > > ...here. > > The SCI device ID 114 is specifically for wkup_uart0[1], so it seems to > me those should be in the wkup_uart0 node. Those resources are also needed for the parent target module for revision detection, quirks, reset, idle register configuration, and to probe the child devices. Here the 8250 IP can be set to status = "reserved" when used by the firmware, and 8250 not touched by Linux. However, the parent interconnect target module still needs to be configured for idle registers and wake-up path register bit so the wake-up from deeper suspend states works. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel