From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE941C4167B for ; Thu, 7 Dec 2023 10:14:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dxJ4U3XIEVdn6oL0osiYXGuBrWqD23f4FsGEResucQ8=; b=ZMKsMsgylf7vG0 7/pHvOyn7h5kh6x0HHtS5+uelekgp57L2C9oCVpQw01DI5cedPW/uOclfqhXrgZM+Dka5/D43nJNA dTmy4BZo8W3IcJSgTm0+eNpv02SmC64yt9j8E971jAhx2vJV6EG98MT2s6vcgQTBgO5IpZM2tDM80 /Oeg/PzERbfTYIcxC5HCnsEUbV1xXDvJ1ID1PeGu+vGAqdu17G5bSYDDfBr0YlCkcum4qD7p7YIRk OxN/uQImJbrO13/5UiLSYLHEd+z/QbLxRE3uLwkGFi2hLorHDOpIa7ey6Wx1OuruxT5520ysiL2OG /H4TIk9v7HD45AhHm1ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBBOM-00CS9g-0p; Thu, 07 Dec 2023 10:14:02 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBBOJ-00CS8V-0D for linux-arm-kernel@lists.infradead.org; Thu, 07 Dec 2023 10:14:00 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 32FCD669; Thu, 7 Dec 2023 11:13:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701943993; bh=Q4Xaye2wzVLAE7TkTPOKqO6+4DoaA7q/+roFqfFlw3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sd6Q7JWVYa7ZTysivLCvZzCAZ4DtdNMCT6k9Yaxfy83cgZWR8vNHbe0IkquhlUvAh 0TfKeXoIBgm/yuvGL5h9G5qCNsNvQW7+h90LRf2Ty7A363yr6s6UaT62mvSR65lzBw lmDUzEOkgJlE3ESx4iV285LMrLif9wKpf/k6vBfo= Date: Thu, 7 Dec 2023 12:14:00 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Fabio Estevam , Pengutronix Kernel Team , NXP Linux Team , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/1] media: nxp: imx8-isi-debug: Add missing registers to debugfs output Message-ID: <20231207101400.GB3681@pendragon.ideasonboard.com> References: <20231206094401.491100-1-alexander.stein@ew.tq-group.com> <20231206223636.GE29417@pendragon.ideasonboard.com> <2915417.e9J7NaK4W3@steina-w> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2915417.e9J7NaK4W3@steina-w> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_021359_246878_3EDF0BB9 X-CRM114-Status: GOOD ( 22.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, On Thu, Dec 07, 2023 at 08:52:46AM +0100, Alexander Stein wrote: > Am Mittwoch, 6. Dezember 2023, 23:36:36 CET schrieb Laurent Pinchart: > > On Wed, Dec 06, 2023 at 10:44:01AM +0100, Alexander Stein wrote: > > > The extended address registers are missing in the debug output register > > > list. Add them. > > > > > > Signed-off-by: Alexander Stein > > > --- > > > > > > drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c index > > > 6709ab7ea1f3..3ac5685d6cc1 100644 > > > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-debug.c > > > @@ -66,6 +66,13 @@ static int mxc_isi_debug_dump_regs_show(struct seq_file *m, void *p) > > > MXC_ISI_DEBUG_REG(CHNL_OUT_BUF2_ADDR_V), > > > MXC_ISI_DEBUG_REG(CHNL_SCL_IMG_CFG), > > > MXC_ISI_DEBUG_REG(CHNL_FLOW_CTRL), > > > > > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF1_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF1_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF1_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_Y_BUF2_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_U_BUF2_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_V_BUF2_XTND_ADDR), > > > + MXC_ISI_DEBUG_REG(CHNL_IN_BUF_XTND_ADDR), > > > > Those registers only exist in the i.MX8MP. The i.MX8MN referenece manual > > lists them as reserved and indicates they read as 0's, so it should be > > safe. The i.MX93 reference manual, however, doesn't list those > > registers at all, so accessing them may lead to issues. > > > > How what platform(s) have you tested this patch ? > > Ah, you are right. That's something I didn't take into account. Up until now I > only tested this on i.MX8MP. I hope I can test this on i.MX8MN and i.MX93 > soon. > Otherwise dumping these registers can depend on pdata->has_36bit_dma just to > be safe. That sounds like a good solution to me. Will you do so in a v2 ? > > > }; > > > > > > struct mxc_isi_pipe *pipe = m->private; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel