From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB3FCC4167B for ; Thu, 7 Dec 2023 10:25:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U9+uF1sqAf0D1XET5exY3+bwxfN6c4JjPrsPE3XMJeE=; b=p0lLlE7BM2iPMN Fp0MkJCpQO+OEqKZnS9uU57xhfUFvHJMOp2eYsbRLwBB8z2bvXopc4Oh4qzlqANWJnsGuaV2hKokA d48RXWnxbtVQyeUCl57P8qqC/F9Xq1ZKxZgC0Yfc95C5Cf6PEFe7FvZxMiiECpXwimBz+WRIsv8b2 EgOOub54Pvcz3jkP86QcQEY2pxFZrQoee5s+/HDPKnqWFPU/NLC0vd//lR9CA6/o7kWJyVhjbDgN6 aknonyU3jE10loxPgb9Mjzq0uFJWYzbnsgEfQx4gmBwk3o/nsn8LqTeL+MZ3MWBfW28foaLvEGfTR Kex+HpRrUDTR+si5UEZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBBZ2-00CTEw-1Z; Thu, 07 Dec 2023 10:25:04 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBBYy-00CTE6-34; Thu, 07 Dec 2023 10:25:02 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E6DC2669; Thu, 7 Dec 2023 11:24:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701944658; bh=oGMWlxxRV6p3mFDaJ3TGXPEn3FbTBvg3/evgd3+y/Ko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vWpXT8UsiteCEzkEtzoX10adYyeEX6urlEu+KOlHBcjaDk5VGq8rGJ8BqOCE/3GBR A8ORGLRJ/bnMcvNEsZdXBOoYvMgtiooFJn7bMpCObyZkhv/ebpeCSvmxaifFjDBH3O ksV/e2TPK5L34V/sT/OPysbbUrbkgsDWyMhAGZVk= Date: Thu, 7 Dec 2023 12:25:05 +0200 From: Laurent Pinchart To: Conor Dooley Cc: Zhi Mao , mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shengnan.wang@mediatek.com, yaya.chang@mediatek.com, 10572168@qq.com, Project_Global_Chrome_Upstream_Group@mediatek.com, yunkec@chromium.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, jacopo.mondi@ideasonboard.com, sakari.ailus@linux.intel.com, hverkuil-cisco@xs4all.nl, heiko@sntech.de, jernej.skrabec@gmail.com, macromorgan@hotmail.com, linus.walleij@linaro.org, hdegoede@redhat.com, tomi.valkeinen@ideasonboard.com, gerald.loacker@wolfvision.net, andy.shevchenko@gmail.com, bingbu.cao@intel.com, dan.scally@ideasonboard.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 1/2] media: dt-bindings: media: i2c: Document GC08A3 bindings Message-ID: <20231207102505.GI29417@pendragon.ideasonboard.com> References: <20231123115104.32094-1-zhi.mao@mediatek.com> <20231123115104.32094-2-zhi.mao@mediatek.com> <20231123-magical-rupture-83251807e995@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231123-magical-rupture-83251807e995@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_022501_126269_7B3B95A1 X-CRM114-Status: GOOD ( 25.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 23, 2023 at 05:31:35PM +0000, Conor Dooley wrote: > On Thu, Nov 23, 2023 at 07:51:03PM +0800, Zhi Mao wrote: > > Add YAML device tree binding for GC08A3 CMOS image sensor, > > and the relevant MAINTAINERS entries. > > > > Signed-off-by: Zhi Mao > > Please test your bindings. > > > --- > > .../bindings/media/i2c/galaxycore,gc08a3.yaml | 128 ++++++++++++++++++ > > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > > 2 files changed, 130 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml > > new file mode 100644 > > index 000000000000..089ea321da91 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml > > @@ -0,0 +1,128 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/galaxycore,gc08a3.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: GalaxyCore gc08a3 1/4" 8M Pixel MIPI CSI-2 sensor > > + > > +maintainers: > > + - Zhi Mao > > + > > +description: |- > > The |- is not needed, you have no formatting to preserve. > > > + The gc08a3 is a raw image sensor with an MIPI CSI-2 image data > > + interface and CCI (I2C compatible) control bus. The output format > > + is raw Bayer. > > + > > +properties: > > + compatible: > > + const: GalaxyCore,gc08a3 > > Please remove the capitals. > > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: Reference to the mclk clock. > > Pointless, just use maxItems: 1. > > > + > > + assigned-clocks: > > + maxItems: 1 > > + > > + assigned-clock-rates: > > + maxItems: 1 > > + > > + enable-gpios: > > + description: Reference to the GPIO connected to the RESETB pin. Active low. > > + maxItems: 1 > > + If that's the RESETB pin, it should be reset-gpios. > > + vddio-supply: > > + description: Definition of the regulator used for the VDDIO power supply. > > + > > + vdda-supply: > > + description: Definition of the regulator used for the VDDA power supply. > > + > > + vddd-supply: > > + description: Definition of the regulator used for the VDDD power supply. > > These descriptions can all be replaced with "foo-supply: true" IMO. > > > + port: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + data-lanes: > > + oneOf: > > + - items: > > + - const: 1 > > + - const: 2 > > + - const: 3 > > + - const: 4 > > + - items: > > + - const: 1 > > + - const: 2 > > + > > + link-frequencies: true > > + > > + required: > > + - data-lanes > > + - link-frequencies > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > > + - assigned-clocks > > + - assigned-clock-rates > > Why are these required? > > > + - vddio-supply > > + - vdda-supply > > + - vddd-supply > > + - port > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + sensor0@2 { > > + status = "okay"; > > + compatible = "GalaxyCore,gc08a3"; > > + reg = <0x31>; > > + > > + clocks = <&topckgen CLK_TOP_CAMTG>, > > + <&topckgen CLK_TOP_UNIVPLL_192M_D8>; > > + clock-names = "xvclk", "freq_mux"; > > + clock-frequency = <24000000>; > > + > > + assigned-clocks = <&topckgen CLK_TOP_CAMTG>, > > + <&topckgen CLK_TOP_UNIVPLL_192M_D8>; > > + assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL_192M_D8>; > > + assigned-clock-rates = <0>, <24000000>; > > + > > + enable-gpios = <&pio 19 GPIO_ACTIVE_HIGH>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&camera_pins_cam0>; > > + > > + avdd-supply = <&mt6359_vfe28_ldo_reg>; > > + > > + port { > > + sensor0_out_2: endpoint { > > + data-lanes = <1 2 3 4>; > > + link-frequencies = /bits/ 64 <336000000 207000000>; > > + remote-endpoint = <&seninf_csi_port_0_in_2>; > > + }; > > + }; > > + }; > > + > > + }; > > + > > +... > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > index 309b94c328c8..a0bbec0bfee2 100644 > > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > > @@ -502,6 +502,8 @@ patternProperties: > > description: Fujitsu Ltd. > > "^fxtec,.*": > > description: FX Technology Ltd. > > + "^GalaxyCore,.*": > > + description: GalaxyCore Inc. > > "^gardena,.*": > > description: GARDENA GmbH > > "^gateway,.*": -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel