From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D207C4167B for ; Thu, 7 Dec 2023 18:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3+q05Xz+z9NB0ut7k6qbI63Y2LYhvTONdoQXbRtpHXo=; b=3fFPjW5GJKtfL+ VwczX8ES6+DAFMNPK//Dt7htaZjHmf5hF4URhspCfECzfG5fIQifcNsqZsNDPQFb0EWefUh2hl0Va /YzF8kTyBqjcR6HmacyTILHxAxW6hrPpnH8tx68sZrBJJLGSTITZSIgfe/Il1sPmVZEMe0/atkpCN m6fNyB78X5J/7Ebwyo1K/s96q24xVnIkale1kihVExjqtRYAY/rD3a5CWTx3UxP4Rv31hr2lPBsBD iUZaaNAH/R+CwiVvBFMNoB8lpK8wAE7D3CtCMAGEIhh60Jtcro2yrUT/lnpWgcCPiWsV0ujn72Aja wFI5faykWNwUY39Ep+0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBJIO-00DfR7-0t; Thu, 07 Dec 2023 18:40:24 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBJIK-00DfQ7-1P; Thu, 07 Dec 2023 18:40:21 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-54c4f95e27fso1190536a12.1; Thu, 07 Dec 2023 10:40:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701974419; x=1702579219; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=kigIueQOAcLn75XXfZ0Gwh0kRvsokZ/Ypm7K8+pRm4g=; b=cU6Mv+9sZirWEMllZTg71mNBdqtvdnWiDYmD8v2xNsgT8FKuYFgEkP7PWVkpmJE+l6 p10QeQhBHfVVW1l/97+1m/AAwe2jdeMgB/ZcKn/OB+1wphf1ilJtoLvxr61ZOz3AXcZL fXUtJRQXrV/F2GZmT8Lk27khQVzXAHpy9D0UhEcXd21OP0hkbRilLfdw1m8pKGqgUYEV oKFkmDnFErgSOn8LCzybornX6ne8RcF7vBbXy3tIWNHB0AKDDF7qRf9BaGTnZtX3qFig s64n3UOI6R6i8zRSzt+Oz+4MocjXsmFk30RcK08wOr7baN8TdSIU5oF/iJlEQmuk+pSr ZmQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701974419; x=1702579219; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kigIueQOAcLn75XXfZ0Gwh0kRvsokZ/Ypm7K8+pRm4g=; b=vYIH05aW0/5wOP4hITKqOW6/qONRN/afZZwXD/HszZUrLmO5OoJpTFoN6L5xnCWvK3 JL1Iv92hBkt8HPN7tF1YbFRZcngAsTayblOKNlmtvSszdK0PgUbTNDejRUGGn7OVt8Zh 8R4rV/CczoAatsVHTX5iL0Gqo9j8OQNVerqiuIFjioWTVx2EFLgy5efFdghhjQQtK+A4 nHGrm+cr0AY548uBBIOU/7Z0/8nd10cl2SGg41BQfR/Fiim6VMyjvonmoiz2YJpPOe2t 7IuuOBJA0YbspBNvTIqrfgkkFXM7Rc52+t34uOs34I+ZhyQa2yb0rSCoTR8p+z3K4bHg LPow== X-Gm-Message-State: AOJu0Yw1XxZ9Aps8Q02RhSwVfwQlbnVmi9wxJPEyRTC0Jq22EMaPULle JwWnSxOy61u/woXkLn2auxY= X-Google-Smtp-Source: AGHT+IEyVEmWPr683mIgsYZk1wfGxtefcti3FrQu/q9XZjuViGfGsnMvgIfr5NwzTX0f4Wg9AjJQQg== X-Received: by 2002:a05:6402:1d91:b0:54c:4837:903e with SMTP id dk17-20020a0564021d9100b0054c4837903emr1942092edb.54.1701974418673; Thu, 07 Dec 2023 10:40:18 -0800 (PST) Received: from skbuf ([188.27.185.68]) by smtp.gmail.com with ESMTPSA id l12-20020a50cbcc000000b0054b53aacd86sm113790edi.65.2023.12.07.10.40.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 10:40:18 -0800 (PST) Date: Thu, 7 Dec 2023 20:40:15 +0200 From: Vladimir Oltean To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Dan Carpenter , Simon Horman , Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com Subject: Re: [PATCH net-next 07/15] net: dsa: mt7530: do not run mt7530_setup_port5() if port 5 is disabled Message-ID: <20231207184015.u7uoyfhdxiyuw6hh@skbuf> References: <20231118123205.266819-1-arinc.unal@arinc9.com> <20231118123205.266819-8-arinc.unal@arinc9.com> <20231121185358.GA16629@kernel.org> <90fde560-054e-4188-b15c-df2e082d3e33@moroto.mountain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <90fde560-054e-4188-b15c-df2e082d3e33@moroto.mountain> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_104020_475929_ED1479A0 X-CRM114-Status: GOOD ( 25.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBEZWMgMDcsIDIwMjMgYXQgMDk6NTE6MDdBTSArMDMwMCwgRGFuIENhcnBlbnRlciB3 cm90ZToKPiBPbiBTYXQsIERlYyAwMiwgMjAyMyBhdCAxMTo0NTo0MkFNICswMzAwLCBBcsSxbsOn IMOcTkFMIHdyb3RlOgo+ID4gCj4gPiBJJ20gbm90IHN1cmUgd2h5IGl0IGRvZXNuJ3QgY2F0Y2gg dGhhdCBmb3IgbXQ3NTMwX3NldHVwX3BvcnQ1KCkgdG8gcnVuCj4gPiBoZXJlLCBwcml2LT5wNV9p bnRmX3NlbCBtdXN0IGJlIGVpdGhlciBQNV9JTlRGX1NFTF9QSFlfUDAgb3IKPiA+IFA1X0lOVEZf U0VMX1BIWV9QNC4gQW5kIGZvciB0aGF0IHRvIGhhcHBlbiwgdGhlIGludGVyZmFjZSB2YXJpYWJs ZSB3aWxsIGJlCj4gPiBpbml0aWFsaXNlZC4KPiA+IAo+ID4gZm9yX2VhY2hfY2hpbGRfb2Zfbm9k ZShkbiwgbWFjX25wKSB7Cj4gPiAJaWYgKCFvZl9kZXZpY2VfaXNfY29tcGF0aWJsZShtYWNfbnAs Cj4gPiAJCQkJICAgICAibWVkaWF0ZWssZXRoLW1hYyIpKQo+ID4gCQljb250aW51ZTsKPiA+IAo+ ID4gCXJldCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMyKG1hY19ucCwgInJlZyIsICZpZCk7Cj4gPiAJ aWYgKHJldCA8IDAgfHwgaWQgIT0gMSkKPiA+IAkJY29udGludWU7Cj4gPiAKPiA+IAlwaHlfbm9k ZSA9IG9mX3BhcnNlX3BoYW5kbGUobWFjX25wLCAicGh5LWhhbmRsZSIsIDApOwo+ID4gCWlmICgh cGh5X25vZGUpCj4gPiAJCWNvbnRpbnVlOwo+ID4gCj4gPiAJaWYgKHBoeV9ub2RlLT5wYXJlbnQg PT0gcHJpdi0+ZGV2LT5vZl9ub2RlLT5wYXJlbnQpIHsKPiA+IAkJcmV0ID0gb2ZfZ2V0X3BoeV9t b2RlKG1hY19ucCwgJmludGVyZmFjZSk7Cj4gPiAJCWlmIChyZXQgJiYgcmV0ICE9IC1FTk9ERVYp IHsKPiA+IAkJCW9mX25vZGVfcHV0KG1hY19ucCk7Cj4gPiAJCQlvZl9ub2RlX3B1dChwaHlfbm9k ZSk7Cj4gPiAJCQlyZXR1cm4gcmV0Owo+ID4gCQl9Cj4gPiAJCWlkID0gb2ZfbWRpb19wYXJzZV9h ZGRyKGRzLT5kZXYsIHBoeV9ub2RlKTsKPiA+IAkJaWYgKGlkID09IDApCj4gPiAJCQlwcml2LT5w NV9pbnRmX3NlbCA9IFA1X0lOVEZfU0VMX1BIWV9QMDsKPiA+IAkJaWYgKGlkID09IDQpCj4gPiAJ CQlwcml2LT5wNV9pbnRmX3NlbCA9IFA1X0lOVEZfU0VMX1BIWV9QNDsKPiA+IAl9Cj4gPiAJb2Zf bm9kZV9wdXQobWFjX25wKTsKPiA+IAlvZl9ub2RlX3B1dChwaHlfbm9kZSk7Cj4gPiAJYnJlYWs7 Cj4gPiB9Cj4gPiAKPiA+IGlmIChwcml2LT5wNV9pbnRmX3NlbCA9PSBQNV9JTlRGX1NFTF9QSFlf UDAgfHwKPiA+ICAgICBwcml2LT5wNV9pbnRmX3NlbCA9PSBQNV9JTlRGX1NFTF9QSFlfUDQpCj4g PiAJbXQ3NTMwX3NldHVwX3BvcnQ1KGRzLCBpbnRlcmZhY2UpOwo+IAo+IFNtYXRjaCBkb2Vzbid0 IGtub3c6Cj4gMSkgV2hhdCB0aGUgdmFsdWUgb2YgcHJpdi0+cDVfaW50Zl9zZWwgaXMgZ29pbmcg aW50byB0aGlzIGZ1bmN0aW9uCj4gMikgV2UgZW50ZXIgdGhlIGZvcl9lYWNoX2NoaWxkX29mX25v ZGUoKSBsb29wCj4gMykgVGhhdCBpZiAocGh5X25vZGUtPnBhcmVudCA9PSBwcml2LT5kZXYtPm9m X25vZGUtPnBhcmVudCkgeyBpcwo+ICAgIGRlZmluaXRlbHkgdHJ1ZSBmb3Igb25lIGVsZW1lbnQg b24gdGhlIGxpc3QuCj4gCj4gTG9va2luZyBhdCBob3cgU21hdGNoIHBhcnNlcyB0aGlzIGNvZGUs IEkgY291bGQgcHJvYmFibHkgaW1wcm92ZSBwcm9ibGVtCj4gIzEgYSBiaXQuICBSaWdodCBub3cg U21hdGNoIHNlZXMgInN0cnVjdCBtdDc1MzBfcHJpdiAqcHJpdiA9IGRzLT5wcml2OyIKPiBhbmQg InByaXYtPnA1X2ludGZfc2VsIiBpcyB1bmtub3duLCBidXQgSSBjb3VsZCBwcm9iYWJseSBpbXBy b3ZlIGl0IHRvCj4gd2hlcmUgaXQgc2F5cyB0aGF0IGl0J3MgaW4gdGhlIDEtMyByYW5nZS4gIEJ1 dCB0aGF0IGRvZXNuJ3QgaGVscCBoZXJlCj4gYW5kIGl0IGRvZXNuJ3QgYWRkcmVzcyBwcm9ibGVt cyAyIGFuZCAzLgo+IAo+IEl0J3MgYSBoYXJkIHByb2JsZW0uCj4gCj4gcmVnYXJkcywKPiBkYW4g Y2FycGVudGVyCj4gCgpXZSBjb3VsZCBiZSBtb3JlIHByYWdtYXRpYyBhYm91dCB0aGlzIHdob2xl IHNwYXJzZSBmYWxzZSBwb3NpdGl2ZSB3YXJuaW5nLAphbmQganVzdCBtb3ZlIHRoZSAiaWYiIGJs b2NrIHdoaWNoIGNhbGxzIG10NzUzMF9zZXR1cF9wb3J0NSgpIHJpZ2h0CmFmdGVyIHRoZSBwcml2 LT5wNV9pbnRmX3NlbCBhc3NpZ25tZW50cywgaW5zdGVhZCBvZiB3YWl0aW5nIHRvICJicmVhazsi CmZyb20gdGhlIGZvcl9lYWNoX2NoaWxkX29mX25vZGUoKSBsb29wLgoKZm9yX2VhY2hfY2hpbGRf b2Zfbm9kZShkbiwgbWFjX25wKSB7CglpZiAoIW9mX2RldmljZV9pc19jb21wYXRpYmxlKG1hY19u cCwKCQkJCSAgICAgIm1lZGlhdGVrLGV0aC1tYWMiKSkKCQljb250aW51ZTsKCglyZXQgPSBvZl9w cm9wZXJ0eV9yZWFkX3UzMihtYWNfbnAsICJyZWciLCAmaWQpOwoJaWYgKHJldCA8IDAgfHwgaWQg IT0gMSkKCQljb250aW51ZTsKCglwaHlfbm9kZSA9IG9mX3BhcnNlX3BoYW5kbGUobWFjX25wLCAi cGh5LWhhbmRsZSIsIDApOwoJaWYgKCFwaHlfbm9kZSkKCQljb250aW51ZTsKCglpZiAocGh5X25v ZGUtPnBhcmVudCA9PSBwcml2LT5kZXYtPm9mX25vZGUtPnBhcmVudCkgewoJCXJldCA9IG9mX2dl dF9waHlfbW9kZShtYWNfbnAsICZpbnRlcmZhY2UpOwoJCWlmIChyZXQgJiYgcmV0ICE9IC1FTk9E RVYpIHsKCQkJb2Zfbm9kZV9wdXQobWFjX25wKTsKCQkJb2Zfbm9kZV9wdXQocGh5X25vZGUpOwoJ CQlyZXR1cm4gcmV0OwoJCX0KCQlpZCA9IG9mX21kaW9fcGFyc2VfYWRkcihkcy0+ZGV2LCBwaHlf bm9kZSk7CgkJaWYgKGlkID09IDApCgkJCXByaXYtPnA1X2ludGZfc2VsID0gUDVfSU5URl9TRUxf UEhZX1AwOwoJCWlmIChpZCA9PSA0KQoJCQlwcml2LT5wNV9pbnRmX3NlbCA9IFA1X0lOVEZfU0VM X1BIWV9QNDsKCgkJaWYgKHByaXYtPnA1X2ludGZfc2VsID09IFA1X0lOVEZfU0VMX1BIWV9QMCB8 fCA8LS0tLSBoZXJlCgkJICAgIHByaXYtPnA1X2ludGZfc2VsID09IFA1X0lOVEZfU0VMX1BIWV9Q NCkKCQkJbXQ3NTMwX3NldHVwX3BvcnQ1KGRzLCBpbnRlcmZhY2UpOwoJfQoJb2Zfbm9kZV9wdXQo bWFjX25wKTsKCW9mX25vZGVfcHV0KHBoeV9ub2RlKTsKCWJyZWFrOwp9CgpJIGhvcGUgaXQncyBu b3cgbXVjaCBjbGVhcmVyIHRvIHNwYXJzZSB0aGF0ICJpbnRlcmZhY2UiIGlzIHVzZWQgd2l0aGlu CnRoZSBzYW1lIGJhc2ljIGJsb2NrIGluIHdoaWNoIGl0IGFsc28gZ290IGFzc2lnbmVkLCBhbmQg dGhhdCBkZXRlcm1pbmF0aW9uCmRvZXMgbm90IGRlcGVuZCB1cG9uIHRoZSB2YWx1ZXMgdGFrZW4g YnkgYSBzZWNvbmQgdmFyaWFibGUuCgpNYXliZSBpdCdzIGFsc28gYSBiaXQgY2xlYXJlciBmb3Ig dXMgaHVtYW5zLgoKV2hhdCB3b3VsZCBhbHNvIGhlbHAgdXMgaHVtYW5zIGV2ZW4gbW9yZSBpcyB0 byBleHRyYWN0IHRoZSBlbnRpcmUgImRuIgpoYW5kbGluZyBmcm9tIG10NzUzMF9zZXR1cCgpIGlu dG8gYSBzZXBhcmF0ZSBtdDc1MzBfc2V0dXBfcGh5X211eGluZygpCmZ1bmN0aW9uLCBhbmQgcHV0 IGEgZ29vZCBjb21tZW50IHRoZXJlIGFib3V0IHdoYXQncyBnb2luZyBvbiB3aXRoIHRoaXMKUEhZ IG11eGluZyB0aGluZy4KClRoZSBhZHZhbnRhZ2Ugb2Ygc3BsaXR0aW5nIHRoaXMgdXAgaXMgdGhh dCB3ZSBkb24ndCBwb2xsdXRlIG10NzUzMF9zZXR1cCgpCndpdGggZmluZGluZyB0aGUgImRuIiBp ZiBkc2FfaXNfdW51c2VkX3BvcnQoZHMsIDUpIHJldHVybnMgZmFsc2UuCgpBbHNvLCByZWR1Y2lu ZyB0aGUgaW5kZW50YXRpb24gbGV2ZWwgb2YgZm9yX2VhY2hfY2hpbGRfb2Zfbm9kZSgpIGJ5IG9u ZQpjYW4ndCBiZSBiYWQuIE1heWJlIGV2ZW4gYnkgbW9yZS4gVGhlcmUncyB0aGlzIHBhdHRlcm46 Cgpmb3JfZWFjaF9jaGlsZF9vZl9ub2RlKGRuLCBtYWNfbnApIHsKCS8vIGRvIHN0dWZmIHdpdGgg bWFjX25wCglicmVhazsKfQoKYWthIHdlIG9ubHkgY2FyZSBhYm91dCB0aGUgZmlyc3QgY2hpbGQg b2YgZG4uIFdlIGNvdWxkIGZpbmQgdGhlIG1hY19ucAphcyB0aGUgb25seSBvcGVyYXRpb24gaW5z aWRlIGZvcl9lYWNoX2NoaWxkX29mX25vZGUoKSwgYnJlYWsgZGlyZWN0bHksCmFuZCAiZG8gc3R1 ZmYgd2l0aCBtYWNfbnAiIGNvdWxkIGJlIGRvbmUgb3V0c2lkZSwgZnVydGhlciByZWR1Y2luZyB0 aGUKaW5kZW50YXRpb24gYnkgMSBsZXZlbC4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK