From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0372C4167B for ; Thu, 7 Dec 2023 06:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C5UTKVMhj/5NBc8kXxdSHQuaiMRV8XYxutjM26Bg5Hs=; b=mhMuZpZOXq8iKT Xflq2GIlCn7NjybVwNITcxDU6X1U4jlKhcjsmKBi/6c0Mwthkl0kE2eQt8T2kDBWqpa5OahutpnsM 8UzSccH0W4lIK6w+2NTcOp4pM4BhveZj2v15wgoUC7tAa+Bk4amd9k8psCOezlIVN+XPy7wbNQFwv xFUan4OiFBczjoZx0eGxll4d/DqrPsxqR3YlqqNw6fqrj/yAukrfdKMKocxK8OaSbkEqoTNr65Tdt CwODjhl/Swq3mMZCEeuyRy95QKfMs0fyHZe7HAvuVy7t8iYk3kK5g4iy3wdC90hIl8WyhCqwFPAz0 i7U+l5nAq8qRaV23eI0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rB8FW-00C26D-0c; Thu, 07 Dec 2023 06:52:42 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rB8FT-00C25Q-0O; Thu, 07 Dec 2023 06:52:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id CEE9DCE21DD; Thu, 7 Dec 2023 06:52:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01F73C433C9; Thu, 7 Dec 2023 06:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701931956; bh=lPKwF3kdsIYd1OD7+HVH5a6Y8sFi9im8Lkn4cxRrJdA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hri+49dv5qf8qMtGvCIX9NcHBndIBYnZTtrH4TYEmSEF1NYiHP2AUWVZ3gZ/SRsmV SXTLOywSocUr+gb5xP+4Fxple9klI1Im1gaVzZGD+Et8KEXEti9yFq+p8vugpHSjZy byWo0wzOLXMoz8Wuyyh/MXRdP6zVWu0L1wFkgMqc= Date: Thu, 7 Dec 2023 11:39:07 +0900 From: Greg Kroah-Hartman To: Umang Jain Cc: Stefan Wahren , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Dan Carpenter , Kieran Bingham , "Ricardo B . Marliere" Subject: Re: [PATCH v3 1/4] staging: vc04_services: Drop vchiq_log_error() in favour of dev_err Message-ID: <2023120750-engorge-wham-83a0@gregkh> References: <20231205084157.73819-1-umang.jain@ideasonboard.com> <20231205084157.73819-2-umang.jain@ideasonboard.com> <6a8566c0-bd26-4ec1-9f7d-d58bbed8411c@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6a8566c0-bd26-4ec1-9f7d-d58bbed8411c@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231206_225239_386745_618F4AA4 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 06, 2023 at 10:57:59AM +0530, Umang Jain wrote: > Hi Stefan > > On 12/6/23 1:02 AM, Stefan Wahren wrote: > > Hi Umang, > > > > Am 05.12.23 um 09:41 schrieb Umang Jain: > > > Drop vchiq_log_error() macro which wraps dev_dbg(). Introduce the usage > > > of dev_err() directly. > > sorry, i missed to review the last change. So the change won't be that > > trivial. > > All the changes you said are valid and I have taken a note of it. > > However, I think it would best that if we can address them in a separate > series on top of this (and I will do it). It would seem to be streamlined on > top of this. Agreed, I'll merge this now so you can make forward progress here, thanks! greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel