From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18E34C10DCE for ; Fri, 8 Dec 2023 08:14:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KZBhsqad+PGVLQCHe+iwC06entf9sepMezkLqFKudPs=; b=lJP9fqtApKuHOB IzI/Wgy+ILpmX4TbIe7YikvHljn4JOMeqaaxSOKQgXGSLMbsZruFh/HKaGVhZcbXWDAyAudGe/PY1 iJahGT6J95WysBt7z0Y4v3fyPu6m3qTe6zsU8uaKHhrV2Zg8TUUnjHQ/lrdwJlAxkoDm3D62rfxpi oHiTRT6BrKHETO7BTqHzliGeWo5YgyGKYRmXV0fZWzKqEeNw8xaeRBjKP4S00sQIJNWKN/YeBPRES fv5hwoBhtfzLuC5tfEIBvArYssBBbm7Qs9T0j8KWH/2U47ziq7ZAsjx5nu3/T5ASz2oGiqPcsXb4J KHXICUXBdEIcQDwg5mmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBW06-00F1RN-27; Fri, 08 Dec 2023 08:14:22 +0000 Received: from relay1-d.mail.gandi.net ([217.70.183.193]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBW02-00F1Qh-01 for linux-arm-kernel@lists.infradead.org; Fri, 08 Dec 2023 08:14:20 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 9B305240006; Fri, 8 Dec 2023 08:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1702023251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pNpi/zPSL34A2AILSCeVZYzKaahG4aVQbHxXFOHl7us=; b=NPzuoQm6kvXR/VoPhuUdv5yNuJM0Vve3pRFYfIM9SThj/jhXGhqq0IDkkRv2loRg/gUDD0 FQ68ceCavrKcAlS55WZELcguty0dSsStu+4D+/5EbBnWgmMrnLtwbBdRF5ZzFrv0GY6Cgq wHeA1r/5LPGre48RbaZH6s+iJoFP209UeZJ1eBCfKFjREC2wU8+hFRrEZP71JWacsRYm/6 TeWbEOmDu4BPfLJxbyaB9RWcKsGktVGmz5rV1IpnS09YNN+T4+r4sDu3VNU7STgvYgel9D i4uVk9ui9qJ1I2UylkvZZxj4zoDabACcKWwZfN9nWspkHZcpSNQ6hlj2cWC9WQ== Date: Fri, 8 Dec 2023 09:14:08 +0100 From: Maxime Chevallier To: Jiangfeng Ma Cc: Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Simon Horman , Andrew Halaney , Bartosz Golaszewski , Shenwei Wang , Johannes Zink , "Russell King (Oracle" , Jochen Henneberg , "open list:STMMAC ETHERNET DRIVER" , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" , open list , James Li , Martin McKenny Subject: Re: [PATCH] net:stmmac:stmmac_platform:Add snps,xpcs devicetree parsing Message-ID: <20231208091408.071680db@device.home> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_001418_345135_75D5113B X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Fri, 8 Dec 2023 07:02:19 +0000 Jiangfeng Ma wrote: > In order to setup xpcs, has_xpcs must be set to a non-zero value. > Add new optional devicetree properties representing this. > > If has_xpcs is set to true, then xpcs_an_inband should preferably be > consistent with it, Otherwise, some errors may occur when starting > the network, For example, the phy interface that xpcs already supports, > but link up fails. Can you elaborate on why you need this, and on which platform especially ? Usually drivers for the various stmmac variants know if they have XPCS or not, or can guess it based on some info such as the configured PHY mode (dwmac-intel). Besides that, there are a few issues with your submission. If DT is the way to go (and I don't say it is), you would also need to update the bindings to document that property. > The types of has_xpcs and xpcs_an_inband are unsigned int, > and generally used as flags. So it may be more reasonable to set them to > bool type. This can also be confirmed from the type of @ovr_an_inband. And this part would go into a separate patch. Thanks, Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel