From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31C48C4167B for ; Fri, 8 Dec 2023 20:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uGX/qadMUMISmciKIyf8EbOBM+c+EgsVJuYaDSLZgB8=; b=3J8jaN4UwvCL0B 6CV+9Clbun3TM/wKL4mL6wENZitVk/uqgzo1T2xDipY9KpoZLHZ5L+B5FijVuJiy1yB7xbeH7vPsA WBHkos9cazZj41MVLjbYatKZ2JPgwHS435Nm1IstNwcIk/R9RlnD6J4PqYtS27a2wXJKFogdSqxtw 1YvJmSGT0Vw9E/0bczbrotNL7XTR+5G+6WBv4OZyfS1uMPeTKqk8NP3lg58N0PV4+lI8lm1scpJoY p18uVuYZ9Vo4QCnJ4cEiPDsdgajdKB4ANW1g8EFMnJdW7wV1dwmnY58u/j5wTlzAy5WVtPaix4I6Y MMdMH5l/rajt/b+SLanQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBht3-00GY39-1M; Fri, 08 Dec 2023 20:55:53 +0000 Received: from mail-oa1-f47.google.com ([209.85.160.47]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBht0-00GY2f-14 for linux-arm-kernel@lists.infradead.org; Fri, 08 Dec 2023 20:55:51 +0000 Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-1fb9a22b4a7so1407038fac.3 for ; Fri, 08 Dec 2023 12:55:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702068947; x=1702673747; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PMCsypl2ZT72XEQ1sjBx4SYxL9BLD+/SCpdSyBKF+9U=; b=vmDMs0Eoe+jyuzTdzgDO0TB2MLgsa2ImgeIF6jmHst9jN2NobQJkaSWh3dvgI7aStw lSk0QyArgdQ+h1dXU0js13OhyDs6kXj+giug6mDv7UTHCpwYMuDnhEAr79aqRRVqehnR ez5CUUi2XYvGXNWhZEcOtuFtk3bb/RCLSRMKxE8JD4OJEKjgDw9ESwjSEjGJHvSCiUad kxom2cNCI+/gRZ1jydciTFNOBqjIfK0k50v21i9Haqm5jNX+oierkbjlNtjsMT1AhU1u MabaOR6ziDTt6vdP9iLh1g1tzx/QFrgpscWGFoG0JeZWhX+G7e/MINApfDhju9xXWLdN jJvw== X-Gm-Message-State: AOJu0YysOP1Rnxj5HvKTp7NZ+ay4c8UEekA1/qmWyVBix9XBHE7W8DRS WPGWtM2Gy9Go2CRLzdTbOg== X-Google-Smtp-Source: AGHT+IEM3W8bj6pCSZdoh31Dhf5GcoLTyMBgsjsntSWQNdWLjtVS0QQY0sWp8TeQp0Rvl9Geo4c9xg== X-Received: by 2002:a05:6871:a687:b0:1fb:75b:99b6 with SMTP id wh7-20020a056871a68700b001fb075b99b6mr800153oab.101.1702068946995; Fri, 08 Dec 2023 12:55:46 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id r6-20020a9d7506000000b006ce2fce83cbsm445837otk.25.2023.12.08.12.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Dec 2023 12:55:46 -0800 (PST) Received: (nullmailer pid 2687032 invoked by uid 1000); Fri, 08 Dec 2023 20:55:45 -0000 Date: Fri, 8 Dec 2023 14:55:45 -0600 From: Rob Herring To: Lucas Stach Cc: Sherry Sun , hongxing.zhu@nxp.com, lpieralisi@kernel.org, kw@linux.com, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] dt-bindings: imx6q-pcie: Add host-wake-gpio property Message-ID: <20231208205545.GA2675840-robh@kernel.org> References: <20231208091355.1417292-1-sherry.sun@nxp.com> <20231208091355.1417292-3-sherry.sun@nxp.com> <83ca3d88cdaa7bc6e6bd3c4e88518b155a6b0f05.camel@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <83ca3d88cdaa7bc6e6bd3c4e88518b155a6b0f05.camel@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231208_125550_389592_80E5B7BA X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 08, 2023 at 11:00:19AM +0100, Lucas Stach wrote: > Hi Sherry, > > Am Freitag, dem 08.12.2023 um 17:13 +0800 schrieb Sherry Sun: > > Add host-wake-gpio property that can be used to wakeup the host > > processor. > > > > Signed-off-by: Sherry Sun > > Reviewed-by: Richard Zhu > > --- > > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > index 81bbb8728f0f..944f0f961809 100644 > > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > @@ -72,6 +72,10 @@ properties: > > L=operation state) (optional required). > > type: boolean > > > > + host-wake-gpio: > > There is only one wake signal in PCIe and it has a defined direction, > so there is no point in specifying that it is a host wakeup. Also GPIO > handles without a traling 's' are deprecated. So this should be > > wake-gpios Any standard PCI slot signals need to be documented in common PCI schema. And they should start going into root port nodes rather than the host bridge node because it's the root ports that correspond to slots rather than the host bridge. We've just taken shortcuts because many host bridges only have 1 root port. Note that I'm in the middle of splitting pci-bus.yaml into host bridge, PCI-PCI bridge (and RP), and common device schemas. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel