From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E752CC4167B for ; Sat, 9 Dec 2023 13:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e0CF1BcsQewGxSchaqIgLs5vObTPn+x9wARpb8NEMFc=; b=ucDno/V4gcGNUX 7+k4pbKKXgSb8d69FtNm53YlpdD5phghxIdnSAa/k4DnFmZUcvC9e9L7SeV46FTPBvqgNe3wRbQEJ t+gUxl8RDqUpEeaxbzUO4QFoF7kz1E4zSNkc6RNs9YniTiUyOpBqMrdzrLeFHhadx5uKJXHCsw5Ta Nvpnnk13LDWr1/8VVIPsljIpYfnEUFNNIfl6B9omciMTOnlvr/H/QnqVskRfm3ZMRvUvR8ofCRVFi bIX+bDqnaZF0WkeXwtziSOc1fdflmRO6sg/+YB+nscIgKfgb4eze/9CEOUOfcXrhC6u5CL8p1lDT5 xOpNS0OV1sUWyY4TnHMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rBxGH-0008As-0b; Sat, 09 Dec 2023 13:20:53 +0000 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rBxGD-0008AQ-2j for linux-arm-kernel@lists.infradead.org; Sat, 09 Dec 2023 13:20:51 +0000 Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-6d9d209c9bbso2240688a34.0 for ; Sat, 09 Dec 2023 05:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702128045; x=1702732845; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=VePj6vwLSXDAV0qP2LjptKWEglB5rSOdn2WJpe+1jfI=; b=P+UEYY7ObIJduFP3JNkNMlGZMWUwKXKYaFAQrLs+p9CySR2sbY4Ar/uTia2G44HdrN Juy8WJlKo2lA4PYKc3b8hzjm6M+ldvCiz3lQZJXZ85+BdPoix2wpVa3qpb9Cb98eT5iW 44HGRLJ7GN34R5x5LRDVzfgWZJ/qPmNH3ShYCtTD4VU1vzyIj09L36oMXijgDd4HKKUx bfM3jOtXe31J88WnBnHKRQF44TgUMTFcJe8DygxF/gUvNbbusN24yvKz/HoPAs+I24gJ Px8MbRPlHHTeNNLjHLXwxRrP+FxmGG5TBCAxlTqoVumvxr5SmeEmtmbodXdocrp7uTJh eTBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702128045; x=1702732845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VePj6vwLSXDAV0qP2LjptKWEglB5rSOdn2WJpe+1jfI=; b=VbV2An95oi7BGfSs6q4NM2bJU/2PqRcR1IHPW7GMuW59nMqL45DIHta3P43HH52TVt X0HUbZT41F+Cu/L+GmKMC4BSVqXNpEdX2LrDFBbijGxGdVSUCdL9ld+haUbi9hbX3A5m F0OEOlM6WxbLMu2JuVjPYyPwAnA7yyAfWpngoqCyS0dEMWvgT8h/2W6gDtXN1ymoiLZx DPvnnbMci5OCEo/5Xpjc10EFmFNpRwn6Oz/w8Id3l7g1iaMZWLTugOY/WIi4G+iK7cXC caDziuQ4Xsz1MYSJSngx5bXK2IByOH4VTG+WXWJ5BE14pBuNvKzP+irbzC/BDmfyQ1vZ cj1g== X-Gm-Message-State: AOJu0Yw2UBSTOQJFiNwHX4dFcAOopa4Cm52SFzJlPqEHx2Ve6m68W9zL BGa7Wc66ZQux2uLbaY8vd+s= X-Google-Smtp-Source: AGHT+IHdyODnm62KhJZGQU6mMn8/4s8/4vXFPYD/Xin2dz5g9MAaubreO35xGoUvvJ7/7SMz0tTXeg== X-Received: by 2002:a05:6358:249b:b0:170:9c26:cdfa with SMTP id m27-20020a056358249b00b001709c26cdfamr931127rwc.16.1702128044691; Sat, 09 Dec 2023 05:20:44 -0800 (PST) Received: from localhost ([36.155.101.145]) by smtp.gmail.com with ESMTPSA id o8-20020a62cd08000000b006ce6a0a4f22sm3483951pfg.11.2023.12.09.05.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 05:20:44 -0800 (PST) From: chenqiwu X-Google-Original-From: chenqiwu Date: Sat, 9 Dec 2023 21:20:38 +0800 To: Mark Rutland Cc: qiwuchen55@gmail.com, catalin.marinas@arm.com, will@kernel.org, kaleshsingh@google.com, mhiramat@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64: Add USER_STACKTRACE support Message-ID: <20231209132038.GA9628@rlk> References: <20231125072739.3151-1-qiwu.chen@transsion.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231209_052049_889936_7A192E7C X-CRM114-Status: GOOD ( 20.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 28, 2023 at 02:48:32PM +0000, Mark Rutland wrote: > On Fri, Nov 24, 2023 at 11:27:39PM -0800, qiwuchen55@gmail.com wrote: > > From: chenqiwu > > > > Use the perf_callchain_user() code as blueprint to implement > > arch_stack_walk_user() which add ftrace userstacktrace support > > on arm64. > > With this patch, tracer can get userstacktrace by below callchain: > > ftrace_trace_userstack -> > > stack_trace_save_user -> > > aasrch_stack_walk_user > > An example test case is as shown below: > > # cd /sys/kernel/debug/tracing > > # echo 1 > options/userstacktrace > > # echo 1 > options/sym-userobj > > # echo 1 > events/sched/sched_process_fork/enable > > # cat trace > > ...... > > bash-418 [000] ..... 121.820661: sched_process_fork: comm=bash pid=418 child_comm=bash child_pid=441 > > bash-418 [000] ..... 121.821340: > > => /lib/aarch64-linux-gnu/libc-2.32.so[+0xa76d8] > > => /bin/bash[+0x5f354] > > => /bin/bash[+0x47fe8] > > => /bin/bash[+0x493f8] > > => /bin/bash[+0x4aec4] > > => /bin/bash[+0x4c31c] > > => /bin/bash[+0x339b0] > > => /bin/bash[+0x322f8] > > > > changes in v2: > > - Remove useless arch_dump_user_stacktrace(). > > - Rework arch_stack_walk_user() implementation. > > - Modify the commit message. > > Tested-by: chenqiwu > > Signed-off-by: chenqiwu > > --- > > arch/arm64/Kconfig | 1 + > > arch/arm64/kernel/stacktrace.c | 120 +++++++++++++++++++++++++++++++++ > > 2 files changed, 121 insertions(+) > > Thanks for this, it looks much better than v1. > However, as I mentioned on v1, we want to have one copy of this code. > > Rather than just copying the logic from perf_callchain.c, please also update > perf_callchain_user() to use arch_stack_walk_user() and delete the redundant code. > > Thanks, > Mark. > Hi Mark, Thanks for your professional advice, I make an improvement in patch v3. Please help review this again: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20231129160119.60829-1-qiwu.chen@transsion.com/ Thanks Qiwu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel