From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D467C4167B for ; Mon, 11 Dec 2023 18:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0irDjR6mwoPneQKj/ub5rFRcmV3bunZXnvUF0WaC2uw=; b=GpGdZhY+o59tVN wdTsmy7EZ0NzA7H6YliAYvSzehGnW9Xc4WvCUm/jysOzVUQhXBttaSpXHIFAvoO0k8RR4ZKGYljuS XzZvPMR9yHxLAKPIX9FPLoErATXHaNYauFfKJHynuOTL9SUJo7pwcf2E7cDXG5vOnQSAZAwhnu1rt OeCnysglBrZVCDdKmrnUKeY/XHa4LicJW4gp3Q7zYQvSq3MXplFPOm1mJ7Rj2pCHBIp3YSr3TQRju O8SGE8lCq57DehYvBr50oMnfAExfXfN83ULnlm0scPs9MU9f9cHVsW1QpqqB0G1NYWke7ZCOBV3rn xaQKREghM8x43h8HSpGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCkof-006mCH-0i; Mon, 11 Dec 2023 18:15:41 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCkob-006m90-2D for linux-arm-kernel@lists.infradead.org; Mon, 11 Dec 2023 18:15:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 22381614D2; Mon, 11 Dec 2023 18:15:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9EDDC433C7; Mon, 11 Dec 2023 18:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702318535; bh=QrMJ9Vv7yAyhkvVCuIw3AcS5ZtY5Zo9TvtZGKmhgUVk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o951Ph+ILqUngQX2fnHwoJHxd5ECE8ZuIqtPvkdlFu7lMEMHH3yP9gv4Yc6I82Gfw L8DLyDDtcXAWd3HWFixv/XM00ypDCxaA9o1Jo35NMAuMRsswxTrWO91cBVvPFTjxbK vvd8P9GY3F5NMEwCbb5v7BhFmMAiTJ+iHdoSbA2rcvp8NXkQ4gXIM/0MWpLEvF6x8Z Vb2/eBKBMTHOrFSkzAPx6ZVm/qld4hBkqRyQyCE/Qjpy84fByihe3AKf6+L2tc3i5k A+m0zvoCTfBbvSTGFjxek24e7hq6wjznBvygjXKyslKPheoOSZjRsndJfbUPYT9vDN INUhGo8WnShHw== Date: Mon, 11 Dec 2023 18:15:30 +0000 From: Will Deacon To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Eric Auger , Moritz Fischer , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Shameer Kolothum Subject: Re: [PATCH v3 00/19] Update SMMUv3 to the modern iommu API (part 1/3) Message-ID: <20231211181529.GA26462@willie-the-truck> References: <0-v3-d794f8d934da+411a-smmuv3_newapi_p1_jgg@nvidia.com> <20231211180324.GA3012960@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231211180324.GA3012960@nvidia.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_101537_765388_54411B10 X-CRM114-Status: GOOD ( 20.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 11, 2023 at 02:03:24PM -0400, Jason Gunthorpe wrote: > On Tue, Dec 05, 2023 at 03:14:32PM -0400, Jason Gunthorpe wrote: > > All parts are on github: > > > > https://github.com/jgunthorpe/linux/commits/smmuv3_newapi > > > > v3: > > - Use some local variables in arm_smmu_get_step_for_sid() for clarity > > - White space and spelling changes > > - Commit message updates > > - Keep master->domain_head initialized to avoid a list_del corruption > > v2: https://lore.kernel.org/r/0-v2-de8b10590bf5+400-smmuv3_newapi_p1_jgg@nvidia.com > > - Rebased on v6.7-rc1 > > - Improve the comment for arm_smmu_write_entry_step() > > - Fix the botched memcmp > > - Document the spec justification for the SHCFG exclusion in used > > - Include STRTAB_STE_1_SHCFG for STRTAB_STE_0_CFG_S2_TRANS in used > > - WARN_ON for unknown STEs in used > > - Fix error unwind in arm_smmu_attach_dev() > > - Whitespace, spelling, and checkpatch related items > > v1: https://lore.kernel.org/r/0-v1-e289ca9121be+2be-smmuv3_newapi_p1_jgg@nvidia.com > > This hasn't changed significantly in the last three months, so I feel > done now. I think Eric may still have a formal Tested-by for his > Fujitsu system to record the run he did. > > Will, we are waiting for you to say something so we can shift review > and testing focus to part 2, ideally in January. Many people are > waiting for this. I'm sorry that you're waiting for me, but I'm snowed under with other changes and the arm64 tree is my priority at the moment. This series _is_ on my list and I appreciate that you've got some review, however the fact that you seem to be lacking any comments from the usual SMMU folks such as Robin and Jean-Philippe does make me worry about this series to the point that I'm not prepared just to pick it up without a thorough look. It sucks, but I don't know what else to tell you. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel