From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC34DC4332F for ; Tue, 12 Dec 2023 16:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Message-Id:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=031pIifZuM3Ul1IEc2/fAU8GQ1oyjjcHtrWjiIH5X3k=; b=Wy7FIfNJRrwS8l eCqhzNa0cqx+sJjZ8+M7DUu0PL72lsIvCKKRmzZFZ757IKVo8PQ7xWRjn5JAQETfb3HUkyjajl+OJ P8uTdVCi2W/mUz4ZWpvxrr0vbGPne5KunBTLjHPAszkEcXtMMitvYOgvqry7urRqyc8PT6WWbhaqx n5CwjOHIPwQCMCi52kLXoY8SsqL3D0iPJjBJkATkaJ9HEtcnx0Ka7WSMvvt5oj2DRO9KZRRrn536p 0PPKEJJ4NVHUJpsWfizp1niXbgnsg5TlTWgmGH44YvakhjAyJcOCoiQmB/Olo9IM51J7PawcD8jS6 jzjr7jFNoRqvcU7EFY7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD5bV-00CDLz-2O; Tue, 12 Dec 2023 16:27:29 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rD5bS-00CDKQ-21 for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 16:27:27 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 7BB49B81339; Tue, 12 Dec 2023 16:27:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1D207C433C7; Tue, 12 Dec 2023 16:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1702398443; bh=t3KKiYi0IdU2y9j91oE71YEklgKddavq7ESsXn9uET4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FmrX47b7FO9QssAD09a7oHhvNJ1/DSXBvjQ4RvCYchuZ6/sTAh9XBDG970mIzERJp TTo902Q+yAcmPS1hPuve25ZZ4rI0Mz6S66LXqWrUYSqaoCxBkx6XcimchzuR06NnkM fS3Q/VztSu9++JBc+V14I/GMbW9RQyg439T3PihA= Date: Tue, 12 Dec 2023 08:27:22 -0800 From: Andrew Morton To: Ryan Roberts Cc: David Hildenbrand , Matthew Wilcox , Yin Fengwei , Yu Zhao , Catalin Marinas , Anshuman Khandual , Yang Shi , "Huang, Ying" , Zi Yan , Luis Chamberlain , Itaru Kitayama , "Kirill A. Shutemov" , John Hubbard , David Rientjes , Vlastimil Babka , Hugh Dickins , Kefeng Wang , Barry Song <21cnbao@gmail.com>, Alistair Popple , linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Barry Song Subject: Re: [PATCH v9 03/10] mm: thp: Introduce multi-size THP sysfs interface Message-Id: <20231212082722.13e857daf589bd49d5e877d9@linux-foundation.org> In-Reply-To: References: <20231207161211.2374093-1-ryan.roberts@arm.com> <20231207161211.2374093-4-ryan.roberts@arm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_082726_818797_396D8E2E X-CRM114-Status: UNSURE ( 8.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 12 Dec 2023 15:32:29 +0000 Ryan Roberts wrote: > > Why not perform lock/unlock only once in surrounding code? :) > > I was nervous that sysfs_streq() may be unhappy in atomic context... Unfounded? > Yes, unfounded. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel