From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0F72C4332F for ; Tue, 12 Dec 2023 16:22:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=E1KbUBDEsKQ7WEguELLiIrLVqwcDtQ5D3WKcIdSpXoo=; b=zft4M88HtkmQKi DNtjsZ3amTQIEPn4HE8ziHR1TQN2pORPrPojhrjJou8cm2GWe2Kt26yCPUfryTmLJ/31NjzFOf2tX /1/dM0t9u0WbgX98RaPHZTJjsvuaRi2f/8blQFulvM0Yxm8BfEAvucpardDQGNOdMxNy/lemYr5nQ 12VChkb8qrw3e7RDrSe9LmWGepoLYxXStVLMh32TEdb1X8NJEWU/271z0uv1xfzy20FjWKYpHxViz vSjxXQ59zB4WtA2BADcOsMZOlineKsgkDUBBLSbDEMh6fWrjG74xNmwzDk855af9pmloj435ULu6+ /akKMpdW/Z4Il7Ou4vpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD5WV-00CCGW-0Z; Tue, 12 Dec 2023 16:22:19 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD5WR-00CCFP-0O for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 16:22:16 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66B36143D; Tue, 12 Dec 2023 08:22:56 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5BC0C3F738; Tue, 12 Dec 2023 08:22:08 -0800 (PST) Date: Tue, 12 Dec 2023 16:22:00 +0000 From: Andre Przywara To: Anne Macedo Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Allwinner sunXi SoC support), linux-sunxi@lists.linux.dev (open list:ARM/Allwinner sunXi SoC support), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] arm64: dts: allwinner: Orange Pi One Plus PHY support Message-ID: <20231212162200.10b3868b@donnerap.manchester.arm.com> In-Reply-To: <20231212122835.10850-2-retpolanne@posteo.net> References: <20231212122835.10850-2-retpolanne@posteo.net> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_082215_209257_ED9B1CA6 X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 12 Dec 2023 12:28:30 +0000 Anne Macedo wrote: Hi Anne, > Adds compatible values to mdio subnodes for Ethernet PHY representing > Realtek 8211 PHY to Orange Pi One Plus. So can you state why this would be needed? This is the RTL8211 ID, right? Which should be autodetected via MDIO. Looking back in my inbox you proposed this change before, for U-Boot, specifically, but I fail to find a solution or explanation what really happens here. Two Renesas .dts files have the same compatible, and the commit message talks about the reset line there, is this related? So can you please give some more background and explanation? That would be part of a good commit message anyway ("why", not "what"). Cheers, Andre > Signed-off-by: Anne Macedo > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts > index 29a081e72..7248ab72f 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts > @@ -37,7 +37,8 @@ &emac { > > &mdio { > ext_rgmii_phy: ethernet-phy@1 { > - compatible = "ethernet-phy-ieee802.3-c22"; > + compatible = "ethernet-phy-id001c.c915", > + "ethernet-phy-ieee802.3-c22"; > reg = <1>; > }; > }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel