From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28D2DC4332F for ; Tue, 12 Dec 2023 22:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Dczon7FxS9FIDiHyv42lkCJodx17hHQKCf6yIkWQICg=; b=V5x7k8HXC1qXPs z47PXrYZKG8QI8uDv37IDTRg7iCe8POQFQu0bb98yZWybYkSeBGkX7TwyqcBXu7N5eLodXbE9K2kv qVnGyI2usFpgpYOZoZCn2piH2iVtXkI7VoJp8jq71Rt2HesojnFYq5+onsLuhKhYrIWDsghisuGm1 3El8aqE7MRxiEKFaraWFjf+pl8fWyVwM30BEsFI1w8gcObq6QDDUMy/OEwNcEq3M1YgCymYOlJi9F B5sbLUPZYCR0KB33cwyoWG3qk44JMezNIKH5KJMk2x03g/+uEdmJ4PXyVTWfV441gXNrjeT6qcXQ2 gx6LLlWyKHI3O+gVEnGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDBUO-00CxKg-2n; Tue, 12 Dec 2023 22:44:32 +0000 Received: from mail-oo1-f41.google.com ([209.85.161.41]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDBUL-00CxKF-2z for linux-arm-kernel@lists.infradead.org; Tue, 12 Dec 2023 22:44:31 +0000 Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-590a2a963baso2522957eaf.2 for ; Tue, 12 Dec 2023 14:44:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702421068; x=1703025868; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VMphJ493+DciN8lLws8RSRlMD94qy0SoU2WP5DJOjj4=; b=j5MXjlODEoSnWynb/U2hGszophXZ609VpkFXsNdktedIU0EKD9ARwDNY/KEtHZwr2z 0+QIuMeXu+MVLlaf1ebLXJIeCZ6i/Jv6zsM5hh0/pPQboStbkUmrKMAUHYsHk7L5wXPt O+JoBbg/Ghxt0sE9BWguAAimwcmLCvrfXWHK/Nk/LF09oDMT6vOt1utwjEFU5T6ea1Iv cvY7sCQrldkxuSWYsJzFc3wcwhZtXgwfuGXe7g/wJcYDG/grX/F34OzgQa7o/r2WmLJc p2KFFlBO/SadLb0Rrbp2arNvRq6EigSrPH7va/soi44ysI6qCxvjyeO/dXFjgMlz8x2E 04IA== X-Gm-Message-State: AOJu0YwTdbiPRNJfAWCt/SaEjSshizFgGGYHEgi29anpOXqwD7PbPG02 SWmr3ONzTc/cHw1Llh3+2w== X-Google-Smtp-Source: AGHT+IFjb8zyZy6HgbNr/jID6qfej7EjNW9FQEisDXKCGMer4Y5UYOBAfKHQdPfu1aEWyVUhGqcagQ== X-Received: by 2002:a05:6808:148a:b0:3b9:ca51:5186 with SMTP id e10-20020a056808148a00b003b9ca515186mr7781124oiw.42.1702421068119; Tue, 12 Dec 2023 14:44:28 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id ct7-20020a056808360700b003b9fd2af1f1sm1970848oib.32.2023.12.12.14.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 14:44:27 -0800 (PST) Received: (nullmailer pid 2966246 invoked by uid 1000); Tue, 12 Dec 2023 22:44:26 -0000 Date: Tue, 12 Dec 2023 16:44:26 -0600 From: Rob Herring To: Frank Li Cc: bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v3 08/13] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string Message-ID: <20231212224426.GA2948988-robh@kernel.org> References: <20231211215842.134823-1-Frank.Li@nxp.com> <20231211215842.134823-9-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231211215842.134823-9-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_144429_969648_0FBE2D9E X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 11, 2023 at 04:58:37PM -0500, Frank Li wrote: > From: Richard Zhu > > Add i.MX95 PCIe "fsl,imx95-pcie" compatible string. > Add "atu" and "serdes" to reg-names. > > Signed-off-by: Richard Zhu > --- > > Notes: > Change from v2 to v3 > - Remove krzy's ACK tag > - Add condition check for imx95, which required more reg-names then old > platform, so need Krzy review again, > > Change from v1 to v2 > - add Krzy's ACK tag > > .../bindings/pci/fsl,imx6q-pcie.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > index 81bbb8728f0f9..b8fcf8258f031 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > @@ -29,6 +29,7 @@ properties: > - fsl,imx8mq-pcie > - fsl,imx8mm-pcie > - fsl,imx8mp-pcie > + - fsl,imx95-pcie > > reg: > items: > @@ -90,6 +91,22 @@ required: > allOf: > - $ref: /schemas/pci/snps,dw-pcie.yaml# > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > + - if: > + properties: > + compatible: > + enum: > + - fsl,imx95-pcie > + then: > + properties: > + reg: > + minItems: 4 > + reg-names: > + items: > + - const: dbi > + - const: serdes Did you test this? It should fail because 'serdes' would need to be added to snps,dw-pcie.yaml. Is this really not a separate phy block? A separate node would be ideal. If not, there's already a 'phy' name you can use here. We don't want more random names. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel