public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 1/3] ARM: dts: imx25: Pass I2C clock-names property
@ 2023-12-06 11:58 Fabio Estevam
  2023-12-06 11:58 ` [PATCH 2/3] ARM: dts: imx25-pdk: Pass #sound-dai-cells Fabio Estevam
  2023-12-06 11:58 ` [PATCH 3/3] ARM: dts: imx25/27-eukrea: Fix RTC node name Fabio Estevam
  0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-12-06 11:58 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Per i2c-imx.yaml, 'clock-names' is a required property.

Pass it to fix the following dt-schema warning:

imx25-pdk.dtb: i2c@43f80000: clock-names:0: 'ipg' was expected
	from schema $id: http://devicetree.org/schemas/i2c/i2c-imx.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx25.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx25.dtsi b/arch/arm/boot/dts/nxp/imx/imx25.dtsi
index 534c70b8d79d..21c968341b3c 100644
--- a/arch/arm/boot/dts/nxp/imx/imx25.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx25.dtsi
@@ -93,7 +93,7 @@ i2c1: i2c@43f80000 {
 				compatible = "fsl,imx25-i2c", "fsl,imx21-i2c";
 				reg = <0x43f80000 0x4000>;
 				clocks = <&clks 48>;
-				clock-names = "";
+				clock-names = "ipg";
 				interrupts = <3>;
 				status = "disabled";
 			};
@@ -104,7 +104,7 @@ i2c3: i2c@43f84000 {
 				compatible = "fsl,imx25-i2c", "fsl,imx21-i2c";
 				reg = <0x43f84000 0x4000>;
 				clocks = <&clks 48>;
-				clock-names = "";
+				clock-names = "ipg";
 				interrupts = <10>;
 				status = "disabled";
 			};
@@ -151,7 +151,7 @@ i2c2: i2c@43f98000 {
 				compatible = "fsl,imx25-i2c", "fsl,imx21-i2c";
 				reg = <0x43f98000 0x4000>;
 				clocks = <&clks 48>;
-				clock-names = "";
+				clock-names = "ipg";
 				interrupts = <4>;
 				status = "disabled";
 			};
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/3] ARM: dts: imx25-pdk: Pass #sound-dai-cells
  2023-12-06 11:58 [PATCH 1/3] ARM: dts: imx25: Pass I2C clock-names property Fabio Estevam
@ 2023-12-06 11:58 ` Fabio Estevam
  2023-12-13  9:10   ` Shawn Guo
  2023-12-06 11:58 ` [PATCH 3/3] ARM: dts: imx25/27-eukrea: Fix RTC node name Fabio Estevam
  1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2023-12-06 11:58 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Per sgtl5000.yaml, '#sound-dai-cells' is a required property.

Pass it to fix the following dt-schema warning:

imx25-pdk.dtb: sgtl5000@a: '#sound-dai-cells' is a required property
	from schema $id: http://devicetree.org/schemas/sound/sgtl5000.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx25-pdk.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/nxp/imx/imx25-pdk.dts b/arch/arm/boot/dts/nxp/imx/imx25-pdk.dts
index 04f4b127a172..14a61dc1e742 100644
--- a/arch/arm/boot/dts/nxp/imx/imx25-pdk.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx25-pdk.dts
@@ -122,6 +122,7 @@ &i2c1 {
 	codec: sgtl5000@a {
 		compatible = "fsl,sgtl5000";
 		reg = <0x0a>;
+		 #sound-dai-cells = <0>;
 		clocks = <&clks 129>;
 		VDDA-supply = <&reg_2p5v>;
 		VDDIO-supply = <&reg_3p3v>;
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3/3] ARM: dts: imx25/27-eukrea: Fix RTC node name
  2023-12-06 11:58 [PATCH 1/3] ARM: dts: imx25: Pass I2C clock-names property Fabio Estevam
  2023-12-06 11:58 ` [PATCH 2/3] ARM: dts: imx25-pdk: Pass #sound-dai-cells Fabio Estevam
@ 2023-12-06 11:58 ` Fabio Estevam
  1 sibling, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2023-12-06 11:58 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Node names should be generic. Use 'rtc' as node name to fix
the following dt-schema warning:

imx25-eukrea-mbimxsd25-baseboard.dtb: pcf8563@51: $nodename:0: 'pcf8563@51' does not match '^rtc(@.*|-([0-9]|[1-9][0-9]+))?$'
	from schema $id: http://devicetree.org/schemas/rtc/nxp,pcf8563.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx25-eukrea-cpuimx25.dtsi | 2 +-
 arch/arm/boot/dts/nxp/imx/imx27-eukrea-cpuimx27.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx25-eukrea-cpuimx25.dtsi b/arch/arm/boot/dts/nxp/imx/imx25-eukrea-cpuimx25.dtsi
index 0703f62d10d1..93a6e4e680b4 100644
--- a/arch/arm/boot/dts/nxp/imx/imx25-eukrea-cpuimx25.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx25-eukrea-cpuimx25.dtsi
@@ -27,7 +27,7 @@ &i2c1 {
 	pinctrl-0 = <&pinctrl_i2c1>;
 	status = "okay";
 
-	pcf8563@51 {
+	rtc@51 {
 		compatible = "nxp,pcf8563";
 		reg = <0x51>;
 	};
diff --git a/arch/arm/boot/dts/nxp/imx/imx27-eukrea-cpuimx27.dtsi b/arch/arm/boot/dts/nxp/imx/imx27-eukrea-cpuimx27.dtsi
index 74110bbcd9d4..4b83e2918b55 100644
--- a/arch/arm/boot/dts/nxp/imx/imx27-eukrea-cpuimx27.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx27-eukrea-cpuimx27.dtsi
@@ -33,7 +33,7 @@ &i2c1 {
 	pinctrl-0 = <&pinctrl_i2c1>;
 	status = "okay";
 
-	pcf8563@51 {
+	rtc@51 {
 		compatible = "nxp,pcf8563";
 		reg = <0x51>;
 	};
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/3] ARM: dts: imx25-pdk: Pass #sound-dai-cells
  2023-12-06 11:58 ` [PATCH 2/3] ARM: dts: imx25-pdk: Pass #sound-dai-cells Fabio Estevam
@ 2023-12-13  9:10   ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2023-12-13  9:10 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-arm-kernel, Fabio Estevam

On Wed, Dec 06, 2023 at 08:58:25AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per sgtl5000.yaml, '#sound-dai-cells' is a required property.
> 
> Pass it to fix the following dt-schema warning:
> 
> imx25-pdk.dtb: sgtl5000@a: '#sound-dai-cells' is a required property
> 	from schema $id: http://devicetree.org/schemas/sound/sgtl5000.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm/boot/dts/nxp/imx/imx25-pdk.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx25-pdk.dts b/arch/arm/boot/dts/nxp/imx/imx25-pdk.dts
> index 04f4b127a172..14a61dc1e742 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx25-pdk.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx25-pdk.dts
> @@ -122,6 +122,7 @@ &i2c1 {
>  	codec: sgtl5000@a {
>  		compatible = "fsl,sgtl5000";
>  		reg = <0x0a>;
> +		 #sound-dai-cells = <0>;

There is a white space.

Fixed it up and applied all 3 patches.

Shawn

>  		clocks = <&clks 129>;
>  		VDDA-supply = <&reg_2p5v>;
>  		VDDIO-supply = <&reg_3p3v>;
> -- 
> 2.34.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-12-13  9:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-06 11:58 [PATCH 1/3] ARM: dts: imx25: Pass I2C clock-names property Fabio Estevam
2023-12-06 11:58 ` [PATCH 2/3] ARM: dts: imx25-pdk: Pass #sound-dai-cells Fabio Estevam
2023-12-13  9:10   ` Shawn Guo
2023-12-06 11:58 ` [PATCH 3/3] ARM: dts: imx25/27-eukrea: Fix RTC node name Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox