From: Will Deacon <will@kernel.org>
To: Samuel Holland <samuel.holland@sifive.com>, ardb@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
linux-riscv@lists.infradead.org,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
linux-arch@vger.kernel.org
Subject: Re: [RFC PATCH 04/12] arm64: Implement ARCH_HAS_KERNEL_FPU_SUPPORT
Date: Wed, 13 Dec 2023 16:19:44 +0000 [thread overview]
Message-ID: <20231213161944.GA32062@willie-the-truck> (raw)
In-Reply-To: <20231208055501.2916202-5-samuel.holland@sifive.com>
On Thu, Dec 07, 2023 at 09:54:34PM -0800, Samuel Holland wrote:
> arm64 provides an equivalent to the common kernel-mode FPU API, but in a
> different header and using different function names. Add a wrapper
> header, and export CFLAGS adjustments as found in lib/raid6/Makefile.
>
> Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
> ---
>
> arch/arm64/Kconfig | 1 +
> arch/arm64/Makefile | 9 ++++++++-
> arch/arm64/include/asm/fpu.h | 17 +++++++++++++++++
> 3 files changed, 26 insertions(+), 1 deletion(-)
> create mode 100644 arch/arm64/include/asm/fpu.h
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 7b071a00425d..485ac389ac11 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -30,6 +30,7 @@ config ARM64
> select ARCH_HAS_GCOV_PROFILE_ALL
> select ARCH_HAS_GIGANTIC_PAGE
> select ARCH_HAS_KCOV
> + select ARCH_HAS_KERNEL_FPU_SUPPORT if KERNEL_MODE_NEON
> select ARCH_HAS_KEEPINITRD
> select ARCH_HAS_MEMBARRIER_SYNC_CORE
> select ARCH_HAS_NMI_SAFE_THIS_CPU_OPS
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index 9a2d3723cd0f..4a65f24c7998 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -36,7 +36,14 @@ ifeq ($(CONFIG_BROKEN_GAS_INST),y)
> $(warning Detected assembler with broken .inst; disassembly will be unreliable)
> endif
>
> -KBUILD_CFLAGS += -mgeneral-regs-only \
> +# The GCC option -ffreestanding is required in order to compile code containing
> +# ARM/NEON intrinsics in a non C99-compliant environment (such as the kernel)
> +CC_FLAGS_FPU := -ffreestanding
> +# Enable <arm_neon.h>
> +CC_FLAGS_FPU += -isystem $(shell $(CC) -print-file-name=include)
> +CC_FLAGS_NO_FPU := -mgeneral-regs-only
> +
> +KBUILD_CFLAGS += $(CC_FLAGS_NO_FPU) \
> $(compat_vdso) $(cc_has_k_constraint)
> KBUILD_CFLAGS += $(call cc-disable-warning, psabi)
> KBUILD_AFLAGS += $(compat_vdso)
Can you use this to replace the same logic in arch/arm64/lib/Makefile,
like you do for arch/arm/?
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-13 16:20 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 5:54 [RFC PATCH 00/12] Unified cross-architecture kernel-mode FPU API Samuel Holland
2023-12-08 5:54 ` [RFC PATCH 01/12] arch: Add ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2023-12-11 16:02 ` Christoph Hellwig
2023-12-08 5:54 ` [RFC PATCH 02/12] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2023-12-11 16:04 ` Christoph Hellwig
2023-12-08 5:54 ` [RFC PATCH 03/12] ARM: crypto: Use CC_FLAGS_FPU for NEON CFLAGS Samuel Holland
2023-12-11 16:04 ` Christoph Hellwig
2023-12-08 5:54 ` [RFC PATCH 04/12] arm64: Implement ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2023-12-11 16:05 ` Christoph Hellwig
2023-12-13 16:19 ` Will Deacon [this message]
2023-12-08 5:54 ` [RFC PATCH 05/12] lib/raid6: Use CC_FLAGS_FPU for NEON CFLAGS Samuel Holland
2023-12-11 16:07 ` Christoph Hellwig
2023-12-11 16:12 ` Samuel Holland
2023-12-12 7:11 ` Christoph Hellwig
2023-12-08 5:54 ` [RFC PATCH 06/12] LoongArch: Implement ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2023-12-11 16:07 ` Christoph Hellwig
2023-12-13 16:13 ` WANG Xuerui
2023-12-08 5:54 ` [RFC PATCH 07/12] powerpc: " Samuel Holland
2023-12-11 16:08 ` Christoph Hellwig
2023-12-08 5:54 ` [RFC PATCH 08/12] x86: " Samuel Holland
2023-12-11 16:08 ` Christoph Hellwig
2023-12-08 5:54 ` [RFC PATCH 09/12] riscv: Add support for kernel-mode FPU Samuel Holland
2023-12-11 16:11 ` Christoph Hellwig
2023-12-11 16:16 ` Samuel Holland
2023-12-08 5:54 ` [RFC PATCH 10/12] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2023-12-11 12:23 ` Michael Ellerman
2023-12-14 1:03 ` Samuel Holland
2023-12-14 3:13 ` Timothy Pearson
2023-12-14 4:45 ` Michael Ellerman
2023-12-08 5:54 ` [RFC PATCH 11/12] selftests/fpu: Move FP code to a separate translation unit Samuel Holland
2023-12-11 16:18 ` Christoph Hellwig
2023-12-08 5:54 ` [RFC PATCH 12/12] selftests/fpu: Allow building on other architectures Samuel Holland
2023-12-11 16:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231213161944.GA32062@willie-the-truck \
--to=will@kernel.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ardb@kernel.org \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=samuel.holland@sifive.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).