From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A71A1C4332F for ; Wed, 13 Dec 2023 19:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=E/cs4W9EcMaWmPQx0j325CWlyzrMYQblNsc01/cD29A=; b=OVMx7IjBHx8rxR S4oZMqCZLmTOBxGLKQK+AzLbG1cTurUO3FCX6Obv+kuI/OfC9mutKj5XMY83/atfzrINovVNt5UW0 3RPVJRvWJroOmiYQBrywrFgD2nQFwlj3ur23trt6VjqiOhRliM7VNuzSOESJM1ea273io1Q7bHu63 oD0Itq7L/8w9TPcxa4+ZuSNHkgtFeFy9b1Ql0PC+t5tqtsFOJDquBFjsAWJXA45sSbKu79354X47c RdMrbZtfuAuJPaXzkSSWv2Oieh8fcQ3wZxB75f4A0aWrHh4TDZ7trr4DEZm4o6OWSMw6ETUHK/wuu KFvBR+vkQU8bnLNRko0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDVMb-00FubM-0g; Wed, 13 Dec 2023 19:57:49 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDVMY-00FuaX-1T for linux-arm-kernel@lists.infradead.org; Wed, 13 Dec 2023 19:57:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9B48C61F20; Wed, 13 Dec 2023 19:57:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F1EAC433C8; Wed, 13 Dec 2023 19:57:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702497465; bh=nI+LIVGF1GW7NDDMlrV2VjRUQx18LLMDaUCPSY9bsk4=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=T/X7bD8Jdh2xNZJR9uEBE9z06LT3goHniJiJc9mJdPPiqHfM0zJc7/DNwrRy9wZiH 8rhNzHcJ6SZLYAP9uK2URisV21Mii3Zpo+2Z0FjpDu9HhrSvP+lxHe8o440jLyHuuR 6YTkIpYoySP0HztG3rLgKwr0gsOxJrlf8QCUDD6YsNFwrInY6yiM3VHhBCqmm4cy70 OtFEl4RuQNBLI4qB5J/QPoRjSiuaFAkRYXGSb2+fCZ+vximrVbCW00AGuHpZYMaBEZ j4+mT9CVm4BeHJ4rojA7e6HpiGKA/78QeRW5Jh8UR/EHwgSdNhYs/wkwLFCzbDhGok kqw5LVzRREbkQ== Date: Wed, 13 Dec 2023 13:57:43 -0600 From: Bjorn Helgaas To: Sherry Sun Cc: hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/4] PCI: imx6: Add pci host wakeup support on imx platforms. Message-ID: <20231213195743.GA1055303@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231213092850.1706042-2-sherry.sun@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_115746_558495_10786E04 X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Drop period at the end of subject line. It only adds the possibility of unnecessary line wrapping in git log. On Wed, Dec 13, 2023 at 05:28:47PM +0800, Sherry Sun wrote: > Add pci host wakeup feature for imx platforms. s/pci/PCI/ s/imx/i.MX/ (based on how nxp.com web pages refer to it) > Example of configuring the corresponding dts property under the PCI > node: > wake-gpios = <&gpio5 21 GPIO_ACTIVE_LOW>; Add newline between paragraphs or wrap into a single paragraph. > + /* host wakeup support */ > + imx6_pcie->host_wake_irq = -1; AFAIK, 0 is an invalid IRQ value. So why not drop this assignment since imx6_pcie->host_wake_irq is 0 by default since it was allocated with devm_kzalloc(), and test like this elsewhere: if (imx6_pcie->host_wake_irq) { enable_irq_wake(imx6_pcie->host_wake_irq) > + host_wake_gpio = devm_gpiod_get_optional(dev, "wake", GPIOD_IN); > + if (IS_ERR(host_wake_gpio)) > + return PTR_ERR(host_wake_gpio); > + > + if (host_wake_gpio != NULL) { if (host_wake_gpio) Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel