From: Shawn Guo <shawnguo@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: jun.li@nxp.com, linux-arm-kernel@lists.infradead.org,
Fabio Estevam <festevam@denx.de>
Subject: Re: [PATCH] arm64: dts: imx8qxp-mek: Move port under USB connector
Date: Thu, 14 Dec 2023 11:01:38 +0800 [thread overview]
Message-ID: <20231214030138.GE270430@dragon> (raw)
In-Reply-To: <20231211214054.570295-1-festevam@gmail.com>
On Mon, Dec 11, 2023 at 06:40:54PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
>
> Per nxp,ptn5110.yaml, 'port' should be placed under 'connector'.
>
> Do as requested to fix the following dt-schema warning:
>
> imx8qxp-mek.dtb: tcpc@50: connector:ports: 'port@0' is a required property
> from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#
> imx8qxp-mek.dtb: tcpc@50: connector: Unevaluated properties are not allowed ('ports' was unexpected)
> from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index 6c3d8715bc11..096f9501fa32 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -152,12 +152,6 @@ ptn5110: tcpc@50 {
> interrupt-parent = <&lsio_gpio1>;
> interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>
> - port {
> - typec_dr_sw: endpoint {
> - remote-endpoint = <&usb3_drd_sw>;
> - };
> - };
> -
> usb_con1: connector {
> compatible = "usb-c-connector";
> label = "USB-C";
> @@ -169,6 +163,13 @@ ports {
> #address-cells = <1>;
> #size-cells = <0>;
>
> + port@0 {
> + reg = <0>;
Have a newline between properties and child node.
Shawn
> + typec_dr_sw: endpoint {
> + remote-endpoint = <&usb3_drd_sw>;
> + };
> + };
> +
> port@1 {
> reg = <1>;
> typec_con_ss: endpoint {
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-12-14 3:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 21:40 [PATCH] arm64: dts: imx8qxp-mek: Move port under USB connector Fabio Estevam
2023-12-14 3:01 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231214030138.GE270430@dragon \
--to=shawnguo@kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=jun.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox