[PATCH] arm64: dts: imx8qxp-mek: Move port under USB connector

[PATCH] arm64: dts: imx8qxp-mek: Move port under USB connector

[Fabio Estevam]

From: Fabio Estevam <festevam@denx.de>

Per nxp,ptn5110.yaml, 'port' should be placed under 'connector'.

Do as requested to fix the following dt-schema warning:

imx8qxp-mek.dtb: tcpc@50: connector:ports: 'port@0' is a required property
	from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#
imx8qxp-mek.dtb: tcpc@50: connector: Unevaluated properties are not allowed ('ports' was unexpected)
	from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index 6c3d8715bc11..096f9501fa32 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -152,12 +152,6 @@ ptn5110: tcpc@50 {
 		interrupt-parent = <&lsio_gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
 
-		port {
-			typec_dr_sw: endpoint {
-				remote-endpoint = <&usb3_drd_sw>;
-			};
-		};
-
 		usb_con1: connector {
 			compatible = "usb-c-connector";
 			label = "USB-C";
@@ -169,6 +163,13 @@ ports {
 				#address-cells = <1>;
 				#size-cells = <0>;
 
+				port@0 {
+					reg = <0>;
+					typec_dr_sw: endpoint {
+						remote-endpoint = <&usb3_drd_sw>;
+					};
+				};
+
 				port@1 {
 					reg = <1>;
 					typec_con_ss: endpoint {
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8qxp-mek: Move port under USB connector

[Shawn Guo]

On Mon, Dec 11, 2023 at 06:40:54PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per nxp,ptn5110.yaml, 'port' should be placed under 'connector'.
> 
> Do as requested to fix the following dt-schema warning:
> 
> imx8qxp-mek.dtb: tcpc@50: connector:ports: 'port@0' is a required property
> 	from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#
> imx8qxp-mek.dtb: tcpc@50: connector: Unevaluated properties are not allowed ('ports' was unexpected)
> 	from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> index 6c3d8715bc11..096f9501fa32 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
> @@ -152,12 +152,6 @@ ptn5110: tcpc@50 {
>  		interrupt-parent = <&lsio_gpio1>;
>  		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
>  
> -		port {
> -			typec_dr_sw: endpoint {
> -				remote-endpoint = <&usb3_drd_sw>;
> -			};
> -		};
> -
>  		usb_con1: connector {
>  			compatible = "usb-c-connector";
>  			label = "USB-C";
> @@ -169,6 +163,13 @@ ports {
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  
> +				port@0 {
> +					reg = <0>;

Have a newline between properties and child node.

Shawn

> +					typec_dr_sw: endpoint {
> +						remote-endpoint = <&usb3_drd_sw>;
> +					};
> +				};
> +
>  				port@1 {
>  					reg = <1>;
>  					typec_con_ss: endpoint {
> -- 
> 2.34.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel