From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B850C35274 for ; Fri, 15 Dec 2023 14:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Uj0iq58RdxhC41BiJu/sfyccP6pgQtum3fKee08gyPQ=; b=qpCsKbXcP76WXq MubGj363QRNOR8L+fvHuVChitwTImgJJ9roQQgSKuhhHO45wj4Mg4/O9YA1/c6o/DvDxD1vh/QlfP JK95/fefbFSt+e9O0BR5mpLT825ngi4JlFZyuB6YhAWzHq+LPfDeg0ULeRl8zurLrDBBRUsGDZwn6 H4yf/m0dQcP/wH+plRd5mL00xagOfYH+I4f3j1T0OMCBG72qM5h+9dX3JOT0wLza8+K7+/gXUIkNk H6/Q82m+e6in8tF8eXJrPwNb0mwiRZ1nkFCP5rrF+DvS9+ARszhDknqDVedEpy7I1CZFnQrzU4Eb9 Nxdx+IJ9hxjmwNe1ntnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rE987-003YQE-0x; Fri, 15 Dec 2023 14:25:31 +0000 Received: from mail-yb1-xb2e.google.com ([2607:f8b0:4864:20::b2e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rE983-003YOa-1s for linux-arm-kernel@lists.infradead.org; Fri, 15 Dec 2023 14:25:29 +0000 Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-dbcfb7e8ad0so477242276.1 for ; Fri, 15 Dec 2023 06:25:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1702650322; x=1703255122; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JLnA5rSYzPIAAl0je5uwHtUY4VWmczr+QgP/lK2DYkA=; b=msoUXid5dcUIz3q6h8K75R6ytXYsKBb1YWrgx4U2foOOMvOS9+WgM4G03bPGquWM6r PulHBzWEkx6z5B14+k+fjs7NIAiOvcjONmyHO9bK8SeX88nLZKHvs4j3KZ7ktRn/tqtZ 0vdOkPcyM0xOhqyjSoih86G+7da5ivJsReYaVyJ7oOgkRRnG9xYhkasIDTYOVomCKmbo I77HuN+qVTUBgIjMCWZqB2p02BcVlELj3Fku86rva09kV+B+vW2uIm+H40WjrTwihtPR sbXdWt+ZZRmCKIOgiEWkSAef6JaiMwW2+lP+5bjvWoIdxhIpp78/Z7uQS7WRDFaHVsee A7YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702650322; x=1703255122; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JLnA5rSYzPIAAl0je5uwHtUY4VWmczr+QgP/lK2DYkA=; b=eP7hcpDcVzde4RyyogFCPc8abSaNZSDhqnbhLpnk58wpMSqNQeEYJeVSuPuwDlMLCy bJAof1I6TLMzENRaXz5ALIjhAKvPGTLZCa7zIc+N0pOuwnfEnNzf25U4YnJFxdeh+J6P DXsrSDuxQdS7t29TCyYVIRS8Fe3NsqKLSqthNq5HbTUKGyKOSJYDDns7SkD6dCmzJXWw 1RZ2RGY/EY1DxOwefplR/i2su4vlwFWLtlpXYn0tsiQgW7ixdb7aA8VU8VndDVbr1hta fLVawv3v0Qe4sXmE4ogTKHK7qUjgOhIfh+6rhQ3n1hF2NGlCSTvJbPlh8DP+QbU1dks1 gyqw== X-Gm-Message-State: AOJu0YysaYVFdSzW1Y1kTIYUMk6GbSdIE0Ovo87K5Drrz7ksM7lqmo/r ZSVn+jsplJz97o54d1/cyYgIPw== X-Google-Smtp-Source: AGHT+IHnJB/KDIokrzWKohQehR/NeMml2dmJtTXV0wg4aLiJiRNWrNv+Ip1zFTdJe+Fu3kZtlusIKQ== X-Received: by 2002:a25:8a0a:0:b0:db7:dacf:ed87 with SMTP id g10-20020a258a0a000000b00db7dacfed87mr6945407ybl.104.1702650322364; Fri, 15 Dec 2023 06:25:22 -0800 (PST) Received: from localhost (076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id k15-20020a056902024f00b00d89679f6d22sm5394138ybs.64.2023.12.15.06.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 06:25:21 -0800 (PST) Date: Fri, 15 Dec 2023 09:25:20 -0500 From: Josef Bacik To: Simon Glass Cc: catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: properly install vmlinuz.efi Message-ID: <20231215142520.GA683314@perftesting> References: <6edb1402769c2c14c4fbef8f7eaedb3167558789.1702570674.git.josef@toxicpanda.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231215_062527_844705_8952D100 X-CRM114-Status: GOOD ( 31.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 14, 2023 at 01:12:13PM -0700, Simon Glass wrote: > Hi Josef, > > On Thu, 14 Dec 2023 at 09:19, Josef Bacik wrote: > > > > If you select CONFIG_EFI_ZBOOT, we will generate vmlinuz.efi, and then > > when we go to install the kernel we'll install the vmlinux instead > > because install.sh only recognizes Image.gz as wanting the compressed > > install image. With CONFIG_EFI_ZBOOT we don't get the proper kernel > > installed, which means it doesn't boot, which makes for a very confused > > and subsequently angry kernel developer. > > > > Fix this by properly installing our compressed kernel if we've enabled > > CONFIG_EFI_ZBOOT. > > > > Signed-off-by: Josef Bacik > > --- > > arch/arm64/boot/install.sh | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/install.sh b/arch/arm64/boot/install.sh > > index 7399d706967a..9b7a09808a3d 100755 > > --- a/arch/arm64/boot/install.sh > > +++ b/arch/arm64/boot/install.sh > > @@ -17,7 +17,8 @@ > > # $3 - kernel map file > > # $4 - default install path (blank if root directory) > > > > -if [ "$(basename $2)" = "Image.gz" ]; then > > +if [ "$(basename $2)" = "Image.gz" ] || [ "$(basename $2)" = "vmlinuz.efi" ] > > +then > > # Compressed install > > echo "Installing compressed kernel" > > base=vmlinuz > > This is a little messy. > > There is a KBUILD_IMAGE var which should be usable, although I see > that it is set to $(boot)/Image when 'make install' is invoked. Yeah, which is another pain point for me, because really what normal people want to use is 'make zinstall', and that's not obvious anywhere and is a pretty drastic departure from literally any other arch. > > Could we perhaps make sure that this var is set to the file to be installed? > > I also wonder how useful it is to indicate whether the image is > compressed or not, so perhaps we could just say 'Installing kernel' ? > I have no strong opinions here, I'm reticent to be messing with an install script for an arch I don't maintain. I need this change to be able to do aarch64 testing in a VM, and honestly I'm sort of surprised I'm the first person to run into this since the default stuff straight up doesn't work at all when it does for other archs. Thanks, Josef _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel