From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AC70C4167B for ; Fri, 15 Dec 2023 21:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bt43SyRrfJ+TIIVN8UIyyVqbCnTOYA3j4zaFiDwCtW4=; b=s45PmZ4CCm+vnm rg8f3rNoCQo7ztLn9gV0n11DeylzOfVo1PGCBQdRwDM67Gj0QUpQLtTYMnWemAtEvnYbdZpL//Qtf 6u1WI+SWNw0Het8gHDHoPsh4xxwjpZVaddmhvrRGxGQS5HpoIwAbZzjxbq2ZP0jaj4j8PK5C62No4 glhAIKp+7F4pLLC/QW+phQm72zZR17ofgQkh/w331AIKd38KTuaAI6YKyTuHffJEw9FsitDGuRV2a +noGjzHorWBfzp+wvNa0FB/kOaUnBfG/W8qcbZcDfb7cNYhW3yajVnofx4OJknc00pOLYwna6nzqD pXHLiXOrINs+yK/D6edQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEFxp-004dRW-2Q; Fri, 15 Dec 2023 21:43:21 +0000 Received: from mail-yw1-x112b.google.com ([2607:f8b0:4864:20::112b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rEFxm-004dR5-2v for linux-arm-kernel@lists.infradead.org; Fri, 15 Dec 2023 21:43:20 +0000 Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-5e470664062so6640657b3.0 for ; Fri, 15 Dec 2023 13:43:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20230601.gappssmtp.com; s=20230601; t=1702676596; x=1703281396; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=A+MLndK5ekN4MMfXTqrXOBM2GMh62JMliXE6p9horMw=; b=gMtjbR0u7t0FFWCAF+2aSdVI8FOA7VJUUsQ7wmz9uqzMKh9yNGi42HswzebyOKP3sU 27LccuFABqpH6GB4hsAEg1JW/6Tj/6zV8YKhSGaShIkqxAtJcD0uwbF4hTgbKlKz259m z0wQ7ebJcvvmmthGKipJCS6F539TEVtvDkL7SngrXxsh3XWTjRfdB42B3xBWSvFodOXL iyBgbiP9WELuUWiTRYQhyJSidACwHkL8x8ZH6Uv1fRcNjFsJmYZ4uwhlelSrPqyEUJ/s ft8Wr8fRyUqzWAy7qXm59w4p7p5eNM/b81UWnDTlPd1N8LJXMCxm8rOI7/4Dr36qbuJi Nt9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702676596; x=1703281396; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A+MLndK5ekN4MMfXTqrXOBM2GMh62JMliXE6p9horMw=; b=bvYF8W4B1IJOYIhUlngD8ia0oQlocwRGzs+ZHILRJzWhumimI90FuPmc95vnjQckim 5FaZeAu7jYCigdRPNkAwtdo1AL8vVRijywPLjBwHnh/7z09GOTYt41RD7y/wtnKP+ukj uxB/07niewZ+fHNdeBpuAOYup1vdyJNeWS9CT4cknJpXK3VwW2ciyNlEMnmL4yDXROuE w7kU/h6znudbqItdEBSVxjqiDzLOWul/AKGi3ykzX+TBgblHZAJzRbbiAK4P0i2uHWy7 F2Lnaqm5VeR62CvD1En5KeuBvMiKFq3mR3jVt/0Bcya7Kn4d+HWMQZK6D0sY/6IN/z+A y3dg== X-Gm-Message-State: AOJu0YxPb56Vd0DnRYrRJkYDSb5T5xGGnMGo4qi/5JK8X3ReQ9goXckx Tw2xVjhXk/t0JUgc6hMib/wvww== X-Google-Smtp-Source: AGHT+IF9lCWJijrgufGdrg2NxDCnuxpvPbSlDgny4uG86CmHb3eTt0GbBLKTl7jww5LiNVWiqygeAA== X-Received: by 2002:a81:7784:0:b0:5d9:987d:36e1 with SMTP id s126-20020a817784000000b005d9987d36e1mr6132007ywc.76.1702676596313; Fri, 15 Dec 2023 13:43:16 -0800 (PST) Received: from localhost (076-182-020-124.res.spectrum.com. [76.182.20.124]) by smtp.gmail.com with ESMTPSA id j68-20020a0df947000000b005b37c6e01f9sm6671946ywf.90.2023.12.15.13.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Dec 2023 13:43:15 -0800 (PST) Date: Fri, 15 Dec 2023 16:43:14 -0500 From: Josef Bacik To: Catalin Marinas Cc: will@kernel.org, linux-arm-kernel@lists.infradead.org, Ard Biesheuvel Subject: Re: [PATCH] arm64: properly install vmlinuz.efi Message-ID: <20231215214314.GA883762@perftesting> References: <6edb1402769c2c14c4fbef8f7eaedb3167558789.1702570674.git.josef@toxicpanda.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231215_134319_138649_012AB8D7 X-CRM114-Status: GOOD ( 24.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 15, 2023 at 08:03:39PM +0000, Catalin Marinas wrote: > On Thu, Dec 14, 2023 at 11:18:50AM -0500, Josef Bacik wrote: > > If you select CONFIG_EFI_ZBOOT, we will generate vmlinuz.efi, and then > > when we go to install the kernel we'll install the vmlinux instead > > because install.sh only recognizes Image.gz as wanting the compressed > > install image. With CONFIG_EFI_ZBOOT we don't get the proper kernel > > installed, which means it doesn't boot, which makes for a very confused > > and subsequently angry kernel developer. > > > > Fix this by properly installing our compressed kernel if we've enabled > > CONFIG_EFI_ZBOOT. > > > > Signed-off-by: Josef Bacik > > --- > > arch/arm64/boot/install.sh | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/install.sh b/arch/arm64/boot/install.sh > > index 7399d706967a..9b7a09808a3d 100755 > > --- a/arch/arm64/boot/install.sh > > +++ b/arch/arm64/boot/install.sh > > @@ -17,7 +17,8 @@ > > # $3 - kernel map file > > # $4 - default install path (blank if root directory) > > > > -if [ "$(basename $2)" = "Image.gz" ]; then > > +if [ "$(basename $2)" = "Image.gz" ] || [ "$(basename $2)" = "vmlinuz.efi" ] > > +then > > # Compressed install > > echo "Installing compressed kernel" > > base=vmlinuz > > + Ard who added the EFI_ZBOOT support. > > If we go with this fix we should probably also add: > > Fixes: c37b830fef13 ("arm64: efi: enable generic EFI compressed boot") > Cc: # 6.1.x > > But is arm64 the only one with this issue? > I can only speak for x86 and arm, x86 has been working fine using this config, I only recently started using the same thing for arm on my mac studio and ran into a variety of fun things. Thanks, Josef _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel