linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: imx8qxp-mek: Move port under USB connector
@ 2023-12-14  9:16 Fabio Estevam
  2023-12-16  1:38 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2023-12-14  9:16 UTC (permalink / raw)
  To: shawnguo; +Cc: linux-arm-kernel, jun.li, Fabio Estevam

From: Fabio Estevam <festevam@denx.de>

Per nxp,ptn5110.yaml, 'port' should be placed under 'connector'.

Do as requested to fix the following dt-schema warning:

imx8qxp-mek.dtb: tcpc@50: connector:ports: 'port@0' is a required property
        from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#
imx8qxp-mek.dtb: tcpc@50: connector: Unevaluated properties are not allowed ('ports' was unexpected)
        from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v1:
- Added a newline between properties and child node. (Shawn)

 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
index 6c3d8715bc11..9f660f386039 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts
@@ -152,12 +152,6 @@ ptn5110: tcpc@50 {
 		interrupt-parent = <&lsio_gpio1>;
 		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
 
-		port {
-			typec_dr_sw: endpoint {
-				remote-endpoint = <&usb3_drd_sw>;
-			};
-		};
-
 		usb_con1: connector {
 			compatible = "usb-c-connector";
 			label = "USB-C";
@@ -169,8 +163,17 @@ ports {
 				#address-cells = <1>;
 				#size-cells = <0>;
 
+				port@0 {
+					reg = <0>;
+
+					typec_dr_sw: endpoint {
+						remote-endpoint = <&usb3_drd_sw>;
+					};
+				};
+
 				port@1 {
 					reg = <1>;
+
 					typec_con_ss: endpoint {
 						remote-endpoint = <&usb3_data_ss>;
 					};
-- 
2.34.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] arm64: dts: imx8qxp-mek: Move port under USB connector
  2023-12-14  9:16 [PATCH v2] arm64: dts: imx8qxp-mek: Move port under USB connector Fabio Estevam
@ 2023-12-16  1:38 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2023-12-16  1:38 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: linux-arm-kernel, jun.li, Fabio Estevam

On Thu, Dec 14, 2023 at 06:16:53AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> Per nxp,ptn5110.yaml, 'port' should be placed under 'connector'.
> 
> Do as requested to fix the following dt-schema warning:
> 
> imx8qxp-mek.dtb: tcpc@50: connector:ports: 'port@0' is a required property
>         from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#
> imx8qxp-mek.dtb: tcpc@50: connector: Unevaluated properties are not allowed ('ports' was unexpected)
>         from schema $id: http://devicetree.org/schemas/usb/nxp,ptn5110.yaml#
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-16  1:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-14  9:16 [PATCH v2] arm64: dts: imx8qxp-mek: Move port under USB connector Fabio Estevam
2023-12-16  1:38 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).