From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0B39C3DA6E for ; Sun, 17 Dec 2023 17:07:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oNM1AWociSsRVxr7mYwaKnX/XxCrGn0nz39x4+cRXLQ=; b=ZiA6LewU6VspY7 BkXpXVrEd00Q+TaK2TsJBERvPpnNWLpLLwPWjv3siAUbGjlOtpD/VBEW3Yt9AFz5q2CX1rhLFxMEU lIz8WfLdpuR/ag6qJUJgN50uW4n8alHmq9LNnqnc99VmWz5eJxnhD/AVAkx4T6md9lf0cYaisFjoM a0LE/6vUWOLMalr63N5+JYnhAwKk8JFDOJxCr7qhcA1Nb9l4irZz4R6IF2FFhdnKyiQs+VylP5Yk4 ek8lgH4I61QVGmv9AxSr+VLhFCB73lMBAWHS7qmpYPH0oRW2aA1sBGqDwMlCPZKLl4s5JB6hluzkJ W8VX7hqkpABaygpIOD5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rEubg-008AcT-2S; Sun, 17 Dec 2023 17:07:12 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rEubd-008AbC-0w for linux-arm-kernel@lists.infradead.org; Sun, 17 Dec 2023 17:07:11 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1d3b81d9719so271385ad.2 for ; Sun, 17 Dec 2023 09:07:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1702832827; x=1703437627; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=/K03hCZQCPV3Olg5sBkXZ+1FaJknZTPPokPGS7pirfk=; b=Za+23X55+O3SwqQI+l/iLGp1yh/MMWBhCk3Pc9Sp5c4o0UdmhODTd1Ad4nx5oFNSas e8mVpmc5y5zOLwlesfjNWKJgzMuL8l8yup7NVFaOpxzRVhDTgoE4AVfyyc5UNlPdueeG MyfRT8Mp1Sbmn2qrtdofGQhUczV8/6/5DX8TavxoG1KveXlGvGIwaf5CGoWb2cBeTjng W2Ifyn3OkxvFXH0oLCKPogiJOK+3rLvsLiLiJecmxhBzDK1C72P786x1WzpNirjWM2to VJB9SJCE22fCmiM6xxLtwvADM7RK3aruvet3H4rOv+wSwooj80qsPv9sct0gFF+UCPXN U4ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702832827; x=1703437627; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/K03hCZQCPV3Olg5sBkXZ+1FaJknZTPPokPGS7pirfk=; b=bHvhmMFV6wiXVJsadV2gSeYG8uv0kc1H6d9bwlFR+Gxo9Ih7ZKu2MK7nPO/k67gdY0 S/MI6pmw16QJo2deu9elqzqPNAN2eXuofATiuMxnJQQHhe+cpoEFQIurZ//tf/IfKDR8 dmw1S4TJeusecoAa2Rf5nNtMJN+qsl9veNytTZuQZ6f4vC/JIu6RC8BkKdEAVHNUzRFh gZgOENECea9rtI/a8V44ZkBmpdp1PCM7QUEt5ZxMczeNDiovUkKdpYgsI0j2dxaftDfX Ziq305j3I4w9UlFmHTaOUBY8iwzVOwfa0vNx/aGJ9lUBbGJnQjIaFngDPHw+CavWvDQQ dL1g== X-Gm-Message-State: AOJu0YwF5xbbS6XOiQos4zPIojLET72f/+hHsZ0IjPEqlezEbd0fJHzg IXFGvFSFYdUqttzz27WsvSLWoz1T6C65x9/dWg== X-Google-Smtp-Source: AGHT+IF87cHE/NtQnAKvY7hzR4Yb1+nieura/Ja8Di49a65zvK6JCuAZ11jhxfgrEwKDGnHgmwq5ug== X-Received: by 2002:a17:903:11c7:b0:1d3:4783:cfc with SMTP id q7-20020a17090311c700b001d347830cfcmr5578132plh.93.1702832827014; Sun, 17 Dec 2023 09:07:07 -0800 (PST) Received: from thinkpad ([103.28.246.178]) by smtp.gmail.com with ESMTPSA id i11-20020a170902c94b00b001d359db2370sm7463049pla.152.2023.12.17.09.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 09:07:06 -0800 (PST) Date: Sun, 17 Dec 2023 22:36:55 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v4 01/15] PCI: imx6: Simplify clock handling by using bulk_clk_*() function Message-ID: <20231217170655.GC6748@thinkpad> References: <20231217051210.754832-1-Frank.Li@nxp.com> <20231217051210.754832-2-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231217051210.754832-2-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231217_090709_377496_A8A07514 X-CRM114-Status: GOOD ( 22.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU3VuLCBEZWMgMTcsIDIwMjMgYXQgMTI6MTE6NTZBTSAtMDUwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gUmVmYWN0b3JzIHRoZSBjbG9jayBoYW5kbGluZyBsb2dpYyBpbiB0aGUgaW14NiBQQ0kgZHJp dmVyIGJ5IGFkZGluZwo+IGNsa19uYW1lc1tdIGRlZmluZSBpbiBkcnZkYXRhIC4gU2ltcGxpZmll cyB0aGUgY29kZSBhbmQgbWFrZXMgaXQgbW9yZQo+IG1haW50YWluYWJsZSwgYXMgZnV0dXJlIGFk ZGl0aW9ucyBvZiBTT0Mgc3VwcG9ydCB3aWxsIG9ubHkgcmVxdWlyZQo+IHN0cmFpZ2h0Zm9yd2Fy ZCBjaGFuZ2VzLgo+IAoKQ29tbWl0IGRlc2NyaXB0aW9uIHNob3VsZCBiZSBpbiBpbXBlcmF0aXZl IG1vb2QgYXMgcGVyCkRvY3VtZW50YXRpb24vcHJvY2Vzcy9zdWJtaXR0aW5nLXBhdGNoZXMucnN0 OgoKIkRlc2NyaWJlIHlvdXIgY2hhbmdlcyBpbiBpbXBlcmF0aXZlIG1vb2QsIGUuZy4gIm1ha2Ug eHl6enkgZG8gZnJvdHoiCmluc3RlYWQgb2YgIltUaGlzIHBhdGNoXSBtYWtlcyB4eXp6eSBkbyBm cm90eiIgb3IgIltJXSBjaGFuZ2VkIHh5enp5CnRvIGRvIGZyb3R6IiwgYXMgaWYgeW91IGFyZSBn aXZpbmcgb3JkZXJzIHRvIHRoZSBjb2RlYmFzZSB0byBjaGFuZ2UKaXRzIGJlaGF2aW91ci4iCgo+ IFNpZ25lZC1vZmYtYnk6IEZyYW5rIExpIDxGcmFuay5MaUBueHAuY29tPgo+IC0tLQo+IAo+IE5v dGVzOgo+ICAgICBDaGFuZ2UgZnJvbSB2MyB0byB2NAo+ICAgICAtIHVzaW5nIGNsa19idWxrXyoo KSBBUEkKPiAgICAgQ2hhbmdlIGZyb20gdjEgdG8gdjMKPiAgICAgLSBub25lCj4gCj4gIGRyaXZl cnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1pbXg2LmMgfCAxMjggKysrKysrKystLS0tLS0tLS0t LS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDkwIGRlbGV0aW9u cygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktaW14 Ni5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWlteDYuYwo+IGluZGV4IDc0NzAz MzYyYWVlYzcuLjIwODYyMTQzNDVlOWEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9wY2kvY29udHJv bGxlci9kd2MvcGNpLWlteDYuYwo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3Bj aS1pbXg2LmMKClsuLi5dCgo+ICBzdGF0aWMgdm9pZCBpbXg2X3BjaWVfYXNzZXJ0X2NvcmVfcmVz ZXQoc3RydWN0IGlteDZfcGNpZSAqaW14Nl9wY2llKQo+IEBAIC0xMzA1LDMyICsxMjY1LDE5IEBA IHN0YXRpYyBpbnQgaW14Nl9wY2llX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYp Cj4gIAkJcmV0dXJuIGlteDZfcGNpZS0+cmVzZXRfZ3BpbzsKPiAgCX0KPiAgCj4gLQkvKiBGZXRj aCBjbG9ja3MgKi8KPiAtCWlteDZfcGNpZS0+cGNpZV9idXMgPSBkZXZtX2Nsa19nZXQoZGV2LCAi cGNpZV9idXMiKTsKPiAtCWlmIChJU19FUlIoaW14Nl9wY2llLT5wY2llX2J1cykpCj4gLQkJcmV0 dXJuIGRldl9lcnJfcHJvYmUoZGV2LCBQVFJfRVJSKGlteDZfcGNpZS0+cGNpZV9idXMpLAo+IC0J CQkJICAgICAicGNpZV9idXMgY2xvY2sgc291cmNlIG1pc3Npbmcgb3IgaW52YWxpZFxuIik7Cj4g Kwl3aGlsZSAoaW14Nl9wY2llLT5kcnZkYXRhLT5jbGtfbmFtZXNbaW14Nl9wY2llLT5jbGtzX2Nu dF0pIHsKPiArCQlpbnQgaSA9IGlteDZfcGNpZS0+Y2xrc19jbnQ7Cj4gIAo+IC0JaW14Nl9wY2ll LT5wY2llID0gZGV2bV9jbGtfZ2V0KGRldiwgInBjaWUiKTsKPiAtCWlmIChJU19FUlIoaW14Nl9w Y2llLT5wY2llKSkKPiAtCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIFBUUl9FUlIoaW14Nl9w Y2llLT5wY2llKSwKPiAtCQkJCSAgICAgInBjaWUgY2xvY2sgc291cmNlIG1pc3Npbmcgb3IgaW52 YWxpZFxuIik7Cj4gKwkJaW14Nl9wY2llLT5jbGtzW2ldLmlkID0gaW14Nl9wY2llLT5kcnZkYXRh LT5jbGtfbmFtZXNbaV07Cj4gKwkJaW14Nl9wY2llLT5jbGtzX2NudCsrOwoKWW91IGNhbiBqdXN0 IGluaXRpYWxpemUgY2xrc19jbnQgaW4gZHJ2X2RhdGEgd2l0aCBzaXplb2YoKSBvZiBjbGtfbmFt ZXMuCgo+ICsJfQo+ICsKPiArCS8qIEZldGNoIGNsb2NrcyAqLwo+ICsJcmV0ID0gZGV2bV9jbGtf YnVsa19nZXQoZGV2LCBpbXg2X3BjaWUtPmNsa3NfY250LCBpbXg2X3BjaWUtPmNsa3MpOwo+ICsJ aWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICAKPiAgCXN3aXRjaCAoaW14Nl9wY2llLT5kcnZk YXRhLT52YXJpYW50KSB7Cj4gLQljYXNlIElNWDZTWDoKPiAtCQlpbXg2X3BjaWUtPnBjaWVfaW5i b3VuZF9heGkgPSBkZXZtX2Nsa19nZXQoZGV2LAo+IC0JCQkJCQkJICAgInBjaWVfaW5ib3VuZF9h eGkiKTsKPiAtCQlpZiAoSVNfRVJSKGlteDZfcGNpZS0+cGNpZV9pbmJvdW5kX2F4aSkpCj4gLQkJ CXJldHVybiBkZXZfZXJyX3Byb2JlKGRldiwgUFRSX0VSUihpbXg2X3BjaWUtPnBjaWVfaW5ib3Vu ZF9heGkpLAo+IC0JCQkJCSAgICAgInBjaWVfaW5ib3VuZF9heGkgY2xvY2sgbWlzc2luZyBvciBp bnZhbGlkXG4iKTsKPiAtCQlicmVhazsKPiAtCWNhc2UgSU1YOE1ROgo+IC0JY2FzZSBJTVg4TVFf RVA6Cj4gLQkJaW14Nl9wY2llLT5wY2llX2F1eCA9IGRldm1fY2xrX2dldChkZXYsICJwY2llX2F1 eCIpOwo+IC0JCWlmIChJU19FUlIoaW14Nl9wY2llLT5wY2llX2F1eCkpCj4gLQkJCXJldHVybiBk ZXZfZXJyX3Byb2JlKGRldiwgUFRSX0VSUihpbXg2X3BjaWUtPnBjaWVfYXV4KSwKPiAtCQkJCQkg ICAgICJwY2llX2F1eCBjbG9jayBzb3VyY2UgbWlzc2luZyBvciBpbnZhbGlkXG4iKTsKPiAtCQlm YWxsdGhyb3VnaDsKPiAgCWNhc2UgSU1YN0Q6Cj4gIAkJaWYgKGRiaV9iYXNlLT5zdGFydCA9PSBJ TVg4TVFfUENJRTJfQkFTRV9BRERSKQo+ICAJCQlpbXg2X3BjaWUtPmNvbnRyb2xsZXJfaWQgPSAx Owo+IEBAIC0xMzUzLDEwICsxMzAwLDYgQEAgc3RhdGljIGludCBpbXg2X3BjaWVfcHJvYmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCWNhc2UgSU1YOE1NX0VQOgo+ICAJY2FzZSBJ TVg4TVA6Cj4gIAljYXNlIElNWDhNUF9FUDoKPiAtCQlpbXg2X3BjaWUtPnBjaWVfYXV4ID0gZGV2 bV9jbGtfZ2V0KGRldiwgInBjaWVfYXV4Iik7Cj4gLQkJaWYgKElTX0VSUihpbXg2X3BjaWUtPnBj aWVfYXV4KSkKPiAtCQkJcmV0dXJuIGRldl9lcnJfcHJvYmUoZGV2LCBQVFJfRVJSKGlteDZfcGNp ZS0+cGNpZV9hdXgpLAo+IC0JCQkJCSAgICAgInBjaWVfYXV4IGNsb2NrIHNvdXJjZSBtaXNzaW5n IG9yIGludmFsaWRcbiIpOwo+ICAJCWlteDZfcGNpZS0+YXBwc19yZXNldCA9IGRldm1fcmVzZXRf Y29udHJvbF9nZXRfZXhjbHVzaXZlKGRldiwKPiAgCQkJCQkJCQkJICJhcHBzIik7Cj4gIAkJaWYg KElTX0VSUihpbXg2X3BjaWUtPmFwcHNfcmVzZXQpKQo+IEBAIC0xMzcyLDE0ICsxMzE1LDYgQEAg c3RhdGljIGludCBpbXg2X3BjaWVfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikK PiAgCWRlZmF1bHQ6Cj4gIAkJYnJlYWs7Cj4gIAl9Cj4gLQkvKiBEb24ndCBmZXRjaCB0aGUgcGNp ZV9waHkgY2xvY2ssIGlmIGl0IGhhcyBhYnN0cmFjdCBQSFkgZHJpdmVyICovCj4gLQlpZiAoaW14 Nl9wY2llLT5waHkgPT0gTlVMTCkgewo+IC0JCWlteDZfcGNpZS0+cGNpZV9waHkgPSBkZXZtX2Ns a19nZXQoZGV2LCAicGNpZV9waHkiKTsKPiAtCQlpZiAoSVNfRVJSKGlteDZfcGNpZS0+cGNpZV9w aHkpKQo+IC0JCQlyZXR1cm4gZGV2X2Vycl9wcm9iZShkZXYsIFBUUl9FUlIoaW14Nl9wY2llLT5w Y2llX3BoeSksCj4gLQkJCQkJICAgICAicGNpZV9waHkgY2xvY2sgc291cmNlIG1pc3Npbmcgb3Ig aW52YWxpZFxuIik7Cj4gLQl9Cj4gLQo+ICAKPiAgCS8qIEdyYWIgdHVybm9mZiByZXNldCAqLwo+ ICAJaW14Nl9wY2llLT50dXJub2ZmX3Jlc2V0ID0gZGV2bV9yZXNldF9jb250cm9sX2dldF9vcHRp b25hbF9leGNsdXNpdmUoZGV2LCAidHVybm9mZiIpOwo+IEBAIC0xNDcwLDYgKzE0MDUsOSBAQCBz dGF0aWMgdm9pZCBpbXg2X3BjaWVfc2h1dGRvd24oc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKPiAgCWlteDZfcGNpZV9hc3NlcnRfY29yZV9yZXNldChpbXg2X3BjaWUpOwo+ICB9Cj4gIAo+ ICsjZGVmaW5lIElNWDZfQ0xLU19DT01NT04gInBjaWVfYnVzIiwgInBjaWUiCj4gKyNkZWZpbmUg SU1YNl9DTEtTX05PX1BIWURSViBJTVg2X0NMS1NfQ09NTU9OLCAicGNpZV9waHkiCj4gKwoKSnVz dCB1c2UgdGhlIGNsb2NrIG5hbWVzIGRpcmVjdGx5IGluc3RlYWQgb2YgZGVmaW5pdGlvbnMuIEl0 IG1ha2VzIHRoZSBjb2RlIG1vcmUKcmVhZGFibGUuCgpSZXN0IExHVE0hCgotIE1hbmkKCi0tIArg rq7grqPgrr/grrXgrqPgr43grqPgrqngr40g4K6a4K6k4K6+4K6a4K6/4K614K6u4K+NCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==