From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BF47C35274 for ; Mon, 18 Dec 2023 15:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SOuDe/H93ajpvbiqKxn8FAma/NZtHunkrLjG/Rs5eGw=; b=n+Os3UQJ0vIGvADBZTZ5XynrfY EH9a3+ClNa7KD1uGsXR8rf/0MRcE+pBi+I63GKQC+ndi2ExfFGnZ/Z9xwtBbjjkhWdboDqpc8kVv0 onVT57YmKGFgiQI/5jfyHxGGmdnc657jJKnwWGq6KMEhnAsCGNzdBDuZm3JdO17ikjUJrNDISp/Ei HZLbApMExs2EP1nWCC7YvbHAsQ15QwzryKZqTvls5Dx7Eaa5INMWOh+RoKSE6OKaAY8W9UT2pa5YA NIWNQyX6DMy2S7sLim5Ewg8pgEmAgfFdwMbh7JgUFi6IV1NrAi/W1uMoG/34q79mWzaUY4z42AF47 enPOfsxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFF5j-00B7gF-1x; Mon, 18 Dec 2023 14:59:35 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFF5g-00B7eG-2C; Mon, 18 Dec 2023 14:59:34 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 98E75CE0B2A; Mon, 18 Dec 2023 14:59:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30277C433C8; Mon, 18 Dec 2023 14:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702911568; bh=+s1PxLoBbDNRFaBMX1KOfgXL4tbGv/n20FEjafyPq/w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mSbBcYtIEC/E7RqBQIzkCxec5TKgazZsWXYPY9+enwlKZ6OrEtXBMl8SgdPgJxfni krjGAU88aSHxxRA9x2MosUdLH2JQEF3QyLCBsR4LT//axdCB2DPmzwqsq8FQ9OuVrQ 9FLgC5B75iasJpQCBSSE/PM26xfwWhdbZy81d6LhGHghtD+3r8iDWC07xhx6g+gh4p h1ttAeppZzSTCNU8XIlDlD1c8K//wMRQYcfd1poIbVGlHSBJGByodmP+Xa7zynYPx7 dKgH4hQkK0Ik3hIiPZyIbjUigosGJhLSxyisitYnEJ+EFf1Yf/bmYq+R7HPmtThshI dXPcLYPG7K52A== Date: Mon, 18 Dec 2023 14:59:20 +0000 From: Conor Dooley To: Cristian Ciocaltea Cc: Samuel Holland , Jessica Clarke , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Samin Guo , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , Michael Turquette , Stephen Boyd , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Giuseppe Cavallaro , netdev@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , linux-riscv , linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v3 2/9] dt-bindings: net: starfive,jh7110-dwmac: Add JH7100 SoC compatible Message-ID: <20231218-snowcap-charter-f8c75312eaa9@spud> References: <20231215204050.2296404-1-cristian.ciocaltea@collabora.com> <20231215204050.2296404-3-cristian.ciocaltea@collabora.com> <65fd52f1-6861-42b0-9148-266766d054b1@sifive.com> <6c62e3b2-acde-4580-9b67-56683289e45e@collabora.com> <20231217-spray-livestock-a59d630b751e@spud> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_065933_187587_125B41F7 X-CRM114-Status: GOOD ( 15.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3711262847673007377==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3711262847673007377== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xehaJyWNZIrFr2oM" Content-Disposition: inline --xehaJyWNZIrFr2oM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > Won't this also relax the naming for all devices that allow a single > > reset, but expect the stmmaceth one? I'm not sure that that actually > > matters, I think the consumer bindings have constraints themselves. >=20 > Before commit 843f603762a5 ("dt-bindings: net: snps,dwmac: Add 'ahb' > reset/reset-name"), the 'stmmaceth' was the only possible option, hence > there was no need for any constraints on the consumer bindings. But > afterwards it was allowed to use both resets, hence I think the bindings > should have been updated at that time by adding 'maxItems: 1' to prevent > using the 2nd reset. >=20 > I could fix this in a separate series, if it's not something mandatory > to be handled here. If it is not introduced by this series, I don't see why it could not be handled separately if needed. --xehaJyWNZIrFr2oM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZYBeSAAKCRB4tDGHoIJi 0kaHAQDOEcbXi7+qAEGh2DmnasVoZMuRlaf7aM8UbL0TedMfrAEAz4ujNDzOgg49 iA4wb0r9fYms/C/CCKtbwb34l7U9Wg8= =8B0i -----END PGP SIGNATURE----- --xehaJyWNZIrFr2oM-- --===============3711262847673007377== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3711262847673007377==--