From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12899C3DA6E for ; Mon, 18 Dec 2023 02:23:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b3ICJrtoYNrJtjyIefwO3UqeUlG6DAeTL+F9V8zDPAE=; b=wPUHkBdXkh8gmu UDylPiQtnilFo1ZKBoCNjYY6LlQjvgcxXmhx9hWOy8iX0R5xTc/BGgUxHv2B+AaCXUVs2r3Dz73hM ji0/tsSf0/t9dzYlMPHz/vuPB4WdbuJX+oCN/X46CCifGOshShwYa0hepmxVc/9ln6GPDdbJHP1h3 vZqnYJCpMdzs6gYAHSl4b7C3ZeZller4m4LF6kivQ82Ew78Qd/8KZDfeeir8GPwsrb0LyFv1T0t73 0zF+gSlrBt2bXqIb8qE0ARwsLF9Zy+QG9bQjdyBVNrmSHAigIDgK8CcbH60dv9Gbl1t4azY758NZ8 rd4nAmcBm5bnBf3ZXiaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rF3Hy-008qNn-2F; Mon, 18 Dec 2023 02:23:26 +0000 Received: from mail-ot1-f50.google.com ([209.85.210.50]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rF3Hw-008qMy-0S for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 02:23:25 +0000 Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6d9f4eed60eso2355865a34.1 for ; Sun, 17 Dec 2023 18:23:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702866201; x=1703471001; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UUh8R+nscKiO1LQ6m0AM82k3aN4ql71rUMxjIgccdr8=; b=LNgQCUPBFk0sL04OSG6dwCVGyc25Xgue64T7/k0R2izz6w609VX90rXS2xynXu5x8Z xGf+k8U8jttHCFtMd7LeL9Ws9WXw0hujWwyCzznrwThN6YYu02zKSUgZ2c9+pb1b2wA6 Cd5tTfQW/ULOQgczV1wdfe0C42vamk9gWtYLmeEhxOkv6U8G44VBpJkEq6mDCN/Iq0TE 3er2zzHUFo0JiLJFOhAa33EhDPielqGnh8xISIITz6V3EbP6GeLNw8HSBrvwrBYDNQ1A Ll68+uXT+EtBvqX01ciFv6n68GpjUMLZB8o6YlFEose8ll87VbtR13SlKkUoLEmRHFK+ zMFw== X-Gm-Message-State: AOJu0YyfOtKxDErZWCS9o0RqVDlFmRsgX2d5IrsVQO6ZOU+r0EU+om4+ 3f8OcwpknS1JxU81ZSQ0jWY= X-Google-Smtp-Source: AGHT+IG7l7NST7Kn9f3sLGp2h7mChkuDh/xWs1QvXERaxEiq+3xoxgLsb1E4JkSVVfl6qQmllcIHwg== X-Received: by 2002:a05:6358:2608:b0:172:cf9c:882a with SMTP id l8-20020a056358260800b00172cf9c882amr1348802rwc.32.1702866201513; Sun, 17 Dec 2023 18:23:21 -0800 (PST) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id ms16-20020a17090b235000b0028b06464b62sm1959293pjb.15.2023.12.17.18.23.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 18:23:20 -0800 (PST) Date: Mon, 18 Dec 2023 11:23:19 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Yang Li Cc: lpieralisi@kernel.org, robh@kernel.org, bhelgaas@google.com, michal.simek@amd.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH -next] PCI: xilinx-xdma: Remove redundant dev_err() Message-ID: <20231218022319.GC88933@rocinante> References: <20231030061242.51475-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231030061242.51475-1-yang.lee@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231217_182324_204556_90FD71E3 X-CRM114-Status: GOOD ( 10.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/pci/controller/pcie-xilinx-dma-pl.c:688:2-9: line 688 is redundant because platform_get_irq() already prints an error > ./drivers/pci/controller/pcie-xilinx-dma-pl.c:702:2-9: line 702 is redundant because platform_get_irq() already prints an error Applied to controller/xilinx, thank you! [1/1] PCI: xilinx-xdma: Remove redundant dev_err() https://git.kernel.org/pci/pci/c/b642e081f46c Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel