From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Dhruva Gole <d-gole@ti.com>
Subject: Re: [PATCH v2 1/1] arm64: dts: ti: k3-am62-wakeup: Configure ti-sysc for wkup_uart0
Date: Mon, 18 Dec 2023 09:28:31 +0200 [thread overview]
Message-ID: <20231218072831.GX5169@atomide.com> (raw)
In-Reply-To: <20231215160047.uiitnlgmirbudmj5@scored>
* Nishanth Menon <nm@ti.com> [231215 16:00]:
> On 09:32-20231114, Tony Lindgren wrote:
> > - wkup_uart0: serial@2b300000 {
> > - compatible = "ti,am64-uart", "ti,am654-uart";
> > - reg = <0x00 0x2b300000 0x00 0x100>;
> > - interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>;
> > + target-module@2b300000 {
>
> should be target-module@2b300050 to match up with reg?
It's best to use the target-module IO range here, not the first reg.
The first reg may be tossed anywhere in the target module address
space depending on the device.
Ideally of course there would be just a standardized range of target
module related registers at the end of the IO space..
> > + wkup_uart0: serial@2b300000 {
>
> serial@0 to match up with reg?
Yes thanks for catching this. The 8250 IP is at the beginning of the
target module IO space. Will post an updated patch.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-18 7:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 7:32 [PATCH v2 1/1] arm64: dts: ti: k3-am62-wakeup: Configure ti-sysc for wkup_uart0 Tony Lindgren
2023-12-05 18:13 ` Kevin Hilman
2023-12-07 6:08 ` Tony Lindgren
2023-12-08 17:13 ` Kevin Hilman
2023-12-09 3:59 ` Tony Lindgren
2023-12-13 15:41 ` Kevin Hilman
2023-12-15 16:00 ` Nishanth Menon
2023-12-18 7:28 ` Tony Lindgren [this message]
2023-12-18 16:19 ` Nishanth Menon
2023-12-19 7:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218072831.GX5169@atomide.com \
--to=tony@atomide.com \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nm@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).