From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D50B3C35274 for ; Mon, 18 Dec 2023 07:29:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w66NnU44+ta+Dv9YhN17+Ktv+ZJkoEZYGdEuFBlPlFg=; b=zqkzkKB6vFf+7L AqLb8i6H24aILLqlkhevl2vs/6EkqsOJLF4l7kgDrvhOSYzLqywChVAbIYr7s2HqnTn83NIl0iENy 1kUlDxjnmcI/e2J059Lnsis29MzLV7XOYFVV1tDASyLTGfQwwXDwyXi9dB8LJTxj+uPUlZ/wR0oON DsNpe5FrzCmGLlwvB7H3EFprMYkI/TEajzMbra1O3c/8F+/xSR1adjdyThRdCUDlnq6WglYgssPQn +IcbHZt8cJgVHPYtqmN1VKvMn58igqZCqYwKZhWPdNE5TIGYrqgX5jiocTHvx4Uv+PhjCLZDYrS/J k9j/0pZLUIFQ1TdL+ddg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rF83X-009M3I-08; Mon, 18 Dec 2023 07:28:51 +0000 Received: from mail5.25mail.st ([74.50.62.9]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rF83T-009M1P-2F for linux-arm-kernel@lists.infradead.org; Mon, 18 Dec 2023 07:28:49 +0000 Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id B4952603E6; Mon, 18 Dec 2023 07:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1702884524; bh=mCAMHe2usGbdnFzkYddMtDLafHED4q3/YlsyM0cAnTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i4W4zfsYFfCIv/CEx86jNHRyZ2geiq+/yZ23UZBWKzr+theHILYzx4S+w4lfXb1o+ GVcNFdd/UyTyw30Q0qyKI50YMPkilhwSTvNKTCDe4lBTv46Eqk6pt9yHY0TTgy/V4F l4QfASoMBy5CCz62Aw/g+EP1+ux4hAisdbiw1cjkY/cXDgLHLEUmYGCnmW5gDW4B7Z 86A82BE4vQSMqxfs3Wr1kubOpKYEHzyi9ZHAkIc4OkzfHPQwEFrrfiErUX/5iy5fJL BWjupEAqmJHNQWEEekp/GpPUtqZMkKwhw4UfGhRprrqj+6u7/1NFaXiewKAc95leJ1 PoshEIwp8rmjA== Date: Mon, 18 Dec 2023 09:28:31 +0200 From: Tony Lindgren To: Nishanth Menon Cc: Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dhruva Gole Subject: Re: [PATCH v2 1/1] arm64: dts: ti: k3-am62-wakeup: Configure ti-sysc for wkup_uart0 Message-ID: <20231218072831.GX5169@atomide.com> References: <20231114073209.40756-1-tony@atomide.com> <20231215160047.uiitnlgmirbudmj5@scored> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231215160047.uiitnlgmirbudmj5@scored> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231217_232847_924529_6566ED65 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Nishanth Menon [231215 16:00]: > On 09:32-20231114, Tony Lindgren wrote: > > - wkup_uart0: serial@2b300000 { > > - compatible = "ti,am64-uart", "ti,am654-uart"; > > - reg = <0x00 0x2b300000 0x00 0x100>; > > - interrupts = ; > > + target-module@2b300000 { > > should be target-module@2b300050 to match up with reg? It's best to use the target-module IO range here, not the first reg. The first reg may be tossed anywhere in the target module address space depending on the device. Ideally of course there would be just a standardized range of target module related registers at the end of the IO space.. > > + wkup_uart0: serial@2b300000 { > > serial@0 to match up with reg? Yes thanks for catching this. The 8250 IP is at the beginning of the target module IO space. Will post an updated patch. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel