From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A43DDC41535 for ; Tue, 19 Dec 2023 07:07:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dWOXX+GhKGCFvpJyRMNp67P5WGqAFkUF+tF+qcaa28A=; b=rh7oavUjzdPUYT bFMCvnmdyFiH+FnRi8C2apsyGjCxqro18H3wycLpzyjj7Q6D9CzBhFnj1PqtdGOvm4HYXOlo8WO0Y xil1wZYL7EXoFceEunQc071XHNmLeQN50eFBo5TpnAKnHzLejW0Rlq6V10Y8sXc9jbzJywMKBZlC4 uhDvu9owZpFXj3IWj7GYai03xrsNH/eB7LWiuu+8AFmxuHx3y5Kqqn9LS1Q9WZ5o7ftdIeCr5NcFc q5kDdfKZXJBBXF4NWVgZ6+u+S+YH4qfyDnORQq1FwN906B/ZGZzE84pQWRgSanVXCQCJW2GLfsviL EbR+IJvFqGKyB19+5zmA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rFUBi-00D2cj-3D; Tue, 19 Dec 2023 07:06:47 +0000 Received: from mail5.25mail.st ([74.50.62.9]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rFUBe-00D2c6-26 for linux-arm-kernel@lists.infradead.org; Tue, 19 Dec 2023 07:06:44 +0000 Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 90CD16042F; Tue, 19 Dec 2023 07:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1702969598; bh=XhaGsbrzDY6cfWeXx6A5hjCUF5w7xc41H8HvthEvk8w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dX+GZzuDrYYO1rUmn/Uu18+JHA42d5TMiP1Bq5uPkoc80m8IRd+OSMpvfCaMIWIIS R1tg/5msLSoUe7CJ+wJem0UCJLswJO/cnilwI0kBWnFpy16SY4kVgrWfnSEosCPv0b dF3/3ZyX9Re7NGwbK3UFi5lGrDgK+w1esZTLwoSXDxnVSzpLsOwLj1VaPGfKNHu6Ug T4ZqMGzos6V8RHLfug3IWkYRoqIB6cJBFfmlzZPUfXZh4qNmbPfQwnyeM91VYbZB+N dqm1aHOSJEApudkxagsyRZf4WlAKsPSRwZGQ488Fp2ynFvm9fwCG86uW9koEUr6/a8 HJ3SHjIEVbHOg== Date: Tue, 19 Dec 2023 09:06:25 +0200 From: Tony Lindgren To: Nishanth Menon Cc: Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Dhruva Gole Subject: Re: [PATCH v2 1/1] arm64: dts: ti: k3-am62-wakeup: Configure ti-sysc for wkup_uart0 Message-ID: <20231219070625.GZ5169@atomide.com> References: <20231114073209.40756-1-tony@atomide.com> <20231215160047.uiitnlgmirbudmj5@scored> <20231218072831.GX5169@atomide.com> <20231218161902.nfdht2hk5rctzxuu@grievance> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231218161902.nfdht2hk5rctzxuu@grievance> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231218_230642_970952_52709349 X-CRM114-Status: GOOD ( 19.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Nishanth Menon [231218 16:19]: > On 09:28-20231218, Tony Lindgren wrote: > > * Nishanth Menon [231215 16:00]: > > > On 09:32-20231114, Tony Lindgren wrote: > > > > - wkup_uart0: serial@2b300000 { > > > > - compatible = "ti,am64-uart", "ti,am654-uart"; > > > > - reg = <0x00 0x2b300000 0x00 0x100>; > > > > - interrupts = ; > > > > + target-module@2b300000 { > > > > > > should be target-module@2b300050 to match up with reg? > > > > It's best to use the target-module IO range here, not the first reg. > > The first reg may be tossed anywhere in the target module address > > space depending on the device. > > > > Ideally of course there would be just a standardized range of target > > module related registers at the end of the IO space.. > > Sorry Tony, but the node address must matchup with the reg description > for the node. I'd rather not sit and argue about this with automated > tools and deal with trivial patches - so either tools like dtc need to > ignore this or lets just fix the node address. Oh sorry I did not mean to add a make W=1 dtbs warning. Yeah let's change the node name to match the first reg to avoid the warning. It should be also add some better checks for node names with ranges but with just a few control registers. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel